[pytorch] Enable memory map file support for Android, Apple, and CXX #88545
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88545
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 27fd850: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
|
|
This pull request was exported from Phabricator. Differential Revision: D41054824 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D41054824 |
Rittzz
force-pushed
the
export-D41054824
branch
from
fe08c18 to
4fc933e
Compare
…ytorch#88545) Summary: Pull Request resolved: pytorch#88545 See title. Left Windows out so it still compiles. Test Plan: Add a `#fail` below [this line](https://fburl.com/code/p0mlhlw4) and build for various platforms and confirm it fails which proves the `#ifdef` was hit. ``` buck2 build xplat/langtech/tuna/cli:tuclixAndroid buck2 build xplat/langtech/tuna/cli:tuclix ``` CI/CD for the rest. Reviewed By: qihqi Differential Revision: D41054824 fbshipit-source-id: 1ffd4f44eb6fc697c484259c34a6803b1b9cdabd
|
This pull request was exported from Phabricator. Differential Revision: D41054824 |
Rittzz
force-pushed
the
export-D41054824
branch
from
4fc933e to
27fd850
Compare
|
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: The following mandatory check(s) failed (Rule Dig deeper by viewing the failures on hud Details for Dev Infra teamRaised by workflow job |
|
/easycla |
1 similar comment
|
/easycla |
|
@pytorchbot merge -f "Landed internally already" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…ytorch#88545) Summary: See title. Left Windows out so it still compiles. Test Plan: Add a `#fail` below [this line](https://fburl.com/code/p0mlhlw4) and build for various platforms and confirm it fails which proves the `#ifdef` was hit. ``` buck2 build xplat/langtech/tuna/cli:tuclixAndroid buck2 build xplat/langtech/tuna/cli:tuclix ``` CI/CD for the rest. Differential Revision: D41054824 Pull Request resolved: pytorch#88545 Approved by: https://github.com/qihqi
6 participants
Summary: See title. Left Windows out so it still compiles.
Test Plan:
Add a
#failbelow this line and build for various platforms and confirm it fails which proves the#ifdefwas hit.CI/CD for the rest.
Differential Revision: D41054824