[ao] removing private from allowlist #88404
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: removed functions like _add_observer_ from allowlist since they've been made private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Nov 3, 2022
Summary: removed functions like _add_observer_ from allowlist since they've been made private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: removed functions like _add_observer_ from allowlist since they've been made private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Contributor
Author
|
@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: removed functions like _add_observer_ from allowlist since they've been made private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D41015541](https://our.internmc.facebook.com/intern/diff/D41015541) [ghstack-poisoned]
Summary: removed functions like _add_observer_ from allowlist since they've been made private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D41015541](https://our.internmc.facebook.com/intern/diff/D41015541) [ghstack-poisoned]
Contributor
Author
|
@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: removed functions like _add_observer_ from allowlist since they've been made private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D41015541](https://our.internmc.facebook.com/intern/diff/D41015541) [ghstack-poisoned]
Contributor
Author
|
@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
jcaip
approved these changes
Nov 11, 2022
Summary: removed functions like _add_observer_ from allowlist since they've been made private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D41015541](https://our.internmc.facebook.com/intern/diff/D41015541) [ghstack-poisoned]
Summary: removed functions like _add_observer_ from allowlist since they've been made private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D41015541](https://our.internmc.facebook.com/intern/diff/D41015541) [ghstack-poisoned]
Summary: removed functions like _add_observer_ from allowlist since they've been made private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D41015541](https://our.internmc.facebook.com/intern/diff/D41015541) [ghstack-poisoned]
Contributor
Author
|
@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: removed functions like _add_observer_ from allowlist since they've been made private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D41015541](https://our.internmc.facebook.com/intern/diff/D41015541) [ghstack-poisoned]
Summary: removed functions like _add_observer_ from allowlist since they've been made private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D41015541](https://our.internmc.facebook.com/intern/diff/D41015541) [ghstack-poisoned]
Summary: removed functions like _add_observer_ from allowlist since they've been made private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D41015541](https://our.internmc.facebook.com/intern/diff/D41015541) [ghstack-poisoned]
Summary: removed functions like _add_observer_ from allowlist since they've been made private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D41015541](https://our.internmc.facebook.com/intern/diff/D41015541) [ghstack-poisoned]
Summary: removed functions like _add_observer_ from allowlist since they've been made private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D41015541](https://our.internmc.facebook.com/intern/diff/D41015541) [ghstack-poisoned]
albanD
approved these changes
Nov 22, 2022
anjali411
approved these changes
Nov 28, 2022
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: removed functions like add_observer from allowlist since
they've been made private
Test Plan: python test/test_public_bindings.py
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D41015541