[ao][fx] fixing public v private qconfig_mapping_utils.py #88399

HDCharles · 2022-11-03T04:29:55Z

Stack from ghstack (oldest at bottom):

-> [ao][fx] fixing public v private qconfig_mapping_utils.py #88399

Summary: made _check_is_valid_config_dict,
_compare_prepare_convert_qconfig_mappings,
_generate_node_name_to_qconfig,
_is_qconfig_supported_by_dtype_configs,
_maybe_adjust_qconfig_for_module_name_object_type_order,
_update_qconfig_for_fusion private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D41015544

cc @jerryzh168 @jianyuh @raghuramank100 @jamesr66a @vkuzo @jgong5 @Xia-Weiwen @leslie-fang-intel

Summary: made _check_is_valid_config_dict, _compare_prepare_convert_qconfig_mappings, _generate_node_name_to_qconfig, _is_qconfig_supported_by_dtype_configs, _maybe_adjust_qconfig_for_module_name_object_type_order, _update_qconfig_for_fusion private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

pytorch-bot · 2022-11-03T04:29:58Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88399

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Failures

As of commit a1b9897:

FLAKY - The following jobs failed but were likely due to flakiness present on master:

linux-focal-rocm5.3-py3.8 / test (default, 1, 2, linux.rocm.gpu)

BROKEN TRUNK - The following jobs failed but were present on the merge base 283cf71:

linux-bionic-cuda11.6-py3.10-gcc7 / test (deploy, 1, 1, linux.4xlarge.nvidia.gpu)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Summary: made _check_is_valid_config_dict, _compare_prepare_convert_qconfig_mappings, _generate_node_name_to_qconfig, _is_qconfig_supported_by_dtype_configs, _maybe_adjust_qconfig_for_module_name_object_type_order, _update_qconfig_for_fusion private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen [ghstack-poisoned]

HDCharles · 2022-11-04T03:58:21Z

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary: made _check_is_valid_config_dict, _compare_prepare_convert_qconfig_mappings, _generate_node_name_to_qconfig, _is_qconfig_supported_by_dtype_configs, _maybe_adjust_qconfig_for_module_name_object_type_order, _update_qconfig_for_fusion private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen Differential Revision: [D41015544](https://our.internmc.facebook.com/intern/diff/D41015544) [ghstack-poisoned]

HDCharles · 2022-11-04T16:39:46Z

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary: made _check_is_valid_config_dict, _compare_prepare_convert_qconfig_mappings, _generate_node_name_to_qconfig, _is_qconfig_supported_by_dtype_configs, _maybe_adjust_qconfig_for_module_name_object_type_order, _update_qconfig_for_fusion private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D41015544](https://our.internmc.facebook.com/intern/diff/D41015544) cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel [ghstack-poisoned]

Pull Request resolved: #88399 made _check_is_valid_config_dict, _compare_prepare_convert_qconfig_mappings, _generate_node_name_to_qconfig, _is_qconfig_supported_by_dtype_configs, _maybe_adjust_qconfig_for_module_name_object_type_order, _update_qconfig_for_fusion private ghstack-source-id: 176062423 Differential Revision: [D41015544](https://our.internmc.facebook.com/intern/diff/D41015544/)

HDCharles · 2022-12-14T02:28:56Z

@pytorchmergebot merge

pytorchmergebot · 2022-12-14T02:32:08Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2022-12-14T02:52:23Z

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 700b7dbdba65295968c6b4f9cac22e46686e54fa returned non-zero exit code 1

Auto-merging test/quantization/fx/test_quantize_fx.py
Auto-merging torch/ao/ns/_numeric_suite_fx.py
CONFLICT (content): Merge conflict in torch/ao/ns/_numeric_suite_fx.py
Auto-merging torch/ao/quantization/fx/convert.py
Auto-merging torch/ao/quantization/fx/prepare.py
error: could not apply 700b7dbdba... [ao][fx] fixing public v private qconfig_mapping_utils.py
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Details for Dev Infra team

Raised by workflow job

Summary: made _check_is_valid_config_dict, _compare_prepare_convert_qconfig_mappings, _generate_node_name_to_qconfig, _is_qconfig_supported_by_dtype_configs, _maybe_adjust_qconfig_for_module_name_object_type_order, _update_qconfig_for_fusion private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D41015544](https://our.internmc.facebook.com/intern/diff/D41015544) cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel [ghstack-poisoned]

HDCharles · 2022-12-14T21:51:02Z

@pytorchmergebot merge

pytorchmergebot · 2022-12-14T21:52:34Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2022-12-14T22:27:51Z

Merge failed

Reason: The following mandatory check(s) failed (Rule superuser):

pull

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

HDCharles · 2022-12-14T23:43:51Z

@pytorchmergebot merge -f

pytorch-bot · 2022-12-14T23:43:53Z

❌ 🤖 pytorchbot command failed:

@pytorchbot merge: error: argument -f/--force: expected one argument

usage: @pytorchbot merge [-g | -f MESSAGE | -l] [-r [{viable/strict,master}]]

Try @pytorchbot --help for more info.

HDCharles · 2022-12-15T01:05:05Z

@pytorchmergebot merge -f the linux nvidia test is broken on master and this PR has no functional changes, just name changes

pytorch-bot · 2022-12-15T01:05:06Z

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: linux nvidia test is broken on master and this PR has no functional changes, just name changes

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci} ...

Try @pytorchbot --help for more info.

HDCharles · 2022-12-15T01:05:53Z

@pytorchmergebot merge -f "the linux nvidia test is broken on master and this PR has no functional changes, just name changes"

pytorchmergebot · 2022-12-15T01:07:27Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2022-12-15T01:07:31Z

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 6b8bc3f7e86bb4fa8fd7ce2e1c57e67a1bca9260 returned non-zero exit code 1

Auto-merging test/quantization/fx/test_quantize_fx.py
Auto-merging torch/ao/ns/_numeric_suite_fx.py
CONFLICT (content): Merge conflict in torch/ao/ns/_numeric_suite_fx.py
Auto-merging torch/ao/quantization/fx/convert.py
Auto-merging torch/ao/quantization/fx/prepare.py
error: could not apply 6b8bc3f7e8... [ao][fx] fixing public v private qconfig_mapping_utils.py
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Details for Dev Infra team

Raised by workflow job

Summary: made _check_is_valid_config_dict, _compare_prepare_convert_qconfig_mappings, _generate_node_name_to_qconfig, _is_qconfig_supported_by_dtype_configs, _maybe_adjust_qconfig_for_module_name_object_type_order, _update_qconfig_for_fusion private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D41015544](https://our.internmc.facebook.com/intern/diff/D41015544) cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel [ghstack-poisoned]

Pull Request resolved: #88399 made _check_is_valid_config_dict, _compare_prepare_convert_qconfig_mappings, _generate_node_name_to_qconfig, _is_qconfig_supported_by_dtype_configs, _maybe_adjust_qconfig_for_module_name_object_type_order, _update_qconfig_for_fusion private ghstack-source-id: 7036aff Differential Revision: [D41015544](https://our.internmc.facebook.com/intern/diff/D41015544/)

HDCharles · 2022-12-15T17:47:00Z

@pytorchmergebot merge -f "Broken on trunk/flaky tests, this PR doesn't have any functional changes, just name changes"

pytorchmergebot · 2022-12-15T17:48:30Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Summary: made _check_is_valid_config_dict, _compare_prepare_convert_qconfig_mappings, _generate_node_name_to_qconfig, _is_qconfig_supported_by_dtype_configs, _maybe_adjust_qconfig_for_module_name_object_type_order, _update_qconfig_for_fusion private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 8a0ec07 Pull Request resolved: pytorch/pytorch#88399

HDCharles requested review from jerryzh168 and z-a-f as code owners November 3, 2022 04:29

pytorch-bot bot added the release notes: quantization release notes category label Nov 3, 2022

github-actions bot added the oncall: quantization Quantization support in PyTorch label Nov 3, 2022

This was referenced Nov 3, 2022

[ao] removing private from allowlist #88404

Closed

[ao] fixing private in quantization-support.rst #88405

Closed

pytorchmergebot added the Merged label Dec 15, 2022

pytorchmergebot closed this in 173accd Dec 15, 2022

facebook-github-bot deleted the gh/HDCharles/140/head branch June 8, 2023 14:37

[ao][fx] fixing public v private qconfig_mapping_utils.py #88399

[ao][fx] fixing public v private qconfig_mapping_utils.py #88399

Uh oh!

Conversation

HDCharles commented Nov 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Nov 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88399

❌ 2 Failures

Uh oh!

HDCharles commented Nov 4, 2022

Uh oh!

HDCharles commented Nov 4, 2022

Uh oh!

HDCharles commented Dec 14, 2022

Uh oh!

pytorchmergebot commented Dec 14, 2022

Merge started

Uh oh!

pytorchmergebot commented Dec 14, 2022

Merge failed

Uh oh!

HDCharles commented Dec 14, 2022

Uh oh!

pytorchmergebot commented Dec 14, 2022

Merge started

Uh oh!

pytorchmergebot commented Dec 14, 2022

Merge failed

Uh oh!

HDCharles commented Dec 14, 2022

Uh oh!

pytorch-bot bot commented Dec 14, 2022

Uh oh!

HDCharles commented Dec 15, 2022

Uh oh!

pytorch-bot bot commented Dec 15, 2022

Uh oh!

HDCharles commented Dec 15, 2022

Uh oh!

pytorchmergebot commented Dec 15, 2022

Merge started

Uh oh!

pytorchmergebot commented Dec 15, 2022

Merge failed

Uh oh!

HDCharles commented Dec 15, 2022

Uh oh!

pytorchmergebot commented Dec 15, 2022

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

HDCharles commented Nov 3, 2022 •

edited

Loading

pytorch-bot bot commented Nov 3, 2022 •

edited

Loading