Skip to content

[ao][fx] fixing public v private prepare.py #88398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
HDCharles wants to merge 26 commits into from
Closed

[ao][fx] fixing public v private prepare.py #88398

HDCharles wants to merge 26 commits into from

Conversation

@HDCharles
Copy link
Contributor

@HDCharles HDCharles commented Nov 3, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

Summary: made _DO_NOT_OBS_DTYPE_LIST, _add_matched_node_name_to_set,
_get_arg_target_is_dynamic_as_input_to_node, _get_arg_target_is_dynamic_as_input_to_node,
_get_arg_target_dtype_as_input_to_node,
_get_arg_target_dtype_as_output,
_get_target_activation_dtype_for_node,
_get_standalone_module_configs,
_insert_observer,
_is_activation_post_process_node,
_is_input_arg_dtype_supported_by_backend,
_is_observer_in_same_graph,
_is_output_dtype_supported_by_backend,
_maybe_insert_input_equalization_observers_for_node,
_maybe_insert_input_observer_for_arg_or_kwarg,
_maybe_insert_input_observers_for_node,
_maybe_insert_observers_before_graph_output,
_maybe_insert_output_observer_for_node,
_maybe_make_input_output_share_observers,
_maybe_propagate_dtype_for_node,
_qat_swap_modules,
_remove_output_observer,
_run_prepare_fx_on_standalone_modules,
_save_state,
_swap_custom_module_to_observed private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D41015542

cc @jerryzh168 @jianyuh @raghuramank100 @jamesr66a @vkuzo @jgong5 @Xia-Weiwen @leslie-fang-intel

@HDCharles
[ao][fx] fixing public v private prepare.py
b7cc12c 
Summary: made _DO_NOT_OBS_DTYPE_LIST, _add_matched_node_name_to_set,
_get_arg_target_is_dynamic_as_input_to_node, _get_arg_target_is_dynamic_as_input_to_node,
_get_arg_target_dtype_as_input_to_node,
_get_arg_target_dtype_as_output,
_get_target_activation_dtype_for_node,
_get_standalone_module_configs,
_insert_observer,
_is_activation_post_process_node,
_is_input_arg_dtype_supported_by_backend,
_is_observer_in_same_graph,
_is_output_dtype_supported_by_backend,
_maybe_insert_input_equalization_observers_for_node,
_maybe_insert_input_observer_for_arg_or_kwarg,
_maybe_insert_input_observers_for_node,
_maybe_insert_observers_before_graph_output,
_maybe_insert_output_observer_for_node,
_maybe_make_input_output_share_observers,
_maybe_propagate_dtype_for_node,
_qat_swap_modules,
_remove_output_observer,
_run_prepare_fx_on_standalone_modules,
_save_state,
_swap_custom_module_to_observed private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 3, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88398

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 99e7371:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Nov 3, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@github-actions github-actions bot added the oncall: quantization Quantization support in PyTorch label Nov 3, 2022
This was referenced Nov 3, 2022
Closed
Closed
@HDCharles
Update on "[ao][fx] fixing public v private prepare.py"
e479639 
Summary: made _DO_NOT_OBS_DTYPE_LIST, _add_matched_node_name_to_set,
_get_arg_target_is_dynamic_as_input_to_node, _get_arg_target_is_dynamic_as_input_to_node,
_get_arg_target_dtype_as_input_to_node,
_get_arg_target_dtype_as_output,
_get_target_activation_dtype_for_node,
_get_standalone_module_configs,
_insert_observer,
_is_activation_post_process_node,
_is_input_arg_dtype_supported_by_backend,
_is_observer_in_same_graph,
_is_output_dtype_supported_by_backend,
_maybe_insert_input_equalization_observers_for_node,
_maybe_insert_input_observer_for_arg_or_kwarg,
_maybe_insert_input_observers_for_node,
_maybe_insert_observers_before_graph_output,
_maybe_insert_output_observer_for_node,
_maybe_make_input_output_share_observers,
_maybe_propagate_dtype_for_node,
_qat_swap_modules,
_remove_output_observer,
_run_prepare_fx_on_standalone_modules,
_save_state,
_swap_custom_module_to_observed private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen

[ghstack-poisoned]
@HDCharles
Copy link
Contributor Author

HDCharles commented Nov 4, 2022

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@HDCharles
Update on "[ao][fx] fixing public v private prepare.py"
f7f2265 
Summary: made _DO_NOT_OBS_DTYPE_LIST, _add_matched_node_name_to_set,
_get_arg_target_is_dynamic_as_input_to_node, _get_arg_target_is_dynamic_as_input_to_node,
_get_arg_target_dtype_as_input_to_node,
_get_arg_target_dtype_as_output,
_get_target_activation_dtype_for_node,
_get_standalone_module_configs,
_insert_observer,
_is_activation_post_process_node,
_is_input_arg_dtype_supported_by_backend,
_is_observer_in_same_graph,
_is_output_dtype_supported_by_backend,
_maybe_insert_input_equalization_observers_for_node,
_maybe_insert_input_observer_for_arg_or_kwarg,
_maybe_insert_input_observers_for_node,
_maybe_insert_observers_before_graph_output,
_maybe_insert_output_observer_for_node,
_maybe_make_input_output_share_observers,
_maybe_propagate_dtype_for_node,
_qat_swap_modules,
_remove_output_observer,
_run_prepare_fx_on_standalone_modules,
_save_state,
_swap_custom_module_to_observed private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen

Differential Revision: [D41015542](https://our.internmc.facebook.com/intern/diff/D41015542)

[ghstack-poisoned]
@HDCharles
Copy link
Contributor Author

HDCharles commented Nov 4, 2022

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@HDCharles
Update on "[ao][fx] fixing public v private prepare.py"
318f4f8 
Summary: made _DO_NOT_OBS_DTYPE_LIST, _add_matched_node_name_to_set,
_get_arg_target_is_dynamic_as_input_to_node, _get_arg_target_is_dynamic_as_input_to_node,
_get_arg_target_dtype_as_input_to_node,
_get_arg_target_dtype_as_output,
_get_target_activation_dtype_for_node,
_get_standalone_module_configs,
_insert_observer,
_is_activation_post_process_node,
_is_input_arg_dtype_supported_by_backend,
_is_observer_in_same_graph,
_is_output_dtype_supported_by_backend,
_maybe_insert_input_equalization_observers_for_node,
_maybe_insert_input_observer_for_arg_or_kwarg,
_maybe_insert_input_observers_for_node,
_maybe_insert_observers_before_graph_output,
_maybe_insert_output_observer_for_node,
_maybe_make_input_output_share_observers,
_maybe_propagate_dtype_for_node,
_qat_swap_modules,
_remove_output_observer,
_run_prepare_fx_on_standalone_modules,
_save_state,
_swap_custom_module_to_observed private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen

Differential Revision: [D41015542](https://our.internmc.facebook.com/intern/diff/D41015542)

[ghstack-poisoned]
@HDCharles
Update on "[ao][fx] fixing public v private prepare.py"
cf9d4b4 
Summary: made _DO_NOT_OBS_DTYPE_LIST, _add_matched_node_name_to_set,
_get_arg_target_is_dynamic_as_input_to_node, _get_arg_target_is_dynamic_as_input_to_node,
_get_arg_target_dtype_as_input_to_node,
_get_arg_target_dtype_as_output,
_get_target_activation_dtype_for_node,
_get_standalone_module_configs,
_insert_observer,
_is_activation_post_process_node,
_is_input_arg_dtype_supported_by_backend,
_is_observer_in_same_graph,
_is_output_dtype_supported_by_backend,
_maybe_insert_input_equalization_observers_for_node,
_maybe_insert_input_observer_for_arg_or_kwarg,
_maybe_insert_input_observers_for_node,
_maybe_insert_observers_before_graph_output,
_maybe_insert_output_observer_for_node,
_maybe_make_input_output_share_observers,
_maybe_propagate_dtype_for_node,
_qat_swap_modules,
_remove_output_observer,
_run_prepare_fx_on_standalone_modules,
_save_state,
_swap_custom_module_to_observed private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen

Differential Revision: [D41015542](https://our.internmc.facebook.com/intern/diff/D41015542)

[ghstack-poisoned]
@HDCharles
Update on "[ao][fx] fixing public v private prepare.py"
4b33f93 
Summary: made _DO_NOT_OBS_DTYPE_LIST, _add_matched_node_name_to_set,
_get_arg_target_is_dynamic_as_input_to_node, _get_arg_target_is_dynamic_as_input_to_node,
_get_arg_target_dtype_as_input_to_node,
_get_arg_target_dtype_as_output,
_get_target_activation_dtype_for_node,
_get_standalone_module_configs,
_insert_observer,
_is_activation_post_process_node,
_is_input_arg_dtype_supported_by_backend,
_is_observer_in_same_graph,
_is_output_dtype_supported_by_backend,
_maybe_insert_input_equalization_observers_for_node,
_maybe_insert_input_observer_for_arg_or_kwarg,
_maybe_insert_input_observers_for_node,
_maybe_insert_observers_before_graph_output,
_maybe_insert_output_observer_for_node,
_maybe_make_input_output_share_observers,
_maybe_propagate_dtype_for_node,
_qat_swap_modules,
_remove_output_observer,
_run_prepare_fx_on_standalone_modules,
_save_state,
_swap_custom_module_to_observed private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015542](https://our.internmc.facebook.com/intern/diff/D41015542)

[ghstack-poisoned]
@HDCharles HDCharles mentioned this pull request Dec 7, 2022
Closed
@github-actions github-actions bot added the release notes: quantization release notes category label Dec 7, 2022
@HDCharles
Update on "[ao][fx] fixing public v private prepare.py"
973075e 
Summary: made _DO_NOT_OBS_DTYPE_LIST, _add_matched_node_name_to_set,
_get_arg_target_is_dynamic_as_input_to_node, _get_arg_target_is_dynamic_as_input_to_node,
_get_arg_target_dtype_as_input_to_node,
_get_arg_target_dtype_as_output,
_get_target_activation_dtype_for_node,
_get_standalone_module_configs,
_insert_observer,
_is_activation_post_process_node,
_is_input_arg_dtype_supported_by_backend,
_is_observer_in_same_graph,
_is_output_dtype_supported_by_backend,
_maybe_insert_input_equalization_observers_for_node,
_maybe_insert_input_observer_for_arg_or_kwarg,
_maybe_insert_input_observers_for_node,
_maybe_insert_observers_before_graph_output,
_maybe_insert_output_observer_for_node,
_maybe_make_input_output_share_observers,
_maybe_propagate_dtype_for_node,
_qat_swap_modules,
_remove_output_observer,
_run_prepare_fx_on_standalone_modules,
_save_state,
_swap_custom_module_to_observed private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015542](https://our.internmc.facebook.com/intern/diff/D41015542)

cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel

[ghstack-poisoned]
@HDCharles
Update on "[ao][fx] fixing public v private prepare.py"
fd0372b 
Summary: made _DO_NOT_OBS_DTYPE_LIST, _add_matched_node_name_to_set,
_get_arg_target_is_dynamic_as_input_to_node, _get_arg_target_is_dynamic_as_input_to_node,
_get_arg_target_dtype_as_input_to_node,
_get_arg_target_dtype_as_output,
_get_target_activation_dtype_for_node,
_get_standalone_module_configs,
_insert_observer,
_is_activation_post_process_node,
_is_input_arg_dtype_supported_by_backend,
_is_observer_in_same_graph,
_is_output_dtype_supported_by_backend,
_maybe_insert_input_equalization_observers_for_node,
_maybe_insert_input_observer_for_arg_or_kwarg,
_maybe_insert_input_observers_for_node,
_maybe_insert_observers_before_graph_output,
_maybe_insert_output_observer_for_node,
_maybe_make_input_output_share_observers,
_maybe_propagate_dtype_for_node,
_qat_swap_modules,
_remove_output_observer,
_run_prepare_fx_on_standalone_modules,
_save_state,
_swap_custom_module_to_observed private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015542](https://our.internmc.facebook.com/intern/diff/D41015542)

cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel

[ghstack-poisoned]
@HDCharles
Update on "[ao][fx] fixing public v private prepare.py"
8f567a5 
Summary: made _DO_NOT_OBS_DTYPE_LIST, _add_matched_node_name_to_set,
_get_arg_target_is_dynamic_as_input_to_node, _get_arg_target_is_dynamic_as_input_to_node,
_get_arg_target_dtype_as_input_to_node,
_get_arg_target_dtype_as_output,
_get_target_activation_dtype_for_node,
_get_standalone_module_configs,
_insert_observer,
_is_activation_post_process_node,
_is_input_arg_dtype_supported_by_backend,
_is_observer_in_same_graph,
_is_output_dtype_supported_by_backend,
_maybe_insert_input_equalization_observers_for_node,
_maybe_insert_input_observer_for_arg_or_kwarg,
_maybe_insert_input_observers_for_node,
_maybe_insert_observers_before_graph_output,
_maybe_insert_output_observer_for_node,
_maybe_make_input_output_share_observers,
_maybe_propagate_dtype_for_node,
_qat_swap_modules,
_remove_output_observer,
_run_prepare_fx_on_standalone_modules,
_save_state,
_swap_custom_module_to_observed private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015542](https://our.internmc.facebook.com/intern/diff/D41015542)

cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel

[ghstack-poisoned]
@HDCharles
Update on "[ao][fx] fixing public v private prepare.py"
9443fe3 
Summary: made _DO_NOT_OBS_DTYPE_LIST, _add_matched_node_name_to_set,
_get_arg_target_is_dynamic_as_input_to_node, _get_arg_target_is_dynamic_as_input_to_node,
_get_arg_target_dtype_as_input_to_node,
_get_arg_target_dtype_as_output,
_get_target_activation_dtype_for_node,
_get_standalone_module_configs,
_insert_observer,
_is_activation_post_process_node,
_is_input_arg_dtype_supported_by_backend,
_is_observer_in_same_graph,
_is_output_dtype_supported_by_backend,
_maybe_insert_input_equalization_observers_for_node,
_maybe_insert_input_observer_for_arg_or_kwarg,
_maybe_insert_input_observers_for_node,
_maybe_insert_observers_before_graph_output,
_maybe_insert_output_observer_for_node,
_maybe_make_input_output_share_observers,
_maybe_propagate_dtype_for_node,
_qat_swap_modules,
_remove_output_observer,
_run_prepare_fx_on_standalone_modules,
_save_state,
_swap_custom_module_to_observed private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015542](https://our.internmc.facebook.com/intern/diff/D41015542)

cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel

[ghstack-poisoned]
@HDCharles
Update on "[ao][fx] fixing public v private prepare.py"
66bfc5b 
Summary: made _DO_NOT_OBS_DTYPE_LIST, _add_matched_node_name_to_set,
_get_arg_target_is_dynamic_as_input_to_node, _get_arg_target_is_dynamic_as_input_to_node,
_get_arg_target_dtype_as_input_to_node,
_get_arg_target_dtype_as_output,
_get_target_activation_dtype_for_node,
_get_standalone_module_configs,
_insert_observer,
_is_activation_post_process_node,
_is_input_arg_dtype_supported_by_backend,
_is_observer_in_same_graph,
_is_output_dtype_supported_by_backend,
_maybe_insert_input_equalization_observers_for_node,
_maybe_insert_input_observer_for_arg_or_kwarg,
_maybe_insert_input_observers_for_node,
_maybe_insert_observers_before_graph_output,
_maybe_insert_output_observer_for_node,
_maybe_make_input_output_share_observers,
_maybe_propagate_dtype_for_node,
_qat_swap_modules,
_remove_output_observer,
_run_prepare_fx_on_standalone_modules,
_save_state,
_swap_custom_module_to_observed private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015542](https://our.internmc.facebook.com/intern/diff/D41015542)

cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel

[ghstack-poisoned]
@HDCharles
Update on "[ao][fx] fixing public v private prepare.py"
5f07655 
Summary: made _DO_NOT_OBS_DTYPE_LIST, _add_matched_node_name_to_set,
_get_arg_target_is_dynamic_as_input_to_node, _get_arg_target_is_dynamic_as_input_to_node,
_get_arg_target_dtype_as_input_to_node,
_get_arg_target_dtype_as_output,
_get_target_activation_dtype_for_node,
_get_standalone_module_configs,
_insert_observer,
_is_activation_post_process_node,
_is_input_arg_dtype_supported_by_backend,
_is_observer_in_same_graph,
_is_output_dtype_supported_by_backend,
_maybe_insert_input_equalization_observers_for_node,
_maybe_insert_input_observer_for_arg_or_kwarg,
_maybe_insert_input_observers_for_node,
_maybe_insert_observers_before_graph_output,
_maybe_insert_output_observer_for_node,
_maybe_make_input_output_share_observers,
_maybe_propagate_dtype_for_node,
_qat_swap_modules,
_remove_output_observer,
_run_prepare_fx_on_standalone_modules,
_save_state,
_swap_custom_module_to_observed private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015542](https://our.internmc.facebook.com/intern/diff/D41015542)

cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel

[ghstack-poisoned]
HDCharles added a commit that referenced this pull request Dec 9, 2022
@HDCharles
[ao][fx] fixing public v private prepare.py
4115675 
Pull Request resolved: #88398


made _DO_NOT_OBS_DTYPE_LIST, _add_matched_node_name_to_set,
_get_arg_target_is_dynamic_as_input_to_node, _get_arg_target_is_dynamic_as_input_to_node,
_get_arg_target_dtype_as_input_to_node,
_get_arg_target_dtype_as_output,
_get_target_activation_dtype_for_node,
_get_standalone_module_configs,
_insert_observer,
_is_activation_post_process_node,
_is_input_arg_dtype_supported_by_backend,
_is_observer_in_same_graph,
_is_output_dtype_supported_by_backend,
_maybe_insert_input_equalization_observers_for_node,
_maybe_insert_input_observer_for_arg_or_kwarg,
_maybe_insert_input_observers_for_node,
_maybe_insert_observers_before_graph_output,
_maybe_insert_output_observer_for_node,
_maybe_make_input_output_share_observers,
_maybe_propagate_dtype_for_node,
_qat_swap_modules,
_remove_output_observer,
_run_prepare_fx_on_standalone_modules,
_save_state,
_swap_custom_module_to_observed private
ghstack-source-id: 175675033

Differential Revision: [D41015542](https://our.internmc.facebook.com/intern/diff/D41015542/)
@HDCharles
Update on "[ao][fx] fixing public v private prepare.py"
9d5e33b 
Summary: made _DO_NOT_OBS_DTYPE_LIST, _add_matched_node_name_to_set,
_get_arg_target_is_dynamic_as_input_to_node, _get_arg_target_is_dynamic_as_input_to_node,
_get_arg_target_dtype_as_input_to_node,
_get_arg_target_dtype_as_output,
_get_target_activation_dtype_for_node,
_get_standalone_module_configs,
_insert_observer,
_is_activation_post_process_node,
_is_input_arg_dtype_supported_by_backend,
_is_observer_in_same_graph,
_is_output_dtype_supported_by_backend,
_maybe_insert_input_equalization_observers_for_node,
_maybe_insert_input_observer_for_arg_or_kwarg,
_maybe_insert_input_observers_for_node,
_maybe_insert_observers_before_graph_output,
_maybe_insert_output_observer_for_node,
_maybe_make_input_output_share_observers,
_maybe_propagate_dtype_for_node,
_qat_swap_modules,
_remove_output_observer,
_run_prepare_fx_on_standalone_modules,
_save_state,
_swap_custom_module_to_observed private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015542](https://our.internmc.facebook.com/intern/diff/D41015542)

cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel

[ghstack-poisoned]
HDCharles added a commit that referenced this pull request Dec 9, 2022
@HDCharles
[ao][fx] fixing public v private prepare.py
b09e586 
Pull Request resolved: #88398


made _DO_NOT_OBS_DTYPE_LIST, _add_matched_node_name_to_set,
_get_arg_target_is_dynamic_as_input_to_node, _get_arg_target_is_dynamic_as_input_to_node,
_get_arg_target_dtype_as_input_to_node,
_get_arg_target_dtype_as_output,
_get_target_activation_dtype_for_node,
_get_standalone_module_configs,
_insert_observer,
_is_activation_post_process_node,
_is_input_arg_dtype_supported_by_backend,
_is_observer_in_same_graph,
_is_output_dtype_supported_by_backend,
_maybe_insert_input_equalization_observers_for_node,
_maybe_insert_input_observer_for_arg_or_kwarg,
_maybe_insert_input_observers_for_node,
_maybe_insert_observers_before_graph_output,
_maybe_insert_output_observer_for_node,
_maybe_make_input_output_share_observers,
_maybe_propagate_dtype_for_node,
_qat_swap_modules,
_remove_output_observer,
_run_prepare_fx_on_standalone_modules,
_save_state,
_swap_custom_module_to_observed private
ghstack-source-id: 175697137

Differential Revision: [D41015542](https://our.internmc.facebook.com/intern/diff/D41015542/)
@HDCharles
Update on "[ao][fx] fixing public v private prepare.py"
3f85929 
Summary: made _DO_NOT_OBS_DTYPE_LIST, _add_matched_node_name_to_set,
_get_arg_target_is_dynamic_as_input_to_node, _get_arg_target_is_dynamic_as_input_to_node,
_get_arg_target_dtype_as_input_to_node,
_get_arg_target_dtype_as_output,
_get_target_activation_dtype_for_node,
_get_standalone_module_configs,
_insert_observer,
_is_activation_post_process_node,
_is_input_arg_dtype_supported_by_backend,
_is_observer_in_same_graph,
_is_output_dtype_supported_by_backend,
_maybe_insert_input_equalization_observers_for_node,
_maybe_insert_input_observer_for_arg_or_kwarg,
_maybe_insert_input_observers_for_node,
_maybe_insert_observers_before_graph_output,
_maybe_insert_output_observer_for_node,
_maybe_make_input_output_share_observers,
_maybe_propagate_dtype_for_node,
_qat_swap_modules,
_remove_output_observer,
_run_prepare_fx_on_standalone_modules,
_save_state,
_swap_custom_module_to_observed private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015542](https://our.internmc.facebook.com/intern/diff/D41015542)

cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel

[ghstack-poisoned]
@HDCharles
Update on "[ao][fx] fixing public v private prepare.py"
318d554 
Summary: made _DO_NOT_OBS_DTYPE_LIST, _add_matched_node_name_to_set,
_get_arg_target_is_dynamic_as_input_to_node, _get_arg_target_is_dynamic_as_input_to_node,
_get_arg_target_dtype_as_input_to_node,
_get_arg_target_dtype_as_output,
_get_target_activation_dtype_for_node,
_get_standalone_module_configs,
_insert_observer,
_is_activation_post_process_node,
_is_input_arg_dtype_supported_by_backend,
_is_observer_in_same_graph,
_is_output_dtype_supported_by_backend,
_maybe_insert_input_equalization_observers_for_node,
_maybe_insert_input_observer_for_arg_or_kwarg,
_maybe_insert_input_observers_for_node,
_maybe_insert_observers_before_graph_output,
_maybe_insert_output_observer_for_node,
_maybe_make_input_output_share_observers,
_maybe_propagate_dtype_for_node,
_qat_swap_modules,
_remove_output_observer,
_run_prepare_fx_on_standalone_modules,
_save_state,
_swap_custom_module_to_observed private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015542](https://our.internmc.facebook.com/intern/diff/D41015542)

cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel

[ghstack-poisoned]
HDCharles added a commit that referenced this pull request Dec 13, 2022
@HDCharles
[ao][fx] fixing public v private prepare.py
28a2e48 
Pull Request resolved: #88398


made _DO_NOT_OBS_DTYPE_LIST, _add_matched_node_name_to_set,
_get_arg_target_is_dynamic_as_input_to_node, _get_arg_target_is_dynamic_as_input_to_node,
_get_arg_target_dtype_as_input_to_node,
_get_arg_target_dtype_as_output,
_get_target_activation_dtype_for_node,
_get_standalone_module_configs,
_insert_observer,
_is_activation_post_process_node,
_is_input_arg_dtype_supported_by_backend,
_is_observer_in_same_graph,
_is_output_dtype_supported_by_backend,
_maybe_insert_input_equalization_observers_for_node,
_maybe_insert_input_observer_for_arg_or_kwarg,
_maybe_insert_input_observers_for_node,
_maybe_insert_observers_before_graph_output,
_maybe_insert_output_observer_for_node,
_maybe_make_input_output_share_observers,
_maybe_propagate_dtype_for_node,
_qat_swap_modules,
_remove_output_observer,
_run_prepare_fx_on_standalone_modules,
_save_state,
_swap_custom_module_to_observed private
ghstack-source-id: 175958925

Differential Revision: [D41015542](https://our.internmc.facebook.com/intern/diff/D41015542/)
@HDCharles
Copy link
Contributor Author

HDCharles commented Dec 14, 2022

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 14, 2022
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 14, 2022

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 15, 2022

Merge failed

Reason: 2 additional jobs have failed, first few of them are: trunk ,trunk / linux-focal-rocm5.2-py3.8 / test (default, 1, 2, linux.rocm.gpu)

Details for Dev Infra team Raised by workflow job

@HDCharles
Update on "[ao][fx] fixing public v private prepare.py"
99e7371 
Summary: made _DO_NOT_OBS_DTYPE_LIST, _add_matched_node_name_to_set,
_get_arg_target_is_dynamic_as_input_to_node, _get_arg_target_is_dynamic_as_input_to_node,
_get_arg_target_dtype_as_input_to_node,
_get_arg_target_dtype_as_output,
_get_target_activation_dtype_for_node,
_get_standalone_module_configs,
_insert_observer,
_is_activation_post_process_node,
_is_input_arg_dtype_supported_by_backend,
_is_observer_in_same_graph,
_is_output_dtype_supported_by_backend,
_maybe_insert_input_equalization_observers_for_node,
_maybe_insert_input_observer_for_arg_or_kwarg,
_maybe_insert_input_observers_for_node,
_maybe_insert_observers_before_graph_output,
_maybe_insert_output_observer_for_node,
_maybe_make_input_output_share_observers,
_maybe_propagate_dtype_for_node,
_qat_swap_modules,
_remove_output_observer,
_run_prepare_fx_on_standalone_modules,
_save_state,
_swap_custom_module_to_observed private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015542](https://our.internmc.facebook.com/intern/diff/D41015542)

cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel

[ghstack-poisoned]
HDCharles added a commit that referenced this pull request Dec 15, 2022
@HDCharles
[ao][fx] fixing public v private prepare.py
d836311 
Pull Request resolved: #88398


made _DO_NOT_OBS_DTYPE_LIST, _add_matched_node_name_to_set,
_get_arg_target_is_dynamic_as_input_to_node, _get_arg_target_is_dynamic_as_input_to_node,
_get_arg_target_dtype_as_input_to_node,
_get_arg_target_dtype_as_output,
_get_target_activation_dtype_for_node,
_get_standalone_module_configs,
_insert_observer,
_is_activation_post_process_node,
_is_input_arg_dtype_supported_by_backend,
_is_observer_in_same_graph,
_is_output_dtype_supported_by_backend,
_maybe_insert_input_equalization_observers_for_node,
_maybe_insert_input_observer_for_arg_or_kwarg,
_maybe_insert_input_observers_for_node,
_maybe_insert_observers_before_graph_output,
_maybe_insert_output_observer_for_node,
_maybe_make_input_output_share_observers,
_maybe_propagate_dtype_for_node,
_qat_swap_modules,
_remove_output_observer,
_run_prepare_fx_on_standalone_modules,
_save_state,
_swap_custom_module_to_observed private
ghstack-source-id: 176258893

Differential Revision: [D41015542](https://our.internmc.facebook.com/intern/diff/D41015542/)
@HDCharles
Copy link
Contributor Author

HDCharles commented Dec 16, 2022

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 16, 2022

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

hasanyeganeh pushed a commit to hasanyeganeh/pytorch-pytorch that referenced this pull request Dec 21, 2022
@HDCharles
[ao][fx] fixing public v private prepare.py
b7700b0 
Summary: made _DO_NOT_OBS_DTYPE_LIST, _add_matched_node_name_to_set,
_get_arg_target_is_dynamic_as_input_to_node, _get_arg_target_is_dynamic_as_input_to_node,
_get_arg_target_dtype_as_input_to_node,
_get_arg_target_dtype_as_output,
_get_target_activation_dtype_for_node,
_get_standalone_module_configs,
_insert_observer,
_is_activation_post_process_node,
_is_input_arg_dtype_supported_by_backend,
_is_observer_in_same_graph,
_is_output_dtype_supported_by_backend,
_maybe_insert_input_equalization_observers_for_node,
_maybe_insert_input_observer_for_arg_or_kwarg,
_maybe_insert_input_observers_for_node,
_maybe_insert_observers_before_graph_output,
_maybe_insert_output_observer_for_node,
_maybe_make_input_output_share_observers,
_maybe_propagate_dtype_for_node,
_qat_swap_modules,
_remove_output_observer,
_run_prepare_fx_on_standalone_modules,
_save_state,
_swap_custom_module_to_observed private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: b7b802f
Pull Request resolved: pytorch/pytorch#88398
@facebook-github-bot facebook-github-bot deleted the gh/HDCharles/139/head branch June 8, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcaip jcaip jcaip approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: quantization Quantization support in PyTorch release notes: AO frontend release notes: quantization release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HDCharles @pytorchmergebot @jcaip