Skip to content

[ao][fx] fixing public v private graph_module.py #88395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
HDCharles wants to merge 25 commits into from
Closed

[ao][fx] fixing public v private graph_module.py #88395

HDCharles wants to merge 25 commits into from

Conversation

@HDCharles
Copy link
Contributor

@HDCharles HDCharles commented Nov 3, 2022 •
edited by pytorch-bot bot
Loading

Stack from ghstack (oldest at bottom):

Summary: made _is_observed_module, _is_observed_standalone_module
private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D41015545

cc @jerryzh168 @jianyuh @raghuramank100 @jamesr66a @vkuzo @jgong5 @Xia-Weiwen @leslie-fang-intel

@HDCharles
[ao][fx] fixing public v private graph_module.py
d724701 
Summary: made _is_observed_module, _is_observed_standalone_module
private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 3, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88395

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b0ad11a:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: quantization release notes category label Nov 3, 2022
@github-actions github-actions bot added the oncall: quantization Quantization support in PyTorch label Nov 3, 2022
This was referenced Nov 3, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@HDCharles
Update on "[ao][fx] fixing public v private graph_module.py"
a4f60f9 
Summary: made _is_observed_module, _is_observed_standalone_module
private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@HDCharles
Copy link
Contributor Author

HDCharles commented Nov 4, 2022

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@HDCharles
Update on "[ao][fx] fixing public v private graph_module.py"
bca13e7 
Summary: made _is_observed_module, _is_observed_standalone_module
private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015545](https://our.internmc.facebook.com/intern/diff/D41015545)

[ghstack-poisoned]
@HDCharles
Copy link
Contributor Author

HDCharles commented Nov 4, 2022

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@HDCharles
Update on "[ao][fx] fixing public v private graph_module.py"
f531d1b 
Summary: made _is_observed_module, _is_observed_standalone_module
private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015545](https://our.internmc.facebook.com/intern/diff/D41015545)

[ghstack-poisoned]
@HDCharles
Update on "[ao][fx] fixing public v private graph_module.py"
e501835 
Summary: made _is_observed_module, _is_observed_standalone_module
private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015545](https://our.internmc.facebook.com/intern/diff/D41015545)

[ghstack-poisoned]
@HDCharles
Update on "[ao][fx] fixing public v private graph_module.py"
0d717d6 
Summary: made _is_observed_module, _is_observed_standalone_module
private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015545](https://our.internmc.facebook.com/intern/diff/D41015545)

[ghstack-poisoned]
@HDCharles
Update on "[ao][fx] fixing public v private graph_module.py"
7665a3f 
Summary: made _is_observed_module, _is_observed_standalone_module
private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015545](https://our.internmc.facebook.com/intern/diff/D41015545)

[ghstack-poisoned]
@HDCharles
Update on "[ao][fx] fixing public v private graph_module.py"
8fcdb54 
Summary: made _is_observed_module, _is_observed_standalone_module
private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015545](https://our.internmc.facebook.com/intern/diff/D41015545)

[ghstack-poisoned]
@HDCharles HDCharles mentioned this pull request Dec 7, 2022
Closed
@HDCharles
Update on "[ao][fx] fixing public v private graph_module.py"
18b8708 
Summary: made _is_observed_module, _is_observed_standalone_module
private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015545](https://our.internmc.facebook.com/intern/diff/D41015545)

[ghstack-poisoned]
@HDCharles
Update on "[ao][fx] fixing public v private graph_module.py"
fa74b0f 
Summary: made _is_observed_module, _is_observed_standalone_module
private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015545](https://our.internmc.facebook.com/intern/diff/D41015545)

[ghstack-poisoned]
@HDCharles
Update on "[ao][fx] fixing public v private graph_module.py"
e7c8954 
Summary: made _is_observed_module, _is_observed_standalone_module
private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015545](https://our.internmc.facebook.com/intern/diff/D41015545)

[ghstack-poisoned]
@HDCharles
Update on "[ao][fx] fixing public v private graph_module.py"
148f7fb 
Summary: made _is_observed_module, _is_observed_standalone_module
private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015545](https://our.internmc.facebook.com/intern/diff/D41015545)

[ghstack-poisoned]
@HDCharles
Update on "[ao][fx] fixing public v private graph_module.py"
ce41f89 
Summary: made _is_observed_module, _is_observed_standalone_module
private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015545](https://our.internmc.facebook.com/intern/diff/D41015545)

[ghstack-poisoned]
HDCharles added a commit that referenced this pull request Dec 9, 2022
@HDCharles
[ao][fx] fixing public v private graph_module.py
8ccff2e 
Pull Request resolved: #88395


made _is_observed_module, _is_observed_standalone_module
private
ghstack-source-id: 175622130

Differential Revision: [D41015545](https://our.internmc.facebook.com/intern/diff/D41015545/)
@HDCharles
Update on "[ao][fx] fixing public v private graph_module.py"
1551474 
Summary: made _is_observed_module, _is_observed_standalone_module
private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015545](https://our.internmc.facebook.com/intern/diff/D41015545)

[ghstack-poisoned]
HDCharles added a commit that referenced this pull request Dec 9, 2022
@HDCharles
[ao][fx] fixing public v private graph_module.py
f435916 
Pull Request resolved: #88395


made _is_observed_module, _is_observed_standalone_module
private
ghstack-source-id: 175660905

Differential Revision: [D41015545](https://our.internmc.facebook.com/intern/diff/D41015545/)
@HDCharles
Update on "[ao][fx] fixing public v private graph_module.py"
452c561 
Summary: made _is_observed_module, _is_observed_standalone_module
private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015545](https://our.internmc.facebook.com/intern/diff/D41015545)

[ghstack-poisoned]
@HDCharles
Update on "[ao][fx] fixing public v private graph_module.py"
cd3bd5d 
Summary: made _is_observed_module, _is_observed_standalone_module
private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015545](https://our.internmc.facebook.com/intern/diff/D41015545)

[ghstack-poisoned]
@HDCharles
Copy link
Contributor Author

HDCharles commented Dec 14, 2022

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 14, 2022
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 14, 2022

Merge failed

Reason: This PR has internal changes and must be landed via Phabricator

Details for Dev Infra team Raised by workflow job

@HDCharles
Update on "[ao][fx] fixing public v private graph_module.py"
b0ad11a 
Summary: made _is_observed_module, _is_observed_standalone_module
private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015545](https://our.internmc.facebook.com/intern/diff/D41015545)

cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel

[ghstack-poisoned]
HDCharles added a commit that referenced this pull request Dec 14, 2022
@HDCharles
[ao][fx] fixing public v private graph_module.py
e1fa520 
Pull Request resolved: #88395


made _is_observed_module, _is_observed_standalone_module
private
ghstack-source-id: 176082100

Differential Revision: [D41015545](https://our.internmc.facebook.com/intern/diff/D41015545/)
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Dec 15, 2022

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 15, 2022

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

hasanyeganeh pushed a commit to hasanyeganeh/pytorch-pytorch that referenced this pull request Dec 21, 2022
@HDCharles
[ao][fx] fixing public v private graph_module.py
69e37cc 
Summary: made _is_observed_module, _is_observed_standalone_module
private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 2fe28f1
Pull Request resolved: pytorch/pytorch#88395
@facebook-github-bot facebook-github-bot deleted the gh/HDCharles/136/head branch June 8, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcaip jcaip jcaip approved these changes

@jerryzh168 jerryzh168 Awaiting requested review from jerryzh168

@z-a-f z-a-f Awaiting requested review from z-a-f

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: quantization Quantization support in PyTorch release notes: quantization release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@HDCharles @pytorchmergebot @facebook-github-bot @jcaip