Skip to content

[ao][fx] public v private convert.py #88394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
HDCharles wants to merge 24 commits into from
Closed

[ao][fx] public v private convert.py #88394

HDCharles wants to merge 24 commits into from

Conversation

@HDCharles
Copy link
Contributor

@HDCharles HDCharles commented Nov 3, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

Summary: made _restore_state,
_has_none_qconfig,
_run_weight_observers,
_maybe_recursive_remove_dequantize,
_get_module_path_and_prefix,
_insert_dequantize_node,
_maybe_get_observer_for_node,
_remove_previous_dequantize_in_custom_module private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D41015547

cc @jerryzh168 @jianyuh @raghuramank100 @jamesr66a @vkuzo @jgong5 @Xia-Weiwen @leslie-fang-intel

@HDCharles
[ao][fx] public v private convert.py
4a42770 
Summary: made _restore_state,
_has_none_qconfig,
_restore_st_run_weight_observers,
_maybe_recursive_remove_dequantize,
_get_module_path_and_prefix,
_insert_dequantize_node,
_maybe_get_observer_for_node,
_remove_previous_dequantize_in_custom_module private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 3, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88394

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit af03c52:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions github-actions bot added the oncall: quantization Quantization support in PyTorch label Nov 3, 2022
This was referenced Nov 3, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@HDCharles
Update on "[ao][fx] public v private convert.py"
1d1045f 
Summary: made _restore_state,
_has_none_qconfig,
_restore_st_run_weight_observers,
_maybe_recursive_remove_dequantize,
_get_module_path_and_prefix,
_insert_dequantize_node,
_maybe_get_observer_for_node,
_remove_previous_dequantize_in_custom_module private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@HDCharles
Copy link
Contributor Author

HDCharles commented Nov 4, 2022

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@HDCharles
Update on "[ao][fx] public v private convert.py"
7013f6f 
Summary: made _restore_state,
_has_none_qconfig,
_restore_st_run_weight_observers,
_maybe_recursive_remove_dequantize,
_get_module_path_and_prefix,
_insert_dequantize_node,
_maybe_get_observer_for_node,
_remove_previous_dequantize_in_custom_module private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015547](https://our.internmc.facebook.com/intern/diff/D41015547)

[ghstack-poisoned]
@HDCharles
Copy link
Contributor Author

HDCharles commented Nov 4, 2022

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@HDCharles
Update on "[ao][fx] public v private convert.py"
9199e65 
Summary: made _restore_state,
_has_none_qconfig,
_restore_st_run_weight_observers,
_maybe_recursive_remove_dequantize,
_get_module_path_and_prefix,
_insert_dequantize_node,
_maybe_get_observer_for_node,
_remove_previous_dequantize_in_custom_module private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015547](https://our.internmc.facebook.com/intern/diff/D41015547)

[ghstack-poisoned]
@HDCharles
Update on "[ao][fx] public v private convert.py"
21198ed 
Summary: made _restore_state,
_has_none_qconfig,
_restore_st_run_weight_observers,
_maybe_recursive_remove_dequantize,
_get_module_path_and_prefix,
_insert_dequantize_node,
_maybe_get_observer_for_node,
_remove_previous_dequantize_in_custom_module private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015547](https://our.internmc.facebook.com/intern/diff/D41015547)

[ghstack-poisoned]
@HDCharles
Update on "[ao][fx] public v private convert.py"
8b40205 
Summary: made _restore_state,
_has_none_qconfig,
_run_weight_observers,
_maybe_recursive_remove_dequantize,
_get_module_path_and_prefix,
_insert_dequantize_node,
_maybe_get_observer_for_node,
_remove_previous_dequantize_in_custom_module private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015547](https://our.internmc.facebook.com/intern/diff/D41015547)

[ghstack-poisoned]
@HDCharles
Copy link
Contributor Author

HDCharles commented Nov 11, 2022

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@HDCharles
Update on "[ao][fx] public v private convert.py"
56b70a3 
Summary: made _restore_state,
_has_none_qconfig,
_run_weight_observers,
_maybe_recursive_remove_dequantize,
_get_module_path_and_prefix,
_insert_dequantize_node,
_maybe_get_observer_for_node,
_remove_previous_dequantize_in_custom_module private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015547](https://our.internmc.facebook.com/intern/diff/D41015547)

[ghstack-poisoned]
@HDCharles
Update on "[ao][fx] public v private convert.py"
62444b1 
Summary: made _restore_state,
_has_none_qconfig,
_run_weight_observers,
_maybe_recursive_remove_dequantize,
_get_module_path_and_prefix,
_insert_dequantize_node,
_maybe_get_observer_for_node,
_remove_previous_dequantize_in_custom_module private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015547](https://our.internmc.facebook.com/intern/diff/D41015547)

[ghstack-poisoned]
@HDCharles
Update on "[ao][fx] public v private convert.py"
db5004f 
Summary: made _restore_state,
_has_none_qconfig,
_run_weight_observers,
_maybe_recursive_remove_dequantize,
_get_module_path_and_prefix,
_insert_dequantize_node,
_maybe_get_observer_for_node,
_remove_previous_dequantize_in_custom_module private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015547](https://our.internmc.facebook.com/intern/diff/D41015547)

[ghstack-poisoned]
@HDCharles
Update on "[ao][fx] public v private convert.py"
541359b 
Summary: made _restore_state,
_has_none_qconfig,
_run_weight_observers,
_maybe_recursive_remove_dequantize,
_get_module_path_and_prefix,
_insert_dequantize_node,
_maybe_get_observer_for_node,
_remove_previous_dequantize_in_custom_module private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015547](https://our.internmc.facebook.com/intern/diff/D41015547)

[ghstack-poisoned]
@HDCharles
Update on "[ao][fx] public v private convert.py"
a0533fc 
Summary: made _restore_state,
_has_none_qconfig,
_run_weight_observers,
_maybe_recursive_remove_dequantize,
_get_module_path_and_prefix,
_insert_dequantize_node,
_maybe_get_observer_for_node,
_remove_previous_dequantize_in_custom_module private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015547](https://our.internmc.facebook.com/intern/diff/D41015547)

[ghstack-poisoned]
@HDCharles
Update on "[ao][fx] public v private convert.py"
cf4be8e 
Summary: made _restore_state,
_has_none_qconfig,
_run_weight_observers,
_maybe_recursive_remove_dequantize,
_get_module_path_and_prefix,
_insert_dequantize_node,
_maybe_get_observer_for_node,
_remove_previous_dequantize_in_custom_module private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015547](https://our.internmc.facebook.com/intern/diff/D41015547)

[ghstack-poisoned]
@HDCharles HDCharles mentioned this pull request Dec 7, 2022
Closed
@github-actions github-actions bot added the release notes: quantization release notes category label Dec 7, 2022
@HDCharles
Update on "[ao][fx] public v private convert.py"
adaf7f6 
Summary: made _restore_state,
_has_none_qconfig,
_run_weight_observers,
_maybe_recursive_remove_dequantize,
_get_module_path_and_prefix,
_insert_dequantize_node,
_maybe_get_observer_for_node,
_remove_previous_dequantize_in_custom_module private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015547](https://our.internmc.facebook.com/intern/diff/D41015547)

cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel

[ghstack-poisoned]
@HDCharles
Update on "[ao][fx] public v private convert.py"
b0b68fb 
Summary: made _restore_state,
_has_none_qconfig,
_run_weight_observers,
_maybe_recursive_remove_dequantize,
_get_module_path_and_prefix,
_insert_dequantize_node,
_maybe_get_observer_for_node,
_remove_previous_dequantize_in_custom_module private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015547](https://our.internmc.facebook.com/intern/diff/D41015547)

cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel

[ghstack-poisoned]
@HDCharles
Update on "[ao][fx] public v private convert.py"
a054190 
Summary: made _restore_state,
_has_none_qconfig,
_run_weight_observers,
_maybe_recursive_remove_dequantize,
_get_module_path_and_prefix,
_insert_dequantize_node,
_maybe_get_observer_for_node,
_remove_previous_dequantize_in_custom_module private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015547](https://our.internmc.facebook.com/intern/diff/D41015547)

cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel

[ghstack-poisoned]
@HDCharles
Update on "[ao][fx] public v private convert.py"
431ab7c 
Summary: made _restore_state,
_has_none_qconfig,
_run_weight_observers,
_maybe_recursive_remove_dequantize,
_get_module_path_and_prefix,
_insert_dequantize_node,
_maybe_get_observer_for_node,
_remove_previous_dequantize_in_custom_module private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015547](https://our.internmc.facebook.com/intern/diff/D41015547)

cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel

[ghstack-poisoned]
@HDCharles
Update on "[ao][fx] public v private convert.py"
c1615ca 
Summary: made _restore_state,
_has_none_qconfig,
_run_weight_observers,
_maybe_recursive_remove_dequantize,
_get_module_path_and_prefix,
_insert_dequantize_node,
_maybe_get_observer_for_node,
_remove_previous_dequantize_in_custom_module private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015547](https://our.internmc.facebook.com/intern/diff/D41015547)

cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel

[ghstack-poisoned]
HDCharles added a commit that referenced this pull request Dec 9, 2022
@HDCharles
[ao][fx] public v private convert.py
9efc9c6 
Pull Request resolved: #88394


made _restore_state,
_has_none_qconfig,
_restore_st_run_weight_observers,
_maybe_recursive_remove_dequantize,
_get_module_path_and_prefix,
_insert_dequantize_node,
_maybe_get_observer_for_node,
_remove_previous_dequantize_in_custom_module private
ghstack-source-id: 175621748

Differential Revision: [D41015547](https://our.internmc.facebook.com/intern/diff/D41015547/)
@HDCharles
Update on "[ao][fx] public v private convert.py"
4f8bf25 
Summary: made _restore_state,
_has_none_qconfig,
_run_weight_observers,
_maybe_recursive_remove_dequantize,
_get_module_path_and_prefix,
_insert_dequantize_node,
_maybe_get_observer_for_node,
_remove_previous_dequantize_in_custom_module private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015547](https://our.internmc.facebook.com/intern/diff/D41015547)

cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel

[ghstack-poisoned]
HDCharles added a commit that referenced this pull request Dec 9, 2022
@HDCharles
[ao][fx] public v private convert.py
9af0626 
Pull Request resolved: #88394


made _restore_state,
_has_none_qconfig,
_restore_st_run_weight_observers,
_maybe_recursive_remove_dequantize,
_get_module_path_and_prefix,
_insert_dequantize_node,
_maybe_get_observer_for_node,
_remove_previous_dequantize_in_custom_module private
ghstack-source-id: 175660904

Differential Revision: [D41015547](https://our.internmc.facebook.com/intern/diff/D41015547/)
@HDCharles
Update on "[ao][fx] public v private convert.py"
6a2fbf7 
Summary: made _restore_state,
_has_none_qconfig,
_run_weight_observers,
_maybe_recursive_remove_dequantize,
_get_module_path_and_prefix,
_insert_dequantize_node,
_maybe_get_observer_for_node,
_remove_previous_dequantize_in_custom_module private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015547](https://our.internmc.facebook.com/intern/diff/D41015547)

cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel

[ghstack-poisoned]
@HDCharles
Copy link
Contributor Author

HDCharles commented Dec 12, 2022

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 12, 2022
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 12, 2022

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 12, 2022

Merge failed

Reason: 2 additional jobs have failed, first few of them are: trunk ,trunk / linux-bionic-cuda11.7-py3.10-gcc7 / test (distributed, 1, 3, linux.8xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@HDCharles
Update on "[ao][fx] public v private convert.py"
af03c52 
Summary: made _restore_state,
_has_none_qconfig,
_run_weight_observers,
_maybe_recursive_remove_dequantize,
_get_module_path_and_prefix,
_insert_dequantize_node,
_maybe_get_observer_for_node,
_remove_previous_dequantize_in_custom_module private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015547](https://our.internmc.facebook.com/intern/diff/D41015547)

cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel

[ghstack-poisoned]
@HDCharles
Copy link
Contributor Author

HDCharles commented Dec 13, 2022

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 13, 2022

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

hasanyeganeh pushed a commit to hasanyeganeh/pytorch-pytorch that referenced this pull request Dec 21, 2022
@HDCharles
[ao][fx] public v private convert.py
3c52f6b 
Summary: made _restore_state,
_has_none_qconfig,
_run_weight_observers,
_maybe_recursive_remove_dequantize,
_get_module_path_and_prefix,
_insert_dequantize_node,
_maybe_get_observer_for_node,
_remove_previous_dequantize_in_custom_module private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 49829c5
Pull Request resolved: pytorch/pytorch#88394
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcaip jcaip jcaip approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: quantization Quantization support in PyTorch release notes: AO frontend release notes: quantization release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HDCharles @pytorchmergebot @jcaip