[nn] add remove_duplicate flag to named_parameters (#759) #88090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samdow
requested review from
H-Huang,
albanD,
awgu,
jbschlosser,
kwen2501,
mrshenli,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88090
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 259e061: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D40801899 |
albanD
approved these changes
Oct 31, 2022
Collaborator
albanD
left a comment
albanD
left a comment
There was a problem hiding this comment.
Sounds good. Just an extra test.
| self, | ||
| prefix: str = '', | ||
| recurse: bool = True, | ||
| remove_duplicate: bool = True |
Collaborator
There was a problem hiding this comment.
I guess we can't make these kwarg only? :(
samdow
added a commit
to samdow/torchrec
that referenced
this pull request
Nov 1, 2022
Summary: X-link: pytorch/pytorch#88090 Pull Request resolved: meta-pytorch#759 Since the remove_duplicate flag was added to named_buffers in D39493161 (meta-pytorch@672d105), this adds the same flag to named_parameters Differential Revision: D40801899 fbshipit-source-id: 083fc56e1b8064faf59e2ce4695741dfc150a5d5
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D40801899 |
samdow
force-pushed
the
export-D40801899
branch
from
1b49427 to
07c6333
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D40801899 |
samdow
added a commit
to samdow/pytorch
that referenced
this pull request
Nov 1, 2022
Summary: Pull Request resolved: pytorch#88090 X-link: meta-pytorch/torchrec#759 Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@c12f829), this adds the same flag to named_parameters Test Plan: python test/test_nn.py -k test_buffers_and_named_buffers OSS Tests Differential Revision: D40801899 fbshipit-source-id: ece48c40c17de93b5e0654ede4574870927fc2f1
samdow
force-pushed
the
export-D40801899
branch
from
07c6333 to
58df794
Compare
samdow
added a commit
to samdow/torchrec
that referenced
this pull request
Nov 1, 2022
Summary: X-link: pytorch/pytorch#88090 Pull Request resolved: meta-pytorch#759 Since the remove_duplicate flag was added to named_buffers in D39493161 (meta-pytorch@672d105), this adds the same flag to named_parameters Differential Revision: D40801899 fbshipit-source-id: 8676b5e5074924708f85d153cff7d20096a8c7a2
samdow
added a commit
to samdow/pytorch
that referenced
this pull request
Nov 1, 2022
Summary: Pull Request resolved: pytorch#88090 X-link: meta-pytorch/torchrec#759 Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@c12f829), this adds the same flag to named_parameters Test Plan: python test/test_nn.py -k test_buffers_and_named_buffers OSS Tests Differential Revision: D40801899 fbshipit-source-id: 51e8e0b00f8e6ca52f08d0752ab5b5838b74cd50
samdow
force-pushed
the
export-D40801899
branch
from
58df794 to
c00cab8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D40801899 |
samdow
added a commit
to samdow/torchrec
that referenced
this pull request
Nov 7, 2022
Summary: X-link: pytorch/pytorch#88090 Pull Request resolved: meta-pytorch#759 Since the remove_duplicate flag was added to named_buffers in D39493161 (meta-pytorch@672d105), this adds the same flag to named_parameters Reviewed By: albanD Differential Revision: D40801899 fbshipit-source-id: 4b537c942650cbcbdfac57ba54040bbd2c0e29f7
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D40801899 |
samdow
force-pushed
the
export-D40801899
branch
from
c00cab8 to
38e0475
Compare
samdow
added a commit
to samdow/pytorch
that referenced
this pull request
Nov 7, 2022
Summary: Pull Request resolved: pytorch#88090 X-link: meta-pytorch/torchrec#759 Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@c12f829), this adds the same flag to named_parameters Test Plan: python test/test_nn.py -k test_buffers_and_named_buffers OSS Tests Reviewed By: albanD Differential Revision: D40801899 fbshipit-source-id: 872b28f2f0bfc667ec9065353d4db45c272a8064
samdow
added a commit
to samdow/torchrec
that referenced
this pull request
Nov 7, 2022
Summary: X-link: pytorch/pytorch#88090 Pull Request resolved: meta-pytorch#759 Since the remove_duplicate flag was added to named_buffers in D39493161 (meta-pytorch@672d105), this adds the same flag to named_parameters Reviewed By: albanD Differential Revision: D40801899 fbshipit-source-id: 726ea2fd62dda164d0bd7616a85ce7eb1d473507
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D40801899 |
samdow
force-pushed
the
export-D40801899
branch
from
38e0475 to
814d756
Compare
samdow
added a commit
to samdow/torchrec
that referenced
this pull request
Nov 7, 2022
Summary: X-link: pytorch/pytorch#88090 Pull Request resolved: meta-pytorch#759 Since the remove_duplicate flag was added to named_buffers in D39493161 (meta-pytorch@672d105), this adds the same flag to named_parameters Reviewed By: albanD Differential Revision: D40801899 fbshipit-source-id: 3b195a4c00c38636ccddf7313c0dc3ea976f0ad5
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D40801899 |
samdow
added a commit
to samdow/pytorch
that referenced
this pull request
Nov 7, 2022
Summary: Pull Request resolved: pytorch#88090 X-link: meta-pytorch/torchrec#759 Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@c12f829), this adds the same flag to named_parameters Test Plan: python test/test_nn.py -k test_buffers_and_named_buffers OSS Tests Reviewed By: albanD Differential Revision: D40801899 fbshipit-source-id: 2553cceecae1f37c544275d9841dff0097494813
samdow
force-pushed
the
export-D40801899
branch
from
814d756 to
d514e41
Compare
samdow
added a commit
to samdow/torchrec
that referenced
this pull request
Nov 7, 2022
Summary: X-link: pytorch/pytorch#88090 Pull Request resolved: meta-pytorch#759 Since the remove_duplicate flag was added to named_buffers in D39493161 (meta-pytorch@672d105), this adds the same flag to named_parameters Reviewed By: albanD Differential Revision: D40801899 fbshipit-source-id: 2adc53cebb5658c639b429bab24d69a106959ff6
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D40801899 |
samdow
added a commit
to samdow/pytorch
that referenced
this pull request
Nov 7, 2022
Summary: Pull Request resolved: pytorch#88090 X-link: meta-pytorch/torchrec#759 Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@c12f829), this adds the same flag to named_parameters Test Plan: python test/test_nn.py -k test_buffers_and_named_buffers OSS Tests Reviewed By: albanD Differential Revision: D40801899 fbshipit-source-id: 99aad6bb4b4876a81a6a92785f3e40a1c006538a
samdow
force-pushed
the
export-D40801899
branch
from
d514e41 to
28ca878
Compare
Summary: Pull Request resolved: pytorch#88090 X-link: meta-pytorch/torchrec#759 Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@c12f829), this adds the same flag to named_parameters Test Plan: python test/test_nn.py -k test_buffers_and_named_buffers OSS Tests Reviewed By: albanD Differential Revision: D40801899 fbshipit-source-id: 163bfd5052c42b9bd87cb35931d9f7be627e3256
samdow
added a commit
to samdow/torchrec
that referenced
this pull request
Nov 8, 2022
Summary: X-link: pytorch/pytorch#88090 Pull Request resolved: meta-pytorch#759 Since the remove_duplicate flag was added to named_buffers in D39493161 (meta-pytorch@672d105), this adds the same flag to named_parameters Reviewed By: albanD Differential Revision: D40801899 fbshipit-source-id: 89ab659ebdc2f916e62609f6e793d426b3a4518b
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D40801899 |
samdow
force-pushed
the
export-D40801899
branch
from
28ca878 to
259e061
Compare
Contributor
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
facebook-github-bot
pushed a commit
to meta-pytorch/torchrec
that referenced
this pull request
Nov 9, 2022
Summary: X-link: pytorch/pytorch#88090 Pull Request resolved: #759 Since the remove_duplicate flag was added to named_buffers in D39493161 (672d105), this adds the same flag to named_parameters Reviewed By: albanD Differential Revision: D40801899 fbshipit-source-id: 5318259adc6e3c487ccd95aeefecf0a02a1ce79d
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
lequytra
pushed a commit
to lequytra/torchrec
that referenced
this pull request
Dec 6, 2022
Summary: X-link: pytorch/pytorch#88090 Pull Request resolved: meta-pytorch#759 Since the remove_duplicate flag was added to named_buffers in D39493161 (meta-pytorch@672d105), this adds the same flag to named_parameters Reviewed By: albanD Differential Revision: D40801899 fbshipit-source-id: 5318259adc6e3c487ccd95aeefecf0a02a1ce79d
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
…orch#88090) Summary: X-link: meta-pytorch/torchrec#759 Since the remove_duplicate flag was added to named_buffers in D39493161 (pytorch@c12f829), this adds the same flag to named_parameters Test Plan: python test/test_nn.py -k test_buffers_and_named_buffers OSS Tests Differential Revision: D40801899 Pull Request resolved: pytorch#88090 Approved by: https://github.com/albanD
zou3519
added
module: bc-breaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: meta-pytorch/torchrec#759
Since the remove_duplicate flag was added to named_buffers in D39493161 (c12f829), this adds the same flag to named_parameters
Test Plan:
python test/test_nn.py -k test_buffers_and_named_buffers
OSS Tests
Differential Revision: D40801899
cc @ezyang @gchanan