[primTorch] _refs & opinfo alpha_dropout #87989
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87989
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 77637c9: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
cc: @mruberry @kshitij12345 @ngimel ! :) |
|
New functorch skips LGTM since this is adding a new OpInfo and the problems are pre-existing. Thanks for including comments with them. |
| 1 - p, | ||
| ) | ||
|
|
||
| alpha = 1.7580993408473766 |
There was a problem hiding this comment.
Add a comment for what's happening in this section
There was a problem hiding this comment.
I added a comment.
@mruberry, please correct me if I'm wrong, but I think the alpha should be -1.7580993408473766 instead of 1.7580993408473766 for consistency with the paper. However, the meaning is the same. Originally it was added and discussed in #1775 (comment). Later modified the alpha value in #9073.
mruberry
left a comment
mruberry
left a comment
There was a problem hiding this comment.
Looks like a good start, @khushi-411, but see comments inline
soulitzer
added
the
triaged
|
Hi, Gentle ping, @mruberry! I've addressed all the reviews. Thanks! |
|
@pytorchbot merge The CI turned green, merging this PR :) Thank you for the helpful comments and for reviewing @mruberry & @kshitij12345! Thanks, @zou3519 for reviewing the functorch side! |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@mruberry, I guess this PR needs your approval once more, Could you please? |
Merge failedReason: 2 additional jobs have failed, first few of them are: trunk ,trunk / linux-bionic-cuda11.7-py3.10-gcc7 / test (slow, 2, 2, linux.4xlarge.nvidia.gpu) Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: The following mandatory check(s) failed (Rule Dig deeper by viewing the failures on hud Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -f "test failure unrelated" |
|
You are not authorized to force merges to this repository. Please use the regular |
|
@pytorchmergebot merge -f "test failure unrelated" |
|
You are not authorized to force merges to this repository. Please use the regular |
|
@pytorchmergebot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 2 additional jobs have failed, first few of them are: trunk ,trunk / cuda11.6-py3.10-gcc7-sm86 / test (default, 1, 4, linux.g5.4xlarge.nvidia.gpu) Details for Dev Infra teamRaised by workflow job |
|
The failure (https://github.com/pytorch/pytorch/actions/runs/3444707468/jobs/5747874942) looks unrelated to me. @mruberry / @kshitij12345 Could anyone of you please help merge this? I'm not authorized to force merge :( Appreciate your help! Thanks and apologies for re-ping. |
|
@pytorchmergebot merge
Yay! Thanks! Since the CI is green, I can merge this now :) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Add _refs and OpInfo for `nn.functional.alpha_dropout` Pull Request resolved: pytorch#87989 Approved by: https://github.com/mruberry
7 participants
Add _refs and OpInfo for
nn.functional.alpha_dropout