remove assert_allclose from torch.testing #87974

pmeier · 2022-10-28T07:14:42Z

Stack from ghstack (oldest at bottom):

See #87969 or #86586 for the reasoning.

cc @albanD

[ghstack-poisoned]

pytorch-bot · 2022-10-28T07:14:45Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87974

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Failures

As of commit 2ae120b:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

cc albanD [ghstack-poisoned]

ghstack-source-id: f38a83a Pull Request resolved: #87974

cc albanD [ghstack-poisoned]

ghstack-source-id: c00ac52 Pull Request resolved: #87974

cc albanD [ghstack-poisoned]

ghstack-source-id: 5b08f32 Pull Request resolved: #87974

mruberry · 2022-11-02T13:57:08Z

caffe2/python/operator_test/_utils.py

@@ -1,5 +1,5 @@
 """
-This file only exists since `torch.testing.assert_allclose` is deprecated, but used extensively throughout the tests in
+This file only exists since `torch.testing.assert_allclose` was removed, but used extensively throughout the tests in


Nice doc update

mruberry

Nice to have the deprecations finalized!

pmeier · 2022-11-02T14:03:05Z

@pytorchbot merge -f "CI failures are unrelated"

pytorchmergebot · 2022-11-02T14:04:40Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

NicolasHug · 2022-11-03T15:12:12Z

IIRC pytest is swallowing warnings?

Yeah, this is due to:

pytorch/pytest.ini

Line 10 in 35be73d

-p no:warnings

By default, pytest does show the warnings though. So unless users have manually silenced their pytest warnings (like pytorch), they should have properly seen the deprecation message

pmeier · 2022-11-03T15:15:26Z

From #87969 (comment):

Deprecation happened on Feb 25, 2022 in c6f1bbc, which made it into the 1.12 release. Since it is now 245 days later and the next release will be 1.14, the removals later in the stack comply with the BC policy.

The RFC that lead to this deprecation is in #61844.

Was there deprecations warnings that I missed?

If you look at the diff into the deleted file torch.testing._deprecated, you can see that the function emitted a deprecation warning pointing to the RFC I linked above.

albanD · 2022-11-03T15:53:51Z

Out of curiosity what would you recommend instead?

tbh I use the direct python test_foo.py locally (with the additional -f -k or -v as needed).
It feels a lot more baremetal and no-magic-added which I prefer (but it is very personal!).

xuzhao9 · 2022-11-03T20:21:57Z

This PR breaks downstream code such as https://github.com/kornia/kornia/blob/v0.6.8/kornia/testing/__init__.py#L254

albanD · 2022-11-03T20:39:20Z

@xuzhao9 sorry about that. I'm a bit confused as the code there seem to imply that this case is only used for PT <1.9 ?

Summary: `assert_close` is preferred over `assert_allclose`: pytorch/pytorch#61844 The `assert_allclose` was removed yesterday in pytorch/pytorch#87974, causing test to fail, eg. https://github.com/facebookresearch/d2go/actions/runs/3389194553/jobs/5632021291 Reviewed By: sstsai-adl Differential Revision: D41000306 fbshipit-source-id: 8c513a3f570712452367f3210cf3644fb2b94666

xuzhao9 · 2022-11-03T21:22:08Z

@albanD The authors are aware of this change and is discussing a mitigation: kornia/kornia#1981
The offending line also includes: https://github.com/kornia/kornia/blob/v0.6.8/kornia/testing/__init__.py#L235.

Yes, currently kornia will only work on 1.9 > pytorch >=1.8.1, but it seems authors are working on a fix.

Summary: Pull Request resolved: #409 `assert_close` is preferred over `assert_allclose`: pytorch/pytorch#61844 The `assert_allclose` was removed yesterday in pytorch/pytorch#87974, causing test to fail, eg. https://github.com/facebookresearch/d2go/actions/runs/3389194553/jobs/5632021291 Reviewed By: sstsai-adl Differential Revision: D41000306 fbshipit-source-id: 7bd1cb9d5edf0a4609a909e2283df411bcabdf13

mehtanirav · 2022-11-04T19:11:00Z

Unfortunately, we need to revert this PR. We have many references to torch.testing.assert_allclose in internal tests that need to be updated before we can re-land this PR.

I will follow up on the task to update all internal reference to torch.testing.assert_allclose and inform @pmeier when it safe to re-land the PR.

@pytorchbot revert -m "Internal breakages from method removal" -c ghfirst

pytorchmergebot · 2022-11-04T19:12:29Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot · 2022-11-04T19:12:41Z

@pmeier your PR has been successfully reverted.

This reverts commit 5669e10. Reverted #87974 on behalf of https://github.com/mehtanirav due to Internal breakages from method removal

mehtanirav · 2022-11-04T20:40:56Z

cc: @albanD on the revert.

See pytorch#87969 or pytorch#86586 for the reasoning. Pull Request resolved: pytorch#87974 Approved by: https://github.com/mruberry

This reverts commit 5669e10. Reverted pytorch#87974 on behalf of https://github.com/mehtanirav due to Internal breakages from method removal

After our failed attempt to remove `assert_allclose` in #87974, we decided to add it to the documentation after all. Although we drop the expected removal date, the function continues to be deprecated in favor of `assert_close`. [ghstack-poisoned]

After our failed attempt to remove `assert_allclose` in #87974, we decided to add it to the documentation after all. Although we drop the expected removal date, the function continues to be deprecated in favor of `assert_close`. Pull Request resolved: #89526 Approved by: https://github.com/mruberry

See pytorch#87969 or pytorch#86586 for the reasoning. Pull Request resolved: pytorch#87974 Approved by: https://github.com/mruberry

This reverts commit 5669e10. Reverted pytorch#87974 on behalf of https://github.com/mehtanirav due to Internal breakages from method removal

After our failed attempt to remove `assert_allclose` in pytorch#87974, we decided to add it to the documentation after all. Although we drop the expected removal date, the function continues to be deprecated in favor of `assert_close`. Pull Request resolved: pytorch#89526 Approved by: https://github.com/mruberry

remove assert_allclose from torch.testing

29f229f

[ghstack-poisoned]

This was referenced Oct 28, 2022

prepare removal of deprecated functionality in torch.testing #87969

Closed

remove deprecated rand and randn from torch.testing #87970

Closed

This was referenced Oct 28, 2022

remove deprecated device getter from torch.testing #87971

Closed

remove deprecated dtype getters from torch.testing #87972

Closed

remove make_non_contiguous from torch.testing #87973

Closed

pmeier added ciflow/trunk Trigger trunk jobs on your pull request ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR topic: bc breaking topic category module: python frontend For issues relating to PyTorch's Python frontend labels Oct 28, 2022

Update on "remove assert_allclose from torch.testing"

6317a9d

cc albanD [ghstack-poisoned]

Update on "remove assert_allclose from torch.testing"

12a78aa

cc albanD [ghstack-poisoned]

pmeier added a commit that referenced this pull request Oct 28, 2022

remove assert_allclose from torch.testing

63563a2

ghstack-source-id: f38a83a Pull Request resolved: #87974

pmeier added release notes: python_frontend python frontend release notes category and removed module: python frontend For issues relating to PyTorch's Python frontend labels Oct 28, 2022

pytorchbot added the open source label Oct 28, 2022

Update on "remove assert_allclose from torch.testing"

be0fdda

cc albanD [ghstack-poisoned]

pmeier added a commit that referenced this pull request Oct 28, 2022

remove assert_allclose from torch.testing

85ea020

ghstack-source-id: c00ac52 Pull Request resolved: #87974

Update on "remove assert_allclose from torch.testing"

2ae120b

cc albanD [ghstack-poisoned]

pmeier added a commit that referenced this pull request Nov 2, 2022

remove assert_allclose from torch.testing

dbf27c0

ghstack-source-id: 5b08f32 Pull Request resolved: #87974

pmeier marked this pull request as ready for review November 2, 2022 10:26

mruberry reviewed Nov 2, 2022

View reviewed changes

mruberry approved these changes Nov 2, 2022

View reviewed changes

pytorchmergebot added the Merged label Nov 2, 2022

pmeier mentioned this pull request Nov 3, 2022

fix ONNX tests pytorch/vision#6901

Merged

xuzhao9 mentioned this pull request Nov 3, 2022

The latest pytorch nightly has removed torch.testing.assert_allclose kornia/kornia#1981

Closed

sosmond mentioned this pull request Nov 3, 2022

[BUG] Tests failing due to retiring of torch.testing.assert_allclose pytorch/rl#643

Closed

3 tasks

pmeier mentioned this pull request Nov 3, 2022

RFC: retire torch.testing.assert_allclose in favor of torch.testing.assert_close #61844

Closed

pytorchmergebot added the Reverted label Nov 4, 2022

pytorchmergebot added a commit that referenced this pull request Nov 4, 2022

Revert "remove assert_allclose from torch.testing (#87974)"

8c1c675

This reverts commit 5669e10. Reverted #87974 on behalf of https://github.com/mehtanirav due to Internal breakages from method removal

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022

remove assert_allclose from torch.testing (pytorch#87974)

357794c

See pytorch#87969 or pytorch#86586 for the reasoning. Pull Request resolved: pytorch#87974 Approved by: https://github.com/mruberry

This was referenced Nov 23, 2022

remove torch.equal usages #89527

Closed

document torch.testing.assert_allclose #89526

Closed

Vargol mentioned this pull request Nov 28, 2022

InvokeAI using MPS is broken by torch nightlies since torch-1.14.0.dev20221104 inclusive #89784

Closed

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022

remove assert_allclose from torch.testing (pytorch#87974)

522fc1c

See pytorch#87969 or pytorch#86586 for the reasoning. Pull Request resolved: pytorch#87974 Approved by: https://github.com/mruberry

facebook-github-bot deleted the gh/pmeier/40/head branch June 8, 2023 18:28

remove assert_allclose from torch.testing #87974

remove assert_allclose from torch.testing #87974

Uh oh!

Conversation

pmeier commented Oct 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Oct 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87974

❌ 2 Failures

Uh oh!

mruberry Nov 2, 2022

Choose a reason for hiding this comment

Uh oh!

mruberry left a comment

Choose a reason for hiding this comment

Uh oh!

pmeier commented Nov 2, 2022

Uh oh!

pytorchmergebot commented Nov 2, 2022

Merge started

Uh oh!

NicolasHug commented Nov 3, 2022

Uh oh!

pmeier commented Nov 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

albanD commented Nov 3, 2022

Uh oh!

xuzhao9 commented Nov 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

albanD commented Nov 3, 2022

Uh oh!

xuzhao9 commented Nov 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mehtanirav commented Nov 4, 2022

Uh oh!

pytorchmergebot commented Nov 4, 2022

Uh oh!

pytorchmergebot commented Nov 4, 2022

Uh oh!

mehtanirav commented Nov 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

pmeier commented Oct 28, 2022 •

edited

Loading

pytorch-bot bot commented Oct 28, 2022 •

edited

Loading

pmeier commented Nov 3, 2022 •

edited

Loading

xuzhao9 commented Nov 3, 2022 •

edited

Loading

xuzhao9 commented Nov 3, 2022 •

edited

Loading