Skip to content

remove make_non_contiguous from torch.testing #87973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pmeier wants to merge 5 commits into from
Closed

remove make_non_contiguous from torch.testing #87973

pmeier wants to merge 5 commits into from

Conversation

@pmeier
Copy link
Collaborator

@pmeier pmeier commented Oct 28, 2022 •
edited
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 28, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87973

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Failures

As of commit b536872:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Oct 28, 2022
Closed
Closed
Closed
Closed
Closed
@pmeier pmeier added ciflow/trunk Trigger trunk jobs on your pull request ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR topic: bc breaking topic category module: python frontend For issues relating to PyTorch's Python frontend labels Oct 28, 2022
@pmeier pmeier added release notes: foreach_frontend release notes category release notes: python_frontend python frontend release notes category and removed module: python frontend For issues relating to PyTorch's Python frontend release notes: foreach_frontend release notes category labels Oct 28, 2022
@pmeier pmeier marked this pull request as ready for review November 2, 2022 10:26
mruberry
mruberry approved these changes Nov 2, 2022
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022
@pmeier @kulinseth
remove make_non_contiguous from torch.testing (pytorch#87973)
a7285c0 
See pytorch#87969 or pytorch#86586 for the reasoning.

Pull Request resolved: pytorch#87973
Approved by: https://github.com/mruberry
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@pmeier @kulinseth
remove make_non_contiguous from torch.testing (pytorch#87973)
e4ca6d6 
See pytorch#87969 or pytorch#86586 for the reasoning.

Pull Request resolved: pytorch#87973
Approved by: https://github.com/mruberry
@kit1980 kit1980 added the Merged label Mar 24, 2023
@facebook-github-bot facebook-github-bot deleted the gh/pmeier/39/head branch June 8, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mruberry mruberry mruberry approved these changes

Assignees

No one assigned

Labels

ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: python_frontend python frontend release notes category topic: bc breaking topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pmeier @mruberry @kit1980 @pytorchbot