Skip to content

Added implementation and tests for MPS Hardswish #87952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thomaslin2020 wants to merge 3 commits into from
Closed

Added implementation and tests for MPS Hardswish #87952

thomaslin2020 wants to merge 3 commits into from

Conversation

@thomaslin2020
Copy link
Contributor

@thomaslin2020 thomaslin2020 commented Oct 28, 2022

What?

Fixes issue #86807 by adding MPS backend support for aten::hardswish.

How?

Registered mps hardswish functions in native_functions.yaml, and added the code implementation to Activations.mm.

Added functions:

  • hardswish_mps
  • hardswish_mps_
  • hardswish_backward_mps
  • hardswish_out_mps

Testing

Added test in test/test_mps.py and tested code using the command python3 test/test_mps.py -k test_hardswish

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 28, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87952

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures, 3 Pending

As of commit 8eb4674:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Oct 28, 2022
@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 31, 2022
kulinseth
kulinseth approved these changes Nov 3, 2022
View reviewed changes
Copy link
Collaborator

@kulinseth kulinseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good.

@kit1980
Copy link
Contributor

kit1980 commented Nov 22, 2022

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 22, 2022

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 22, 2022

Successfully rebased master onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout master && git pull --rebase)

@kit1980
Copy link
Contributor

kit1980 commented Nov 22, 2022

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 22, 2022
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 22, 2022

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 22, 2022

Merge failed

Reason: The following mandatory check(s) failed (Rule MPS):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@kit1980
Copy link
Contributor

kit1980 commented Nov 23, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 23, 2022

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@thomaslin2020 @kulinseth
Added implementation and tests for MPS Hardswish (pytorch#87952)
43f1040 
## What?
Fixes issue pytorch#86807 by adding MPS backend support for aten::hardswish.

## How?
Registered mps hardswish functions in native_functions.yaml, and added the code implementation to Activations.mm.

Added functions:
- hardswish_mps
- hardswish_mps_
- hardswish_backward_mps
- hardswish_out_mps

## Testing
Added test in test/test_mps.py and tested code using the command `python3 test/test_mps.py -k test_hardswish`

Pull Request resolved: pytorch#87952
Approved by: https://github.com/kulinseth, https://github.com/kit1980
@kulinseth kulinseth mentioned this pull request Feb 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kulinseth kulinseth kulinseth approved these changes

+1 more reviewer

@kit1980 kit1980 kit1980 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: mps Release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@thomaslin2020 @kit1980 @pytorchmergebot @kulinseth @soulitzer @pytorchbot