[ao] fixing public v private for torch.ao.nn.X #87883
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: this mostly consisted of adding __all__ to files without them. Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
HDCharles
requested review from
albanD,
anjali411 and
jbschlosser
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87883
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ca43e91: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 27, 2022
Contributor
Author
|
@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: this mostly consisted of adding __all__ to files without them. Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40814548](https://our.internmc.facebook.com/intern/diff/D40814548) [ghstack-poisoned]
This was referenced Nov 3, 2022
Summary: this mostly consisted of adding __all__ to files without them. A few functions in X.utils were made private too Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40814548](https://our.internmc.facebook.com/intern/diff/D40814548) cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel [ghstack-poisoned]
Summary: this mostly consisted of adding __all__ to files without them. A few functions in X.utils were made private too Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40814548](https://our.internmc.facebook.com/intern/diff/D40814548) cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel [ghstack-poisoned]
Summary: this mostly consisted of adding __all__ to files without them. A few functions in X.utils were made private too Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40814548](https://our.internmc.facebook.com/intern/diff/D40814548) cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel [ghstack-poisoned]
Summary: this mostly consisted of adding __all__ to files without them. A few functions in X.utils were made private too Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40814548](https://our.internmc.facebook.com/intern/diff/D40814548) cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel [ghstack-poisoned]
Summary: this mostly consisted of adding __all__ to files without them. A few functions in X.utils were made private too Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40814548](https://our.internmc.facebook.com/intern/diff/D40814548) cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel [ghstack-poisoned]
HDCharles
added a commit
that referenced
this pull request
Dec 8, 2022
Pull Request resolved: #87883 this mostly consisted of adding __all__ to files without them. ghstack-source-id: 175589669 Differential Revision: [D40814548](https://our.internmc.facebook.com/intern/diff/D40814548/)
Summary: this mostly consisted of adding __all__ to files without them. A few functions in X.utils were made private too Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40814548](https://our.internmc.facebook.com/intern/diff/D40814548) cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel [ghstack-poisoned]
Summary: this mostly consisted of adding __all__ to files without them. A few functions in X.utils were made private too Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40814548](https://our.internmc.facebook.com/intern/diff/D40814548) cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel [ghstack-poisoned]
HDCharles
added a commit
that referenced
this pull request
Dec 9, 2022
Pull Request resolved: #87883 this mostly consisted of adding __all__ to files without them. ghstack-source-id: 175621910 Differential Revision: [D40814548](https://our.internmc.facebook.com/intern/diff/D40814548/)
Summary: this mostly consisted of adding __all__ to files without them. A few functions in X.utils were made private too Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40814548](https://our.internmc.facebook.com/intern/diff/D40814548) cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel [ghstack-poisoned]
Summary: this mostly consisted of adding __all__ to files without them. A few functions in X.utils were made private too Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40814548](https://our.internmc.facebook.com/intern/diff/D40814548) cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel [ghstack-poisoned]
Summary: this mostly consisted of adding __all__ to files without them. A few functions in X.utils were made private too Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40814548](https://our.internmc.facebook.com/intern/diff/D40814548) cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel [ghstack-poisoned]
Summary: this mostly consisted of adding __all__ to files without them. A few functions in X.utils were made private too Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40814548](https://our.internmc.facebook.com/intern/diff/D40814548) cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel [ghstack-poisoned]
Summary: this mostly consisted of adding __all__ to files without them. A few functions in X.utils were made private too Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40814548](https://our.internmc.facebook.com/intern/diff/D40814548) cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel [ghstack-poisoned]
Summary: this mostly consisted of adding __all__ to files without them. A few functions in X.utils were made private too Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40814548](https://our.internmc.facebook.com/intern/diff/D40814548) cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel [ghstack-poisoned]
Summary: this mostly consisted of adding __all__ to files without them. A few functions in X.utils were made private too Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40814548](https://our.internmc.facebook.com/intern/diff/D40814548) cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel [ghstack-poisoned]
Contributor
Author
|
@pytorchmergebot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
hasanyeganeh
pushed a commit
to hasanyeganeh/pytorch-pytorch
that referenced
this pull request
Dec 21, 2022
Pull Request resolved: pytorch/pytorch#87883 this mostly consisted of adding __all__ to files without them. ghstack-source-id: 175555671 Differential Revision: [D40814548](https://our.internmc.facebook.com/intern/diff/D40814548/)
hasanyeganeh
pushed a commit
to hasanyeganeh/pytorch-pytorch
that referenced
this pull request
Dec 21, 2022
Summary: this mostly consisted of adding __all__ to files without them. A few functions in X.utils were made private too Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: c301d9c Pull Request resolved: pytorch/pytorch#87883
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: this mostly consisted of adding all to files without them.
A few functions in X.utils were made private too
Test Plan: python test/test_public_bindings.py
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D40814548
cc @jerryzh168 @jianyuh @raghuramank100 @jamesr66a @vkuzo @jgong5 @Xia-Weiwen @leslie-fang-intel