[ao] quant_type.py fixing public v private #87519

HDCharles · 2022-10-21T22:07:05Z

Stack from ghstack (oldest at bottom):

Summary: made _get_quant_type_to_str private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D40709282

cc @jerryzh168 @jianyuh @raghuramank100 @jamesr66a @vkuzo @jgong5 @Xia-Weiwen @leslie-fang-intel

Summary: made _get_quant_type_to_str private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

pytorch-bot · 2022-10-21T22:07:07Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87519

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b636f4f:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Summary: made _get_quant_type_to_str private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

HDCharles · 2022-10-26T05:16:35Z

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary: made _get_quant_type_to_str private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40709282](https://our.internmc.facebook.com/intern/diff/D40709282) [ghstack-poisoned]

HDCharles · 2022-10-28T20:05:51Z

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary: made _get_quant_type_to_str private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40709282](https://our.internmc.facebook.com/intern/diff/D40709282) [ghstack-poisoned]

Summary: made _get_quant_type_to_str private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40709282](https://our.internmc.facebook.com/intern/diff/D40709282) cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen [ghstack-poisoned]

HDCharles · 2022-11-04T03:57:25Z

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary: made _get_quant_type_to_str private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40709282](https://our.internmc.facebook.com/intern/diff/D40709282) cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen [ghstack-poisoned]

HDCharles · 2022-11-04T16:38:39Z

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary: made _get_quant_type_to_str private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40709282](https://our.internmc.facebook.com/intern/diff/D40709282) cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen [ghstack-poisoned]

HDCharles · 2022-11-07T21:54:26Z

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary: made _get_quant_type_to_str private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40709282](https://our.internmc.facebook.com/intern/diff/D40709282) [ghstack-poisoned]

HDCharles · 2022-11-08T16:06:59Z

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

jcaip · 2022-11-09T19:41:22Z

torch/ao/quantization/quant_type.py

    QuantType.WEIGHT_ONLY: "weight_only",
 }

 # TODO: make this private


nit: can remove this comment

Summary: made _get_quant_type_to_str private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40709282](https://our.internmc.facebook.com/intern/diff/D40709282) [ghstack-poisoned]

HDCharles · 2022-11-11T03:33:35Z

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary: made _get_quant_type_to_str private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40709282](https://our.internmc.facebook.com/intern/diff/D40709282) [ghstack-poisoned]

HDCharles · 2022-11-11T17:26:14Z

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2022-11-15T15:38:34Z

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorchmergebot · 2022-11-15T15:42:26Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Summary: made _get_quant_type_to_str private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40709282](https://our.internmc.facebook.com/intern/diff/D40709282) Pull Request resolved: pytorch#87519 Approved by: https://github.com/jcaip

[ao] quant_type.py fixing public v private

6899e6d

Summary: made _get_quant_type_to_str private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

HDCharles requested review from albanD, anjali411, jerryzh168 and z-a-f as code owners October 21, 2022 22:07

pytorch-bot bot added the release notes: quantization release notes category label Oct 21, 2022

albanD removed their request for review October 23, 2022 20:01

Update on "[ao] quant_type.py fixing public v private"

ec0c655

Summary: made _get_quant_type_to_str private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

This was referenced Oct 27, 2022

[ao] fixing public v private for torch.ao.nn.X #87883

Closed

[ao] fixing public v private for nn util functions #87884

Closed

[ao] public v private stubs and utils #87885

Closed

This was referenced Nov 3, 2022

[ao][fx] fixing public v private qconfig_mapping_utils.py #88399

Closed

[ao][fx] fixing public v private utils.py #88400

Closed

github-actions bot added the oncall: quantization Quantization support in PyTorch label Nov 3, 2022

This was referenced Nov 3, 2022

[ao] removing private from allowlist #88404

Closed

[ao] fixing private in quantization-support.rst #88405

Closed

HDCharles added 2 commits November 4, 2022 21:56

jcaip approved these changes Nov 9, 2022

View reviewed changes

torch/ao/quantization/quant_type.py

QuantType.WEIGHT_ONLY: "weight_only",

}

# TODO: make this private

Copy link

Contributor

jcaip Nov 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can remove this comment

HDCharles added 3 commits November 11, 2022 08:34

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 15, 2022

pytorchmergebot added the Merged label Nov 15, 2022

pytorchmergebot closed this in b9029fc Nov 15, 2022

facebook-github-bot deleted the gh/HDCharles/125/head branch June 8, 2023 14:36

[ao] quant_type.py fixing public v private #87519

[ao] quant_type.py fixing public v private #87519

Uh oh!

Conversation

HDCharles commented Oct 21, 2022 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Oct 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87519

✅ No Failures

Uh oh!

HDCharles commented Oct 26, 2022

Uh oh!

HDCharles commented Oct 28, 2022

Uh oh!

HDCharles commented Nov 4, 2022

Uh oh!

HDCharles commented Nov 4, 2022

Uh oh!

HDCharles commented Nov 7, 2022

Uh oh!

HDCharles commented Nov 8, 2022

Uh oh!

jcaip Nov 9, 2022

Choose a reason for hiding this comment

Uh oh!

HDCharles commented Nov 11, 2022

Uh oh!

HDCharles commented Nov 11, 2022

Uh oh!

facebook-github-bot commented Nov 15, 2022

Uh oh!

pytorchmergebot commented Nov 15, 2022

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

HDCharles commented Oct 21, 2022 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Oct 21, 2022 •

edited

Loading