[ao] qconfig.py fix public v private #87515
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: made is_reuse_input_qconfig, _activation_is_memoryless, _partial_wrapper_equals, _obs_or_fq_ctr_equals, _add_module_to_qconfig_obs_ctr, _assert_valid_qconfig private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
HDCharles
requested review from
albanD,
anjali411,
jerryzh168 and
z-a-f
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87515
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Failures, 10 PendingAs of commit e8a50e0: The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 21, 2022
Summary: made is_reuse_input_qconfig, _activation_is_memoryless, _partial_wrapper_equals, _obs_or_fq_ctr_equals, _add_module_to_qconfig_obs_ctr, _assert_valid_qconfig private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Contributor
Author
|
@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
jerryzh168
reviewed
Oct 26, 2022
| ], | ||
| "torch.nn.qat.dynamic.modules.linear": [ | ||
| "activation_is_memoryless" | ||
| "_activation_is_memoryless" |
Contributor
There was a problem hiding this comment.
I think we can remove these after we made them private
Contributor
Author
There was a problem hiding this comment.
i remove them at the end of the stack since there's a lot that can get removed
Summary: made is_reuse_input_qconfig, _activation_is_memoryless, _partial_wrapper_equals, _obs_or_fq_ctr_equals, _add_module_to_qconfig_obs_ctr, _assert_valid_qconfig private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40709280](https://our.internmc.facebook.com/intern/diff/D40709280) [ghstack-poisoned]
This was referenced Oct 27, 2022
Contributor
Author
|
@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: made is_reuse_input_qconfig, _activation_is_memoryless, _partial_wrapper_equals, _obs_or_fq_ctr_equals, _add_module_to_qconfig_obs_ctr, _assert_valid_qconfig private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40709280](https://our.internmc.facebook.com/intern/diff/D40709280) [ghstack-poisoned]
This was referenced Nov 3, 2022
This was referenced Nov 3, 2022
This was referenced Nov 3, 2022
Summary: made is_reuse_input_qconfig, _activation_is_memoryless, _partial_wrapper_equals, _obs_or_fq_ctr_equals, _add_module_to_qconfig_obs_ctr, _assert_valid_qconfig private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40709280](https://our.internmc.facebook.com/intern/diff/D40709280) cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen [ghstack-poisoned]
Contributor
Author
|
@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: made is_reuse_input_qconfig, _activation_is_memoryless, _partial_wrapper_equals, _obs_or_fq_ctr_equals, _add_module_to_qconfig_obs_ctr, _assert_valid_qconfig private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40709280](https://our.internmc.facebook.com/intern/diff/D40709280) cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen [ghstack-poisoned]
Contributor
Author
|
@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: made is_reuse_input_qconfig, _activation_is_memoryless, _partial_wrapper_equals, _obs_or_fq_ctr_equals, _add_module_to_qconfig_obs_ctr, _assert_valid_qconfig private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40709280](https://our.internmc.facebook.com/intern/diff/D40709280) cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen [ghstack-poisoned]
Summary: made is_reuse_input_qconfig, _activation_is_memoryless, _partial_wrapper_equals, _obs_or_fq_ctr_equals, _add_module_to_qconfig_obs_ctr, _assert_valid_qconfig private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40709280](https://our.internmc.facebook.com/intern/diff/D40709280) cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen [ghstack-poisoned]
Contributor
Author
|
@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: made is_reuse_input_qconfig, _activation_is_memoryless, _partial_wrapper_equals, _obs_or_fq_ctr_equals, _add_module_to_qconfig_obs_ctr, _assert_valid_qconfig private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40709280](https://our.internmc.facebook.com/intern/diff/D40709280) [ghstack-poisoned]
Contributor
Author
|
@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
1 similar comment
Contributor
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
Summary: made is_reuse_input_qconfig, _activation_is_memoryless, _partial_wrapper_equals, _obs_or_fq_ctr_equals, _add_module_to_qconfig_obs_ctr, _assert_valid_qconfig private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40709280](https://our.internmc.facebook.com/intern/diff/D40709280) Pull Request resolved: pytorch#87515 Approved by: https://github.com/jcaip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: made is_reuse_input_qconfig, _activation_is_memoryless,
_partial_wrapper_equals, _obs_or_fq_ctr_equals,
_add_module_to_qconfig_obs_ctr, _assert_valid_qconfig private
Test Plan: python test/test_public_bindings.py
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D40709280
cc @jerryzh168 @jianyuh @raghuramank100 @jamesr66a @vkuzo @jgong5 @Xia-Weiwen @leslie-fang-intel