Skip to content

Fix registration hooks #87369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
antoniojkim wants to merge 2 commits into from
Closed

Fix registration hooks #87369

antoniojkim wants to merge 2 commits into from

Conversation

@antoniojkim
Copy link
Collaborator

@antoniojkim antoniojkim commented Oct 20, 2022

There is a bug in the implementation of the registration hooks introduced in #86148 whereby if the hook returns a tensor, then the short circuiting logic:

value = hook(self, name, value) or value

Raises an exception

RuntimeError: Boolean value of Tensor with more than one value is ambiguous

Fixing the logic so that it only checks to see if the value is None before overriding

Fixes #85837

CC: @albanD @jbschlosser

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 20, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87369

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures, 2 Pending

As of commit ba338ef:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

albanD
albanD reviewed Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oups! good catch.
Could you add a test to ensure we don't regress that in the future please?

@antoniojkim antoniojkim requested a review from albanD October 20, 2022 18:18
albanD
albanD approved these changes Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM !

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 20, 2022
@albanD
Copy link
Collaborator

albanD commented Oct 20, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 20, 2022

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 20, 2022

Merge failed

Reason: 1 additional jobs have failed, first few of them are: trunk

Details for Dev Infra team Raised by workflow job

@antoniojkim antoniojkim force-pushed the antoniojkim/fix_registration_hooks branch from 3442604 to ba338ef Compare October 21, 2022 02:12
@antoniojkim
Copy link
Collaborator Author

antoniojkim commented Oct 21, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 21, 2022

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2022

Hey @antoniojkim.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@jbschlosser jbschlosser Awaiting requested review from jbschlosser

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Parameter Registration Hook

4 participants

@antoniojkim @albanD @pytorchmergebot @pytorchbot