🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87240

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit fe79b20:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

somehow did not see it replaces the _reduce_scatter_base() call in fully_sharded_data_parallel.py?

After Olga's communication hook work, the reduce-scatter is now the one in torch/distributed/algorithms/_comm_hooks/default_hooks.py.

@rohan-varma mentioned maybe the call is too non-obvious now. We can refactor later.

@pytorchbot rebase -s

@pytorchbot successfully started a rebase job. Check the current status here

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/viable/strict gh/awgu/133/orig returned non-zero exit code 1

Rebasing (1/1)
Auto-merging test/distributed/fsdp/test_fsdp_comm.py
CONFLICT (content): Merge conflict in test/distributed/fsdp/test_fsdp_comm.py
error: could not apply e4eb7466c1... [FSDP] Use `reduce_scatter_tensor()`
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply e4eb7466c1... [FSDP] Use `reduce_scatter_tensor()`

Raised by https://github.com/pytorch/pytorch/actions/runs/3309788180

@pytorchbot merge

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Hey @awgu.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.