Skip to content

Support signbit in MPS. #87214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dfalbel wants to merge 2 commits into from
Closed

Support signbit in MPS. #87214

dfalbel wants to merge 2 commits into from

Conversation

@dfalbel
Copy link
Contributor

@dfalbel dfalbel commented Oct 18, 2022

Implements the signbit operator for MPS. Links to #77764

@dfalbel dfalbel requested a review from kulinseth as a code owner October 18, 2022 16:24
@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Oct 18, 2022
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 18, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87214

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures, 1 Pending

As of commit 157e4c4:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 18, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: dfalbel / name: Daniel Falbel (054466e)

kulinseth
kulinseth approved these changes Oct 18, 2022
View reviewed changes
Copy link
Collaborator

@kulinseth kulinseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo the nit, it looks good. Thanks

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 18, 2022
@dfalbel
Copy link
Contributor Author

dfalbel commented Oct 18, 2022

Thanks! Fixed the typo :)

@kit1980
Copy link
Contributor

kit1980 commented Oct 25, 2022

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 25, 2022

@pytorchbot successfully started a rebase job. Check the current status here

dfalbel and others added 2 commits October 25, 2022 02:27
@dfalbel @pytorchmergebot
Support signbit in MPS.
73dfd09
@dfalbel @kulinseth @pytorchmergebot
Correct typo.
157e4c4 
Co-authored-by: Kulin Seth <kulinseth@gmail.com>
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 25, 2022

Successfully rebased mps-signbit onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout mps-signbit && git pull --rebase)

@kit1980
Copy link
Contributor

kit1980 commented Oct 25, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 25, 2022

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2022

Hey @dfalbel.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@DenisVieriu97 DenisVieriu97 mentioned this pull request Oct 25, 2022
Open
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022
@dfalbel @kulinseth
Support signbit in MPS. (pytorch#87214)
32f9ddb 
Implements the signbit operator for MPS. Links to pytorch#77764

Pull Request resolved: pytorch#87214
Approved by: https://github.com/kulinseth, https://github.com/kit1980
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@dfalbel @kulinseth
Support signbit in MPS. (pytorch#87214)
6ebb69c 
Implements the signbit operator for MPS. Links to pytorch#77764

Pull Request resolved: pytorch#87214
Approved by: https://github.com/kulinseth, https://github.com/kit1980
@deppemj deppemj mentioned this pull request Jul 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kulinseth kulinseth kulinseth approved these changes

+1 more reviewer

@kit1980 kit1980 kit1980 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: mps Release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dfalbel @kit1980 @pytorchmergebot @kulinseth @pytorchbot