[einsum] Fix opt_einsum defaults to be more reasonable (#86985) #87144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87144
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ae8a5b1: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
approved these changes
Oct 18, 2022
Contributor
|
@pytorchbot rebase -m release/1.13 |
|
❌ 🤖 pytorchbot command failed: Try |
Contributor
|
@pytorchbot rebase -b release/1.13 |
Collaborator
|
@pytorchbot successfully started a rebase job. Check the current status here |
Fixes the confusing situation mentioned here #85224 (comment) by - setting better OG defaults - changing warnings to errors now that we have better defaults Test plan: - Ran einsum tests locally + CI - Uninstalled opt-einsum and ran through setting - `enabled` to False (doesn't throw error) - `strategy` to anything that's not None (errors) - `strategy` to None (noops) - Installed opt-einsum and ran through setting - `enabled` to False (doesn't throw error) - `enabled` to True (doesn't throw error, no ops + defaults to 'auto') - `strategy` to random string (errors) - `strategy` to None (noops, still is 'auto') - `strategy` to 'greedy' (is set to 'greedy') Pull Request resolved: #86985 Approved by: https://github.com/soulitzer
Collaborator
|
Successfully rebased |
pytorchmergebot
force-pushed
the
cp-release
branch
from
7612969 to
ae8a5b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the confusing situation mentioned here #85224 (comment) by
Test plan:
enabledto False (doesn't throw error) -strategyto anything that's not None (errors) -strategyto None (noops)enabledto False (doesn't throw error) -enabledto True (doesn't throw error, no ops + defaults to 'auto') -strategyto random string (errors) -strategyto None (noops, still is 'auto') -strategyto 'greedy' (is set to 'greedy')Pull Request resolved: [einsum] Fix opt_einsum defaults to be more reasonable #86985
Approved by: https://github.com/soulitzer