Skip to content

conv backward impl #87047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
albanD wants to merge 4 commits into from
Closed

conv backward impl #87047

albanD wants to merge 4 commits into from

Conversation

@albanD
Copy link
Collaborator

@albanD albanD commented Oct 16, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

Waiting for test run to see if this backward is actually exercised.
If not, I will add test before merging.
Test updated. Ready to go now.

@albanD
conv backward impl
0f8e49c 
[ghstack-poisoned]
@albanD albanD mentioned this pull request Oct 16, 2022
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 16, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87047

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures, 6 Pending

As of commit 922cbc1:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Oct 16, 2022
Closed
Closed
Closed
ezyang
ezyang approved these changes Oct 16, 2022
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lf xfail removal

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 16, 2022
@albanD albanD changed the title conv backward impl [WI] conv backward impl Oct 16, 2022
@albanD albanD changed the title [WI] conv backward impl [WIP] conv backward impl Oct 16, 2022
@albanD
Update on "[WIP] conv backward impl"
8372636 
~~Waiting for test run to see if this backward is actually exercised.
If not, I will add test before merging.~~
Test updated. Ready to go now.

[ghstack-poisoned]
@albanD albanD changed the title [WIP] conv backward impl conv backward impl Oct 16, 2022
@albanD
Update on "conv backward impl"
922cbc1 
~~Waiting for test run to see if this backward is actually exercised.
If not, I will add test before merging.~~
Test updated. Ready to go now.

[ghstack-poisoned]
@albanD
Copy link
Collaborator Author

albanD commented Oct 17, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 17, 2022

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2022

Hey @albanD.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Rick0317 pushed a commit to Rick0317/pytorch that referenced this pull request Oct 18, 2022
@albanD
conv backward impl
97f68b3 
ghstack-source-id: 1239ce6
Pull Request resolved: pytorch/pytorch#87047
@facebook-github-bot facebook-github-bot deleted the gh/albanD/108/head branch June 8, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@anjali411 anjali411 Awaiting requested review from anjali411

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@Chillee Chillee Awaiting requested review from Chillee

@Krovatkin Krovatkin Awaiting requested review from Krovatkin

@miladm miladm Awaiting requested review from miladm

@wconstab wconstab Awaiting requested review from wconstab

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@albanD @pytorchmergebot @ezyang