meta funcs for avg_pool2d and avg_pool2d_backward #87043
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87043
Note: Links to docs will display an error until the docs builds have been completed. ✅ No Failures, 5 PendingAs of commit 791b658: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 16, 2022
github-actions
bot
requested review from
Chillee,
Krovatkin,
anjali411,
antoniojkim,
bdhirsh,
ezyang,
miladm and
wconstab
[ghstack-poisoned]
ezyang
reviewed
Oct 16, 2022
[ghstack-poisoned]
ezyang
reviewed
Oct 16, 2022
| lambda: "avg_pool2d: padding must either be a single int, or a tuple of two ints", | ||
| ) | ||
| padH = padding[0] | ||
| padW = padH if len(padding) == 1 else padding[1] |
Contributor
There was a problem hiding this comment.
I think this code is my fault, but just noting that we can do wayyyy better in Python now lol
Collaborator
Author
There was a problem hiding this comment.
Since the structure here is to follow the c++ code, not sure if we want to change it or not.
Do you think that preserving the c++ structure is better or making these nice python functions?
ezyang
reviewed
Oct 16, 2022
ezyang
approved these changes
Oct 16, 2022
[ghstack-poisoned]
[ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):