Skip to content

[Profiler] Regularize AccumulateGrad name #86909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
robieta wants to merge 8 commits into from
Closed

[Profiler] Regularize AccumulateGrad name #86909

robieta wants to merge 8 commits into from

Conversation

@robieta
Copy link
Contributor

@robieta robieta commented Oct 13, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

Memory profiler will use AccumulateGrad when detecting gradients. The name difference between Windows and other platforms has already cropped up with profiler trees so it makes sense to address it at the source.

Differential Revision: D40347550

[Profiler] Regularize AccumulateGrad name
b0b5c57 
Memory profiler will use AccumulateGrad when detecting gradients. The name difference between Windows and other platforms has already cropped up with profiler trees so it makes sense to address it at the source.

Differential Revision: [D40347550](https://our.internmc.facebook.com/intern/diff/D40347550/)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 13, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86909

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 669714a:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Oct 13, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Update on "[Profiler] Regularize AccumulateGrad name"
75c55b7 
Memory profiler will use AccumulateGrad when detecting gradients. The name difference between Windows and other platforms has already cropped up with profiler trees so it makes sense to address it at the source.

Differential Revision: [D40347550](https://our.internmc.facebook.com/intern/diff/D40347550/)

[ghstack-poisoned]
@robieta robieta mentioned this pull request Oct 15, 2022
Closed
Update on "[Profiler] Regularize AccumulateGrad name"
af087f7 
Memory profiler will use AccumulateGrad when detecting gradients. The name difference between Windows and other platforms has already cropped up with profiler trees so it makes sense to address it at the source.

Differential Revision: [D40347550](https://our.internmc.facebook.com/intern/diff/D40347550/)

[ghstack-poisoned]
@robieta robieta mentioned this pull request Oct 17, 2022
Closed
slgong-fb
slgong-fb approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@slgong-fb slgong-fb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 17, 2022
Update on "[Profiler] Regularize AccumulateGrad name"
009fd62 
Memory profiler will use AccumulateGrad when detecting gradients. The name difference between Windows and other platforms has already cropped up with profiler trees so it makes sense to address it at the source.

Differential Revision: [D40347550](https://our.internmc.facebook.com/intern/diff/D40347550/)

[ghstack-poisoned]
@robieta robieta mentioned this pull request Oct 19, 2022
Closed
Update on "[Profiler] Regularize AccumulateGrad name"
46be0aa 
Memory profiler will use AccumulateGrad when detecting gradients. The name difference between Windows and other platforms has already cropped up with profiler trees so it makes sense to address it at the source.

Differential Revision: [D40347550](https://our.internmc.facebook.com/intern/diff/D40347550/)

[ghstack-poisoned]
@robieta robieta added release notes: profiler release notes category ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR labels Oct 19, 2022
@robieta
Copy link
Contributor Author

robieta commented Oct 20, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 20, 2022

Merge failed

Reason: Approval needed from one of the following (Rule 'superuser'):
rshraga, HengruiX, langong347, mcr229, bertmaher, ...

Details for Dev Infra team Raised by workflow job

@robieta
Copy link
Contributor Author

robieta commented Oct 20, 2022

@pytorchbot merge -f -m "Failures lower in the stack were unrelated flakes."

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 20, 2022

❌ 🤖 pytorchbot command failed:

@pytorchbot merge: error: argument -f/--force: expected one argument

usage: @pytorchbot merge [-g | -f MESSAGE | -l] [-r [{viable/strict,master}]]

Try @pytorchbot --help for more info.

@robieta
Copy link
Contributor Author

robieta commented Oct 20, 2022

@pytorchbot merge -f "Failures lower in the stack were unrelated flakes."

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 20, 2022

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 20, 2022

Merge failed

Reason: Approval needed from one of the following (Rule 'superuser'):
andrewor14, qxy11, bugra, HDCharles, janghyuncho, ...

Details for Dev Infra team Raised by workflow job

Update on "[Profiler] Regularize AccumulateGrad name"
ae67067 
Memory profiler will use AccumulateGrad when detecting gradients. The name difference between Windows and other platforms has already cropped up with profiler trees so it makes sense to address it at the source.

Differential Revision: [D40347550](https://our.internmc.facebook.com/intern/diff/D40347550/)

[ghstack-poisoned]
aaronenyeshi
aaronenyeshi approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@aaronenyeshi aaronenyeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Taylor Robie added 2 commits October 21, 2022 11:42
Update on "[Profiler] Regularize AccumulateGrad name"
cbcd1dd 
Memory profiler will use AccumulateGrad when detecting gradients. The name difference between Windows and other platforms has already cropped up with profiler trees so it makes sense to address it at the source.

Differential Revision: [D40347550](https://our.internmc.facebook.com/intern/diff/D40347550/)

[ghstack-poisoned]
Update on "[Profiler] Regularize AccumulateGrad name"
669714a 
Memory profiler will use AccumulateGrad when detecting gradients. The name difference between Windows and other platforms has already cropped up with profiler trees so it makes sense to address it at the source.

Differential Revision: [D40347550](https://our.internmc.facebook.com/intern/diff/D40347550/)

[ghstack-poisoned]
This was referenced Oct 23, 2022
Closed
Closed
Closed
@robieta
Copy link
Contributor Author

robieta commented Oct 23, 2022

@pytorchbot merge -f "the buck test failure is unrelated"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 23, 2022

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2022

Hey @robieta.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022
@kulinseth
[Profiler] Regularize AccumulateGrad name (pytorch#86909)
de87db1 
Memory profiler will use AccumulateGrad when detecting gradients. The name difference between Windows and other platforms has already cropped up with profiler trees so it makes sense to address it at the source.

Differential Revision: [D40347550](https://our.internmc.facebook.com/intern/diff/D40347550/)
Pull Request resolved: pytorch#86909
Approved by: https://github.com/slgong-fb, https://github.com/aaronenyeshi
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@kulinseth
[Profiler] Regularize AccumulateGrad name (pytorch#86909)
dd23736 
Memory profiler will use AccumulateGrad when detecting gradients. The name difference between Windows and other platforms has already cropped up with profiler trees so it makes sense to address it at the source.

Differential Revision: [D40347550](https://our.internmc.facebook.com/intern/diff/D40347550/)
Pull Request resolved: pytorch#86909
Approved by: https://github.com/slgong-fb, https://github.com/aaronenyeshi
@facebook-github-bot facebook-github-bot deleted the gh/robieta/138/head branch June 8, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aaronenyeshi aaronenyeshi aaronenyeshi approved these changes

@chaekit chaekit Awaiting requested review from chaekit

+1 more reviewer

@slgong-fb slgong-fb slgong-fb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: profiler release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@robieta @pytorchmergebot @aaronenyeshi @slgong-fb