[Profiler] Memory profiler part 2: Config validation #86853
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Memory profiling requires `record_shapes`, `profile_memory`, and `with_stack`. This PR just adds a skeleton endpoint with a good error message if certain flags are missing. Differential Revision: [D39920801](https://our.internmc.facebook.com/intern/diff/D39920801/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86853
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit aa512dc: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 13, 2022
Memory profiling requires `record_shapes`, `profile_memory`, and `with_stack`. This PR just adds a skeleton endpoint with a good error message if certain flags are missing. Differential Revision: [D39920801](https://our.internmc.facebook.com/intern/diff/D39920801/) [ghstack-poisoned]
Memory profiling requires `record_shapes`, `profile_memory`, and `with_stack`. This PR just adds a skeleton endpoint with a good error message if certain flags are missing. Differential Revision: [D39920801](https://our.internmc.facebook.com/intern/diff/D39920801/) [ghstack-poisoned]
Memory profiling requires `record_shapes`, `profile_memory`, and `with_stack`. This PR just adds a skeleton endpoint with a good error message if certain flags are missing. Differential Revision: [D39920801](https://our.internmc.facebook.com/intern/diff/D39920801/) [ghstack-poisoned]
Memory profiling requires `record_shapes`, `profile_memory`, and `with_stack`. This PR just adds a skeleton endpoint with a good error message if certain flags are missing. Differential Revision: [D39920801](https://our.internmc.facebook.com/intern/diff/D39920801/) [ghstack-poisoned]
added 2 commits
October 17, 2022 14:49
Memory profiling requires `record_shapes`, `profile_memory`, and `with_stack`. This PR just adds a skeleton endpoint with a good error message if certain flags are missing. Differential Revision: [D39920801](https://our.internmc.facebook.com/intern/diff/D39920801/) [ghstack-poisoned]
Memory profiling requires `record_shapes`, `profile_memory`, and `with_stack`. This PR just adds a skeleton endpoint with a good error message if certain flags are missing. Differential Revision: [D39920801](https://our.internmc.facebook.com/intern/diff/D39920801/) [ghstack-poisoned]
Memory profiling requires `record_shapes`, `profile_memory`, and `with_stack`. This PR just adds a skeleton endpoint with a good error message if certain flags are missing. Differential Revision: [D39920801](https://our.internmc.facebook.com/intern/diff/D39920801/) [ghstack-poisoned]
added 2 commits
October 21, 2022 11:42
Memory profiling requires `record_shapes`, `profile_memory`, and `with_stack`. This PR just adds a skeleton endpoint with a good error message if certain flags are missing. Differential Revision: [D39920801](https://our.internmc.facebook.com/intern/diff/D39920801/) [ghstack-poisoned]
Memory profiling requires `record_shapes`, `profile_memory`, and `with_stack`. This PR just adds a skeleton endpoint with a good error message if certain flags are missing. Differential Revision: [D39920801](https://our.internmc.facebook.com/intern/diff/D39920801/) [ghstack-poisoned]
This was referenced Oct 23, 2022
added 2 commits
October 24, 2022 10:21
Memory profiling requires `record_shapes`, `profile_memory`, and `with_stack`. This PR just adds a skeleton endpoint with a good error message if certain flags are missing. Differential Revision: [D39920801](https://our.internmc.facebook.com/intern/diff/D39920801/) [ghstack-poisoned]
Memory profiling requires `record_shapes`, `profile_memory`, and `with_stack`. This PR just adds a skeleton endpoint with a good error message if certain flags are missing. Differential Revision: [D39920801](https://our.internmc.facebook.com/intern/diff/D39920801/) [ghstack-poisoned]
This was referenced Oct 25, 2022
added 2 commits
October 24, 2022 21:55
Memory profiling requires `record_shapes`, `profile_memory`, and `with_stack`. This PR just adds a skeleton endpoint with a good error message if certain flags are missing. Differential Revision: [D39920801](https://our.internmc.facebook.com/intern/diff/D39920801/) [ghstack-poisoned]
Memory profiling requires `record_shapes`, `profile_memory`, and `with_stack`. This PR just adds a skeleton endpoint with a good error message if certain flags are missing. Differential Revision: [D39920801](https://our.internmc.facebook.com/intern/diff/D39920801/) [ghstack-poisoned]
added 3 commits
October 26, 2022 16:56
Memory profiling requires `record_shapes`, `profile_memory`, and `with_stack`. This PR just adds a skeleton endpoint with a good error message if certain flags are missing. Differential Revision: [D39920801](https://our.internmc.facebook.com/intern/diff/D39920801/) [ghstack-poisoned]
Memory profiling requires `record_shapes`, `profile_memory`, and `with_stack`. This PR just adds a skeleton endpoint with a good error message if certain flags are missing. Differential Revision: [D39920801](https://our.internmc.facebook.com/intern/diff/D39920801/) [ghstack-poisoned]
Memory profiling requires `record_shapes`, `profile_memory`, and `with_stack`. This PR just adds a skeleton endpoint with a good error message if certain flags are missing. Differential Revision: [D39920801](https://our.internmc.facebook.com/intern/diff/D39920801/) [ghstack-poisoned]
robieta
pushed a commit
that referenced
this pull request
Oct 31, 2022
Pull Request resolved: #86853 Memory profiling requires `record_shapes`, `profile_memory`, and `with_stack`. This PR just adds a skeleton endpoint with a good error message if certain flags are missing. ghstack-source-id: 172169616 Differential Revision: [D39920801](https://our.internmc.facebook.com/intern/diff/D39920801/)
added 2 commits
November 7, 2022 11:24
Memory profiling requires `record_shapes`, `profile_memory`, and `with_stack`. This PR just adds a skeleton endpoint with a good error message if certain flags are missing. Differential Revision: [D39920801](https://our.internmc.facebook.com/intern/diff/D39920801/) [ghstack-poisoned]
Memory profiling requires `record_shapes`, `profile_memory`, and `with_stack`. This PR just adds a skeleton endpoint with a good error message if certain flags are missing. Differential Revision: [D39920801](https://our.internmc.facebook.com/intern/diff/D39920801/) [ghstack-poisoned]
chaekit
approved these changes
Nov 8, 2022
Memory profiling requires `record_shapes`, `profile_memory`, and `with_stack`. This PR just adds a skeleton endpoint with a good error message if certain flags are missing. Differential Revision: [D39920801](https://our.internmc.facebook.com/intern/diff/D39920801/) [ghstack-poisoned]
Memory profiling requires `record_shapes`, `profile_memory`, and `with_stack`. This PR just adds a skeleton endpoint with a good error message if certain flags are missing. Differential Revision: [D39920801](https://our.internmc.facebook.com/intern/diff/D39920801/) [ghstack-poisoned]
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
Memory profiling requires `record_shapes`, `profile_memory`, and `with_stack`. This PR just adds a skeleton endpoint with a good error message if certain flags are missing. Differential Revision: [D39920801](https://our.internmc.facebook.com/intern/diff/D39920801/) Pull Request resolved: pytorch#86853 Approved by: https://github.com/chaekit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Memory profiling requires
record_shapes,profile_memory, andwith_stack. This PR just adds a skeleton endpoint with a good error message if certain flags are missing.Differential Revision: D39920801