[Profiler] Tensor IDs for Module and Optimizer variables #86754
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More sophisticated profiling will increasingly rely on python tracer to contextualize observed results. This PR adds Tensors which are observed by the python tracer to the identity assignment loop. Differential Revision: [D39852885](https://our.internmc.facebook.com/intern/diff/D39852885/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86754
Note: Links to docs will display an error until the docs builds have been completed. ✅ No Failures, 9 PendingAs of commit e6bde08: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 12, 2022
More sophisticated profiling will increasingly rely on python tracer to contextualize observed results. This PR adds Tensors which are observed by the python tracer to the identity assignment loop. Differential Revision: [D39852885](https://our.internmc.facebook.com/intern/diff/D39852885/) [ghstack-poisoned]
This was referenced Oct 12, 2022
More sophisticated profiling will increasingly rely on python tracer to contextualize observed results. This PR adds Tensors which are observed by the python tracer to the identity assignment loop. Differential Revision: [D39852885](https://our.internmc.facebook.com/intern/diff/D39852885/) [ghstack-poisoned]
More sophisticated profiling will increasingly rely on python tracer to contextualize observed results. This PR adds Tensors which are observed by the python tracer to the identity assignment loop. Differential Revision: [D39852885](https://our.internmc.facebook.com/intern/diff/D39852885/) [ghstack-poisoned]
slgong-fb
approved these changes
Oct 17, 2022
| ska::flat_hash_set<storage_id_t> tensor_set; | ||
| auto insert_tensor = [&lookup, &tensors, &tensor_set](TensorMetadata& m) { | ||
| if (m.impl_ && m.data_) { | ||
| const auto id = lookup(m.data_); |
Contributor
There was a problem hiding this comment.
do we use reuse lookup() anywhere else? otherwise, we can merge it into insert_tensor?
Contributor
Author
There was a problem hiding this comment.
That's a fair point. You're right, but I'm going to leave it simply because #87133 (later in the stack) removes it altogether.
| auto id = lookup(m->data_); | ||
| tensor_set.insert(id); | ||
| tensors.emplace_back(TensorStoragePair{m->impl_, id, m->id_}); | ||
| if (m.has_value()) { |
Contributor
There was a problem hiding this comment.
this line too. we can merge this check into insert_tensor?
Contributor
Author
There was a problem hiding this comment.
So it's funny you should ask that. I wanted insert_tensor to take c10::optional, but it turns out that T doesn't implicitly convert to c10::optional<T>. And building an overload set with c10::overloaded wasn't really any cleaner.
More sophisticated profiling will increasingly rely on python tracer to contextualize observed results. This PR adds Tensors which are observed by the python tracer to the identity assignment loop. Differential Revision: [D39852885](https://our.internmc.facebook.com/intern/diff/D39852885/) [ghstack-poisoned]
More sophisticated profiling will increasingly rely on python tracer to contextualize observed results. This PR adds Tensors which are observed by the python tracer to the identity assignment loop. Differential Revision: [D39852885](https://our.internmc.facebook.com/intern/diff/D39852885/) [ghstack-poisoned]
More sophisticated profiling will increasingly rely on python tracer to contextualize observed results. This PR adds Tensors which are observed by the python tracer to the identity assignment loop. Differential Revision: [D39852885](https://our.internmc.facebook.com/intern/diff/D39852885/) [ghstack-poisoned]
added 2 commits
October 21, 2022 11:42
More sophisticated profiling will increasingly rely on python tracer to contextualize observed results. This PR adds Tensors which are observed by the python tracer to the identity assignment loop. Differential Revision: [D39852885](https://our.internmc.facebook.com/intern/diff/D39852885/) [ghstack-poisoned]
More sophisticated profiling will increasingly rely on python tracer to contextualize observed results. This PR adds Tensors which are observed by the python tracer to the identity assignment loop. Differential Revision: [D39852885](https://our.internmc.facebook.com/intern/diff/D39852885/) [ghstack-poisoned]
This was referenced Oct 23, 2022
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Nov 5, 2022
More sophisticated profiling will increasingly rely on python tracer to contextualize observed results. This PR adds Tensors which are observed by the python tracer to the identity assignment loop. Differential Revision: [D39852885](https://our.internmc.facebook.com/intern/diff/D39852885/) Pull Request resolved: pytorch#86754 Approved by: https://github.com/slgong-fb, https://github.com/aaronenyeshi
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
More sophisticated profiling will increasingly rely on python tracer to contextualize observed results. This PR adds Tensors which are observed by the python tracer to the identity assignment loop. Differential Revision: [D39852885](https://our.internmc.facebook.com/intern/diff/D39852885/) Pull Request resolved: pytorch#86754 Approved by: https://github.com/slgong-fb, https://github.com/aaronenyeshi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
AccumulateGradname #86909More sophisticated profiling will increasingly rely on python tracer to contextualize observed results. This PR adds Tensors which are observed by the python tracer to the identity assignment loop.
Differential Revision: D39852885