[Profiler][Trivial] Small style and safety fixes #86752
Conversation
I noticed a couple abbreviations in the new optimizer capture code that are worth expanding. I also made the RawTensorMetadata a bit safer. Differential Revision: [D40210702](https://our.internmc.facebook.com/intern/diff/D40210702/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86752
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 10b2548: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
I noticed a couple abbreviations in the new optimizer capture code that are worth expanding. I also made the RawTensorMetadata a bit safer. Differential Revision: [D40210702](https://our.internmc.facebook.com/intern/diff/D40210702/) [ghstack-poisoned]
I noticed a couple abbreviations in the new optimizer capture code that are worth expanding. I also made the RawTensorMetadata a bit safer. Differential Revision: [D40210702](https://our.internmc.facebook.com/intern/diff/D40210702/) [ghstack-poisoned]
I noticed a couple abbreviations in the new optimizer capture code that are worth expanding. I also made the RawTensorMetadata a bit safer. Differential Revision: [D40210702](https://our.internmc.facebook.com/intern/diff/D40210702/) [ghstack-poisoned]
slgong-fb
left a comment
slgong-fb
left a comment
There was a problem hiding this comment.
Great styling and safety check! I had already noticed these changes from the unpublished diff stack.
I noticed a couple abbreviations in the new optimizer capture code that are worth expanding. I also made the RawTensorMetadata a bit safer. Differential Revision: [D40210702](https://our.internmc.facebook.com/intern/diff/D40210702/) [ghstack-poisoned]
I noticed a couple abbreviations in the new optimizer capture code that are worth expanding. I also made the RawTensorMetadata a bit safer. Differential Revision: [D40210702](https://our.internmc.facebook.com/intern/diff/D40210702/) [ghstack-poisoned]
|
@pytorchbot merge -f "last ci failure is unrelated (test ops)" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: Approval needed from one of the following (Rule 'superuser'): Details for Dev Infra teamRaised by workflow job |
I noticed a couple abbreviations in the new optimizer capture code that are worth expanding. I also made the RawTensorMetadata a bit safer. Differential Revision: [D40210702](https://our.internmc.facebook.com/intern/diff/D40210702/) [ghstack-poisoned]
|
@pytorchbot merge |
Merge failedReason: Approval needed from one of the following (Rule 'superuser'): Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
Merge failedReason: Approval needed from one of the following (Rule 'superuser'): Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
Hey @robieta. |
Stack from ghstack (oldest at bottom):
AccumulateGradname #86909I noticed a couple abbreviations in the new optimizer capture code that are worth expanding. I also made the RawTensorMetadata a bit safer.
Differential Revision: D40210702