🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86706

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 879df37:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

The committers listed above are authorized under a signed CLA.

• ✅ login: min-jean-cho (86eca9f)

@eellison @davidberard98, could you please help review this PR?

@davidberard98 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

I started the tests. I will review after they run. If I forget feel free to tag me @min-jean-cho.

Also, please sign the CLA when you get a chance.

@min-jean-cho I see some build failures. Please take a look. If you aren't sure what the issues are, ping me and I can help investigate.

Thank you @davidberard98 for the help, I will ping you after resolving the build issues. Thank you!

@davidberard98 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Also, please sign the CLA when you get a chance.

I have signed the CLA, seems like it's taking some time to process.

The committers listed above are authorized under a signed CLA.

• ✅ login: min-jean-cho (7ea1abd)

@min-jean-cho, I think the CLA gets processed immediately with EasyCLA.
It looks like 4 of your commits were pushed with git config that didn't allow EasyCLA to match user.email that it has in its database.

If only the latest commit is considered by EasyCLA, then rebasing with GitHub website UI (as you did earlier once in this PR) would help pass this check.
If that wouldn't help, you can update your git config locally, probably soft reset these 5 commits, then create a single commit, and force push to GitHub.

@davidberard98 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Thank you @davidberard98 @sanchitintel for the guidance. CLA has passed now.

@davidberard98 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Hi @davidberard98, looks like the meta internal CI/CD has passed as well. Could you please help review when available? Thanks!

@min-jean-cho, just FYI - that checkmark only suggests that the commit of this PR imported for Meta internal CI checks is the same as the latest commit of this PR, but the status of those CI checks is not visible to folks outside Meta.

@min-jean-cho minor nit: could you use linux newlines instead of dos newlines in the new files you added, just for consistency in the codebase?
still looking at the content of the PR, just wanted to mention that before I forget :)

Thanks @davidberard98 :) . I double checked that all files were already in linux newlines. Could you help double check this?

minor nit: could you use linux newlines instead of dos newlines in the new files you added, just for consistency in the codebase?

Thanks, this reminded me that I might also need to fix this in the code already merged, and should proactively check for it in future PRs.

@pytorchbot rebase -b master

@pytorchbot successfully started a rebase job. Check the current status here

Successfully rebased minjean/lin_bn_folding onto refs/remotes/origin/master, please pull locally before adding more changes (for example, via git checkout minjean/lin_bn_folding && git pull --rebase)

Successfully rebased minjean/lin_bn_folding onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout minjean/lin_bn_folding && git pull --rebase)

@davidberard98 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@pytorchbot merge

fyi, the previous failure was also a flaky test; if this one doesn't pass we can probably force merge.

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Thanks @davidberard98 ~ sounds good !

@davidberard98, I see it's merged! Appreciate your help and review to landing one of my first PRs to PyTorch!

@min-jean-cho Glad to help - and sorry it took me so long, feel free to ping me more frequently if you need code review in the future, because sometimes I miss the notifications

@pytorchbot revert -m "possibly causing internal build failures, will revert and investigate later" -c ghfirst

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@min-jean-cho your PR has been successfully reverted.

@min-jean-cho sorry about that, we're seeing some internal failures associated with this PR that I need to investigate before we can try re-landing...

do you think you can re-open a second PR with the same contents? (this will help avoid any issues with syncing between the internal and external version of the PR)