remove deprecated torch.testing functionality #86586
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
added
module: testing
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86586
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b5c9386: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Collaborator
Author
|
It seems there is more to do here. I'll convert to draft for now and ping again when CI is green. |
pmeier
added
ciflow/trunk
pmeier
added a commit
that referenced
this pull request
Oct 28, 2022
…y in torch.testing" _Redo of #86586 with all BC breaking changes granularly placed into separate commits._ --- Per title. Deprecation happened on Feb 25, 2022 in c6f1bbc, which made it into the 1.12 release. Since it is now 245 days later and the next release will be 1.14, the removals later in the stack comply with the [BC policy](https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#minimizing-the-disruption-of-bc-breaking-changes). [ghstack-poisoned]
pmeier
added a commit
that referenced
this pull request
Oct 28, 2022
_Redo of #86586 with all BC breaking changes granularly placed into separate commits._ --- Per title. Deprecation happened on Feb 25, 2022 in c6f1bbc, which made it into the 1.12 release. Since it is now 245 days later and the next release will be 1.14, the removals later in the stack comply with the [BC policy](https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#minimizing-the-disruption-of-bc-breaking-changes). [ghstack-poisoned]
pmeier
added a commit
that referenced
this pull request
Nov 2, 2022
…y in torch.testing" _Redo of #86586 with all BC breaking changes granularly placed into separate commits._ --- Per title. Deprecation happened on Feb 25, 2022 in c6f1bbc, which made it into the 1.12 release. Since it is now 245 days later and the next release will be 1.14, the removals later in the stack comply with the [BC policy](https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#minimizing-the-disruption-of-bc-breaking-changes). [ghstack-poisoned]
pmeier
added a commit
that referenced
this pull request
Nov 2, 2022
_Redo of #86586 with all BC breaking changes granularly placed into separate commits._ --- Per title. Deprecation happened on Feb 25, 2022 in c6f1bbc, which made it into the 1.12 release. Since it is now 245 days later and the next release will be 1.14, the removals later in the stack comply with the [BC policy](https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#minimizing-the-disruption-of-bc-breaking-changes). [ghstack-poisoned]
Collaborator
Author
This was referenced Nov 2, 2022
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 2, 2022
_Redo of #86586 with all BC breaking changes granularly placed into separate commits._ --- Per title. Deprecation happened on Feb 25, 2022 in c6f1bbc, which made it into the 1.12 release. Since it is now 245 days later and the next release will be 1.14, the removals later in the stack comply with the [BC policy](https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#minimizing-the-disruption-of-bc-breaking-changes). Pull Request resolved: #87969 Approved by: https://github.com/mruberry
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 2, 2022
See #87969 or #86586 for the reasoning. Pull Request resolved: #87970 Approved by: https://github.com/mruberry
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 2, 2022
See #87969 or #86586 for the reasoning. Pull Request resolved: #87971 Approved by: https://github.com/mruberry
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 2, 2022
See #87969 or #86586 for the reasoning. Pull Request resolved: #87972 Approved by: https://github.com/mruberry
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 2, 2022
See #87969 or #86586 for the reasoning. Pull Request resolved: #87973 Approved by: https://github.com/mruberry
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 2, 2022
See #87969 or #86586 for the reasoning. Pull Request resolved: #87974 Approved by: https://github.com/mruberry
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Nov 5, 2022
…#87969) _Redo of pytorch#86586 with all BC breaking changes granularly placed into separate commits._ --- Per title. Deprecation happened on Feb 25, 2022 in c6f1bbc, which made it into the 1.12 release. Since it is now 245 days later and the next release will be 1.14, the removals later in the stack comply with the [BC policy](https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#minimizing-the-disruption-of-bc-breaking-changes). Pull Request resolved: pytorch#87969 Approved by: https://github.com/mruberry
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Nov 5, 2022
See pytorch#87969 or pytorch#86586 for the reasoning. Pull Request resolved: pytorch#87970 Approved by: https://github.com/mruberry
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Nov 5, 2022
See pytorch#87969 or pytorch#86586 for the reasoning. Pull Request resolved: pytorch#87971 Approved by: https://github.com/mruberry
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Nov 5, 2022
See pytorch#87969 or pytorch#86586 for the reasoning. Pull Request resolved: pytorch#87972 Approved by: https://github.com/mruberry
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Nov 5, 2022
See pytorch#87969 or pytorch#86586 for the reasoning. Pull Request resolved: pytorch#87973 Approved by: https://github.com/mruberry
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Nov 5, 2022
See pytorch#87969 or pytorch#86586 for the reasoning. Pull Request resolved: pytorch#87974 Approved by: https://github.com/mruberry
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
…#87969) _Redo of pytorch#86586 with all BC breaking changes granularly placed into separate commits._ --- Per title. Deprecation happened on Feb 25, 2022 in c6f1bbc, which made it into the 1.12 release. Since it is now 245 days later and the next release will be 1.14, the removals later in the stack comply with the [BC policy](https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#minimizing-the-disruption-of-bc-breaking-changes). Pull Request resolved: pytorch#87969 Approved by: https://github.com/mruberry
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
See pytorch#87969 or pytorch#86586 for the reasoning. Pull Request resolved: pytorch#87970 Approved by: https://github.com/mruberry
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
See pytorch#87969 or pytorch#86586 for the reasoning. Pull Request resolved: pytorch#87971 Approved by: https://github.com/mruberry
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
See pytorch#87969 or pytorch#86586 for the reasoning. Pull Request resolved: pytorch#87972 Approved by: https://github.com/mruberry
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
See pytorch#87969 or pytorch#86586 for the reasoning. Pull Request resolved: pytorch#87973 Approved by: https://github.com/mruberry
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
See pytorch#87969 or pytorch#86586 for the reasoning. Pull Request resolved: pytorch#87974 Approved by: https://github.com/mruberry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per title. Deprecation happened on Feb 25, 2022 in c6f1bbc, which made it into the 1.12 release. Since it is now 227 days later and the next release will be 1.14, this removal complies with the BC policy.
For internal users nothing should change as long as they imported everything from
torch.testing._internal. A quick search through the repo did not turn up anything to the contrary.