add support for pin memory on xpu device #86545

leizhenyuan · 2022-10-09T07:28:43Z

add support for pin memory on xpu device

pytorch-bot · 2022-10-09T07:28:45Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86545

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❗ 3 Active SEVs

There are 3 currently active SEVs. If your PR is affected, please view them below:

❌ 1 Failures

As of commit cf05cea:

The following jobs have failed:

ios-12-5-1-x86-64 / build

This comment was automatically generated by Dr. CI and updates every 15 minutes.

linux-foundation-easycla · 2022-10-09T07:28:46Z

The committers listed above are authorized under a signed CLA.

✅ login: leizhenyuan (acc1709)

leizhenyuan · 2022-10-10T01:59:29Z

@ezyang I would like to add a xpu support for pin_memory, pls check is there and problem in this pr?

ezyang · 2022-10-10T18:13:02Z

Seems alright. Need cla

leizhenyuan · 2022-10-11T08:50:19Z

Finished CLA

ezyang · 2022-10-11T19:04:33Z

Fix ci and i will land

ezyang · 2022-10-12T13:11:19Z

Ci fail is real

gujinghui · 2022-10-13T15:47:44Z

@leizhenyuan pls fix the CI fail ASAP.

leizhenyuan · 2022-10-16T07:02:38Z

hi, @ezyang i met this in build test :
Build should have OpenMP enabled, but torch.backends.openmp.is_available() is False
can u give me some advice on how to enable openMP to pass the build test?
thanks a lot

ezyang · 2022-10-17T14:24:06Z

it seems unlikely to be your problem

ezyang · 2022-10-17T14:24:12Z

@pytorchbot rebase

pytorchmergebot · 2022-10-17T14:26:06Z

@pytorchbot successfully started a rebase job. Check the current status here

pytorchmergebot · 2022-10-17T14:26:11Z

Successfully rebased zhenyuan_pin_memory_xpu onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout zhenyuan_pin_memory_xpu && git pull --rebase)

ezyang · 2022-10-18T03:16:32Z

@pytorchbot merge --rebase

pytorchmergebot · 2022-10-18T03:18:06Z

@pytorchbot successfully started a rebase job. Check the current status here

pytorchmergebot · 2022-10-18T03:18:09Z

Successfully rebased zhenyuan_pin_memory_xpu onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout zhenyuan_pin_memory_xpu && git pull --rebase)

pytorchmergebot · 2022-10-18T03:19:14Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2022-10-18T05:30:10Z

Merge failed

Reason: 9 additional jobs have failed, first few of them are: trunk ,trunk / ios-12-5-1-x86-64 / build ,trunk / android-emulator-build-test / build-and-test ,trunk / macos-12-py3-x86-64 / build ,trunk / macos-12-py3-x86-64-lite-interpreter / build

Details for Dev Infra team

Raised by workflow job

leizhenyuan · 2022-10-18T06:25:52Z

There are still some build test failed, could u please help me pass these tests? @ezyang
Thanks a lot.

ezyang · 2022-10-18T13:23:15Z

@pytorchbot merge --rebase

pytorchmergebot · 2022-10-18T13:24:36Z

@pytorchbot successfully started a rebase job. Check the current status here

pytorchmergebot · 2022-10-18T13:24:38Z

Tried to rebase and push PR #86545, but it was already up to date

pytorchmergebot · 2022-10-18T13:25:46Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2022-10-18T13:25:49Z

Merge failed

Reason: 9 additional jobs have failed, first few of them are: trunk ,trunk / ios-12-5-1-x86-64 / build ,trunk / android-emulator-build-test / build-and-test ,trunk / macos-12-py3-x86-64 / build ,trunk / macos-12-py3-x86-64-lite-interpreter / build

Details for Dev Infra team

Raised by workflow job

ezyang · 2022-10-18T13:26:38Z

@pytorchbot rebase

pytorchmergebot · 2022-10-18T13:28:30Z

@pytorchbot successfully started a rebase job. Check the current status here

pytorchmergebot · 2022-10-18T13:28:33Z

Tried to rebase and push PR #86545, but it was already up to date

…_xpu

ezyang · 2022-10-18T13:34:43Z

@pytorchbot merge

pytorchmergebot · 2022-10-18T13:36:52Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2022-10-18T15:48:12Z

Merge failed

Reason: 2 additional jobs have failed, first few of them are: trunk ,trunk / ios-12-5-1-x86-64 / build

Details for Dev Infra team

Raised by workflow job

leizhenyuan · 2022-10-19T07:17:55Z

seems build still failed for some filed cannot be found

ezyang · 2022-10-19T13:23:19Z

@pytorchbot merge -f "unrelated ci problem"

pytorchmergebot · 2022-10-19T13:24:44Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

github-actions · 2022-10-19T13:25:37Z

Hey @leizhenyuan.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

add support for pin memory on xpu device Pull Request resolved: pytorch#86545 Approved by: https://github.com/ezyang

pytorch-bot bot added the release notes: dataloader release notes category label Oct 9, 2022

pytorchbot added the open source label Oct 9, 2022

dagitses requested a review from VitalyFedyunin October 10, 2022 17:20

dagitses added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 10, 2022

ezyang approved these changes Oct 10, 2022

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 10, 2022

pytorchmergebot force-pushed the zhenyuan_pin_memory_xpu branch from 5af2e4b to a0e6685 Compare October 17, 2022 14:26

leizhenyuan added 4 commits October 18, 2022 03:18

add support for pin memory on xpu device

1bb6614

fix lint error

033f999

aset default as cuda for pin_memory_device

0b4e7e7

fix flake8 error

c0d0e4f

pytorchmergebot force-pushed the zhenyuan_pin_memory_xpu branch from bcb9683 to c0d0e4f Compare October 18, 2022 03:18

Merge remote-tracking branch 'origin/master' into zhenyuan_pin_memory…

cf05cea

…_xpu

pytorchmergebot added the Merged label Oct 19, 2022

pytorchmergebot closed this in c6187ea Oct 19, 2022

neggles pushed a commit to neggles/pytorch that referenced this pull request Mar 9, 2023

add support for pin memory on xpu device (pytorch#86545)

74d5ad3

add support for pin memory on xpu device Pull Request resolved: pytorch#86545 Approved by: https://github.com/ezyang

NivekT mentioned this pull request Mar 21, 2023

num_worker and prefetch_factor in DataLoader do not scale #81412

Open

add support for pin memory on xpu device #86545

add support for pin memory on xpu device #86545

Uh oh!

Conversation

leizhenyuan commented Oct 9, 2022

Uh oh!

pytorch-bot bot commented Oct 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86545

❗ 3 Active SEVs

❌ 1 Failures

Uh oh!

linux-foundation-easycla bot commented Oct 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

leizhenyuan commented Oct 10, 2022

Uh oh!

ezyang commented Oct 10, 2022

Uh oh!

leizhenyuan commented Oct 11, 2022

Uh oh!

ezyang commented Oct 11, 2022

Uh oh!

ezyang commented Oct 12, 2022

Uh oh!

gujinghui commented Oct 13, 2022

Uh oh!

leizhenyuan commented Oct 16, 2022

Uh oh!

ezyang commented Oct 17, 2022

Uh oh!

ezyang commented Oct 17, 2022

Uh oh!

pytorchmergebot commented Oct 17, 2022

Uh oh!

pytorchmergebot commented Oct 17, 2022

Uh oh!

ezyang commented Oct 18, 2022

Uh oh!

pytorchmergebot commented Oct 18, 2022

Uh oh!

pytorchmergebot commented Oct 18, 2022

Uh oh!

pytorchmergebot commented Oct 18, 2022

Merge started

Uh oh!

pytorchmergebot commented Oct 18, 2022

Merge failed

Uh oh!

leizhenyuan commented Oct 18, 2022

Uh oh!

ezyang commented Oct 18, 2022

Uh oh!

pytorchmergebot commented Oct 18, 2022

Uh oh!

pytorchmergebot commented Oct 18, 2022

Uh oh!

pytorchmergebot commented Oct 18, 2022

Merge started

Uh oh!

pytorchmergebot commented Oct 18, 2022

Merge failed

Uh oh!

ezyang commented Oct 18, 2022

Uh oh!

pytorchmergebot commented Oct 18, 2022

Uh oh!

pytorchmergebot commented Oct 18, 2022

Uh oh!

ezyang commented Oct 18, 2022

Uh oh!

pytorchmergebot commented Oct 18, 2022

Merge started

Uh oh!

pytorchmergebot commented Oct 18, 2022

Merge failed

Uh oh!

leizhenyuan commented Oct 19, 2022

Uh oh!

pytorch-bot bot commented Oct 9, 2022 •

edited

Loading

linux-foundation-easycla bot commented Oct 9, 2022 •

edited

Loading