Skip to content

[11/N] Update all_to_all with CPU/CUDA implementations #86407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
H-Huang wants to merge 3 commits into from
Closed

[11/N] Update all_to_all with CPU/CUDA implementations #86407

H-Huang wants to merge 3 commits into from

Conversation

@H-Huang
Copy link
Member

@H-Huang H-Huang commented Oct 6, 2022 •
edited
Loading

Stack from ghstack:

Changes

  • Updates for the all_to_all collective

Context

#86225

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 6, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86407

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit aa2a0fc:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: distributed (c10d) release notes category label Oct 6, 2022
This was referenced Oct 6, 2022
Closed
Closed
Closed
Closed
Closed
Closed
@H-Huang
Copy link
Member Author

H-Huang commented Oct 7, 2022

@H-Huang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@H-Huang H-Huang mentioned this pull request Oct 17, 2022
Closed
kwen2501
kwen2501 approved these changes Oct 28, 2022
View reviewed changes
Copy link
Collaborator

@kwen2501 kwen2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

test/distributed/test_c10d_common.py
if collective == dist.reduce_scatter:
collective(tensor, [tensor], *args)
else:
collective([tensor], [tensor], *args)
Copy link
Collaborator

@kwen2501 kwen2501 Oct 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: please see my comment in [10/N] to dissolve this if-else block.

Copy link
Member Author

@H-Huang H-Huang Nov 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Agree with this, will update in future PR to avoid the need to rebase stack

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 28, 2022
@H-Huang
Update on "[11/N] Update all_to_all with CPU/CUDA implementations"
aa2a0fc 
* #83916 [7/N] [Dispatchable Collectives] Update reduce with CPU / CUDA implementations

[ghstack-poisoned]
@H-Huang
Copy link
Member Author

H-Huang commented Nov 1, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 1, 2022

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

This was referenced Nov 2, 2022
Closed
Closed
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022
@H-Huang @kulinseth
[11/N] Update all_to_all with CPU/CUDA implementations (pytorch#86407)
5b155c6 
* pytorch#83916 [7/N] [Dispatchable Collectives] Update reduce with CPU / CUDA implementations
Pull Request resolved: pytorch#86407
Approved by: https://github.com/kwen2501
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@H-Huang @kulinseth
[11/N] Update all_to_all with CPU/CUDA implementations (pytorch#86407)
19a17c1 
* pytorch#83916 [7/N] [Dispatchable Collectives] Update reduce with CPU / CUDA implementations
Pull Request resolved: pytorch#86407
Approved by: https://github.com/kwen2501
@facebook-github-bot facebook-github-bot deleted the gh/H-Huang/85/head branch June 8, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kwen2501 kwen2501 kwen2501 approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@pritamdamania87 pritamdamania87 Awaiting requested review from pritamdamania87

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@awgu awgu Awaiting requested review from awgu

@mingzhe09088 mingzhe09088 Awaiting requested review from mingzhe09088

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: distributed (c10d) release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@H-Huang @pytorchmergebot @kwen2501