Skip to content

Add meta support for _adaptive_avg_pool2d_backward #86359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anjali411 wants to merge 4 commits into from
Closed

Add meta support for _adaptive_avg_pool2d_backward #86359

anjali411 wants to merge 4 commits into from

Conversation

@anjali411
Copy link
Contributor

@anjali411 anjali411 commented Oct 6, 2022 •
edited
Loading

@anjali411 anjali411 mentioned this pull request Oct 6, 2022
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 6, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86359

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures, 1 Pending

As of commit 7c34470:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@anjali411 anjali411 mentioned this pull request Oct 6, 2022
Closed
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 6, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

anjali411 added a commit that referenced this pull request Oct 6, 2022
@anjali411
Add meta support for _adaptive_avg_pool2d_backward
ba4fb6c 
ghstack-source-id: 6784d90
Pull Request resolved: #86359
albanD
albanD reviewed Oct 6, 2022
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. missing xfail update?

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 6, 2022
anjali411 added a commit that referenced this pull request Oct 10, 2022
@anjali411
Add meta support for _adaptive_avg_pool2d_backward
ef12159 
ghstack-source-id: ffe9ac0
Pull Request resolved: #86359
@anjali411
Copy link
Contributor Author

anjali411 commented Oct 10, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 10, 2022

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 11, 2022

Merge failed

Reason: 1 additional jobs have failed, first few of them are: trunk

Details for Dev Infra team Raised by workflow job

@anjali411
Copy link
Contributor Author

anjali411 commented Oct 11, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 11, 2022

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 11, 2022

Merge failed

Reason: 1 additional jobs have failed, first few of them are: trunk

Details for Dev Infra team Raised by workflow job

albanD
albanD approved these changes Oct 11, 2022
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM
CI failures seems to be infra?

@anjali411
Copy link
Contributor Author

anjali411 commented Oct 11, 2022

@pytorchbot merge -f "unrelated CI failures"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 11, 2022

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2022

Hey @anjali411.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@clee2000
Copy link
Contributor

clee2000 commented Oct 11, 2022

@pytorchbot revert -m "causing unexpected success for functorch on master but PR is green (landrace?) https://github.com/pytorch/pytorch/actions/runs/3227306657/jobs/5282180524 https://hud.pytorch.org/pytorch/pytorch/commit/a56a8c0fc0251bb4cd24b366a290db2e4beea747" -c "weird"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 11, 2022

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 11, 2022

@anjali411 your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Oct 11, 2022
@pytorchmergebot
Revert "Add meta support for _adaptive_avg_pool2d_backward (#86359)"
3edf79d 
This reverts commit a56a8c0.

Reverted #86359 on behalf of https://github.com/clee2000 due to causing unexpected success for functorch on master but PR is green (landrace?) https://github.com/pytorch/pytorch/actions/runs/3227306657/jobs/5282180524 https://hud.pytorch.org/pytorch/pytorch/commit/a56a8c0fc0251bb4cd24b366a290db2e4beea747
@anjali411 anjali411 reopened this Oct 14, 2022
@github-actions github-actions bot requested review from albanD and ezyang October 14, 2022 17:46
anjali411 added a commit that referenced this pull request Oct 17, 2022
@anjali411
Add meta support for _adaptive_avg_pool2d_backward (#86359)
587a1a6 
This reverts commit 3edf79d.

[ghstack-poisoned]
@anjali411 anjali411 mentioned this pull request Oct 17, 2022
Closed
anjali411 added a commit that referenced this pull request Oct 17, 2022
@anjali411
Update on "Add meta support for _adaptive_avg_pool2d_backward (#86359)"
ddb5ef6 
This reverts commit 3edf79d.

Reland of #86359

[ghstack-poisoned]
anjali411 added a commit that referenced this pull request Oct 17, 2022
@anjali411
Add meta support for _adaptive_avg_pool2d_backward (#86359)
8a08f7e 
This reverts commit 3edf79d.

ghstack-source-id: 79fb4fc
Pull Request resolved: #87074
@anjali411 anjali411 closed this Oct 17, 2022
pytorchmergebot pushed a commit that referenced this pull request Oct 17, 2022
@anjali411 @pytorchmergebot
Add meta support for _adaptive_avg_pool2d_backward (#86359) (#87074)
6351220 
This reverts commit 3edf79d.

Reland of #86359
Pull Request resolved: #87074
Approved by: https://github.com/ezyang
@facebook-github-bot facebook-github-bot deleted the gh/anjali411/208/head branch June 8, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@Chillee Chillee Awaiting requested review from Chillee

@Krovatkin Krovatkin Awaiting requested review from Krovatkin

@miladm miladm Awaiting requested review from miladm

@wconstab wconstab Awaiting requested review from wconstab

@albanD albanD Awaiting requested review from albanD

@ezyang ezyang Awaiting requested review from ezyang

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged Reverted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@anjali411 @pytorchmergebot @clee2000 @ezyang @albanD @facebook-github-bot