[FSDP] assert to runtime error #86336
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
rohan-varma
requested review from
H-Huang,
awgu,
kwen2501,
mingzhe09088,
mrshenli,
pritamdamania87 and
zhaojuanmao
as code owners
pytorch-bot
bot
added
the
release notes: distributed (sharded)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86336
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit bdd5056: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
oncall: distributed
Prefer raising an error over `assert` which should mostly to indicate a developer bug, but user can cause this error path. [ghstack-poisoned]
awgu
approved these changes
Oct 5, 2022
| assert self._is_root, "`no_sync()` on inner FSDP instances is not supported" | ||
| if not self._is_root: | ||
| raise RuntimeError( | ||
| "`no_sync()` on inner FSDP instances is not supported. Please call `no_sync()` on root FSDP module." |
Collaborator
There was a problem hiding this comment.
nit: In case you are okay with re-pushing:
Suggested change
| "`no_sync()` on inner FSDP instances is not supported. Please call `no_sync()` on root FSDP module." | |
| "`no_sync()` on inner FSDP instances is not supported. Please call `no_sync()` on the root FSDP module." |
Prefer raising an error over `assert` which should mostly to indicate a developer bug, but user can cause this error path. [ghstack-poisoned]
This was referenced Oct 6, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 7, 2022
Summary: Prefer raising an error over `assert` which should mostly to indicate a developer bug, but user can cause this error path. Pull Request resolved: #86336 Approved by: https://github.com/awgu Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/adfd8f382331adbf9cbfa14039ef3b61f2f4e10c Reviewed By: seemethere Differential Revision: D40167182 Pulled By: rohan-varma fbshipit-source-id: 3406bfb1effd4d221644cb5a1f7bb0a19ee8086b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Prefer raising an error over
assertwhich should mostly to indicate a developer bug, but user can cause this error path.