rot90() in ATen #8628

weiyangfb · 2018-06-18T22:33:31Z

Summary

fixes [feature request] rot90 like numpy.rot90 #6271
implemented torch.rot90() following numpy.rot90()

torch/_torch_docs.py

ssnl

Nice! A couple questions.

aten/src/ATen/native/TensorTransformations.cpp

ssnl

Nice! A couple questions.

aten/src/ATen/native/TensorTransformations.h

aten/src/ATen/native/TensorTransformations.cpp

aten/src/ATen/native/native_functions.yaml

aten/src/ATen/WrapDimUtils.h

ssnl

@gchanan do you want to take a brief look at the PythonArgParser change?
Other parts looks reasonable to me.

weiyangfb · 2018-06-26T18:03:43Z

@gchanan @colesbury Can I get a review on the hacky IntList parser parse_intlist_args ?

torch/csrc/utils/python_arg_parser.cpp

aten/src/ATen/WrapDimUtils.h

torch/csrc/utils/python_arg_parser.cpp

weiyangfb · 2018-07-10T15:18:58Z

@gchanan I made some changes according to comments, would you like to take a quick look?

gchanan

I didn't look at the rot function itself.

torch/csrc/utils/python_arg_parser.cpp

aten/src/ATen/WrapDimUtils.h

weiyangfb · 2018-07-18T16:31:06Z

@pytorchbot retest this please

weiyangfb · 2018-07-24T00:04:43Z

@pytorchbot retest this please

…t90 k=3; 3. TODO: add default values to args k and dims

…er.cpp

…or for x={} default args

…y tensor

facebook-github-bot

@weiyangfb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: 1. fixes #6271 2. implemented torch.rot90() following [numpy.rot90()](https://github.com/numpy/numpy/blob/6a58e25703cbecb6786faa09a04ae2ec8221348b/numpy/lib/function_base.py#L54-L138) Pull Request resolved: pytorch/pytorch#8628 Reviewed By: ezyang Differential Revision: D8987860 Pulled By: weiyangfb fbshipit-source-id: 8dac3b2a1f6d3288672977aba8b547706ce97fe9

Summary: 1. fixes pytorch#6271 2. implemented torch.rot90() following [numpy.rot90()](https://github.com/numpy/numpy/blob/6a58e25703cbecb6786faa09a04ae2ec8221348b/numpy/lib/function_base.py#L54-L138) Pull Request resolved: pytorch#8628 Reviewed By: ezyang Differential Revision: D8987860 Pulled By: weiyangfb fbshipit-source-id: 8dac3b2a1f6d3288672977aba8b547706ce97fe9

weiyangfb requested review from apaszke, colesbury, ezyang, gchanan, soumith and zdevito as code owners June 18, 2018 22:33

vishwakftw reviewed Jun 18, 2018

View reviewed changes

torch/_torch_docs.py Outdated

This comment was marked as off-topic.

Sign in to view

vishwakftw reviewed Jun 18, 2018

View reviewed changes

torch/_torch_docs.py Outdated

This comment was marked as off-topic.

Sign in to view

ssnl reviewed Jun 19, 2018

View reviewed changes

ssnl reviewed Jun 20, 2018

View reviewed changes

ssnl reviewed Jun 25, 2018

View reviewed changes

aten/src/ATen/WrapDimUtils.h Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

ssnl reviewed Jun 25, 2018

View reviewed changes

weiyangfb force-pushed the rot90 branch from a5e6d6f to b34cbdb Compare June 26, 2018 03:07

ssnl reviewed Jun 28, 2018

View reviewed changes

torch/csrc/utils/python_arg_parser.cpp Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

ssnl reviewed Jun 29, 2018

View reviewed changes

ssnl mentioned this pull request Jun 29, 2018

Speed-up multidim sum #8992

Closed

ssnl reviewed Jun 29, 2018

View reviewed changes

gchanan reviewed Jun 29, 2018

View reviewed changes

torch/csrc/utils/python_arg_parser.cpp Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

gchanan reviewed Jun 29, 2018

View reviewed changes

torch/csrc/utils/python_arg_parser.cpp Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

gchanan reviewed Jul 18, 2018

View reviewed changes

weiyangfb force-pushed the rot90 branch from 4276d7c to 6c50d07 Compare July 18, 2018 17:10

gchanan approved these changes Jul 18, 2018

View reviewed changes

weiyangfb added 4 commits July 23, 2018 19:50

added torch.rot90() to ATen

5bac6c0

nits

5e61901

support wrap_dims for negative dims in flip() and rot90()

4d914d6

1. moved wrap_dims() to WrapDimUtils.h; 2. re-arange ops order for ro…

d6ce84d

…t90 k=3; 3. TODO: add default values to args k and dims

weiyangfb added 11 commits July 23, 2018 19:52

1. addressed comments; 2. hacked an IntList parser at python_arg_pars…

b95f07f

…er.cpp

wip

e79638a

supports negative default IntList values, and addresses comments

f0c8612

add more tests in parse_intlist_args

57e309a

addresses comments

b3af2e9

1. disallow dims to < -total_dim in wrap_dims(); 2. return empty vect…

3fcb2c1

…or for x={} default args

[wip] use strtol in parse_intlist_args

d7a9a6e

addresses comments

03a27cb

nits

7686d97

Using istringstream rather than strtok, addressed comments

e5c46bf

1. modified jit default args parser; 2. added test for flip() on empt…

fd1eff5

…y tensor

weiyangfb force-pushed the rot90 branch from 4d2016d to fd1eff5 Compare July 24, 2018 03:00

weiyangfb added 3 commits July 24, 2018 15:10

jit debug

64fd306

[wip] debugging jit

427d4b9

Zachary DeVito fixed the bug in jit

0a5d9e0

facebook-github-bot reviewed Jul 25, 2018

View reviewed changes

weiyangfb changed the title ~~added torch.rot90() to ATen~~ rot90() in ATen Jul 25, 2018

facebook-github-bot closed this in 302adb7 Jul 25, 2018

weiyangfb deleted the rot90 branch August 9, 2018 14:10

ezyang added the merged label Jun 26, 2019

rot90() in ATen #8628

rot90() in ATen #8628

Uh oh!

Conversation

weiyangfb commented Jun 18, 2018

Summary

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

ssnl left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

ssnl left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

ssnl left a comment

Choose a reason for hiding this comment

Uh oh!

weiyangfb commented Jun 26, 2018

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!