Skip to content

[allocator tracing] missing GIL acquire #86254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zdevito wants to merge 1 commit into from
Closed

[allocator tracing] missing GIL acquire #86254

zdevito wants to merge 1 commit into from

Conversation

@zdevito
Copy link
Contributor

@zdevito zdevito commented Oct 5, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

Bug where the context destructor needs to hold the GIL to free the context.

@zdevito
[allocator tracing] missing GIL acquire
cf44e04 
Bug where the context destructor needs to hold the GIL to free the context.

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 5, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86254

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit cf44e04:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Oct 5, 2022
Closed
Closed
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 5, 2022
@zdevito
Copy link
Contributor Author

zdevito commented Oct 5, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 5, 2022

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

Hey @zdevito.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Oct 5, 2022
@zdevito @facebook-github-bot
[allocator tracing] missing GIL acquire (#86254) (#86254)
bcecaca 
Summary:
Bug where the context destructor needs to hold the GIL to free the context.

Pull Request resolved: #86254
Approved by: https://github.com/ezyang

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/db13049b8844f3e7a15ebd902572639c19b21fc1

Reviewed By: seemethere

Differential Revision: D40106293

fbshipit-source-id: c8079a3895f0aeffced0cbef7fd8226b0c5f3a4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zdevito @pytorchmergebot @ezyang @facebook-github-bot