Rename fromIntArrayRef to fromIntArrayRefSlow, audit call sites #86235
Conversation
Some of them are known non-negative, I've revised them accordingly. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86235
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit 7b8c306: The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
requested review from
Chillee,
Krovatkin,
albanD,
anjali411,
antoniojkim,
miladm and
wconstab
…sites" Some of them are known non-negative, I've revised them accordingly. Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]
…sites" Some of them are known non-negative, I've revised them accordingly. Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]
…sites" Some of them are known non-negative, I've revised them accordingly. Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]
…sites" Some of them are known non-negative, I've revised them accordingly. Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]
…sites" Some of them are known non-negative, I've revised them accordingly. Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]
…sites" Some of them are known non-negative, I've revised them accordingly. Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]
albanD
left a comment
albanD
left a comment
There was a problem hiding this comment.
Ho interesting. Why move everything to the "slow" name?
…sites" Some of them are known non-negative, I've revised them accordingly. Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]
|
Because it is slow, we're looping over every element of the array ref. The main point of the slow name is to deter people from repeatedly doing this conversions thinking it's fast, when it's not. |
Companion to pytorch/pytorch#86235 Signed-off-by: Edward Z. Yang <ezyang@fb.com>
…sites" Some of them are known non-negative, I've revised them accordingly. Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]
|
@pytorchbot merge |
|
@pytorchbot successfully started a merge job. Check the current status here. |
Merge failedReason: 2 additional jobs have failed, first few of them are: trunk ,trunk / linux-bionic-cuda11.7-py3.10-gcc7 / test (default, 1, 4, linux.4xlarge.nvidia.gpu) Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -f "flaky infra failures" |
|
@pytorchbot successfully started a merge job. Check the current status here. |
|
Hey @ezyang. |
* Rename to fromIntArrayRefSlow Companion to pytorch/pytorch#86235 Signed-off-by: Edward Z. Yang <ezyang@fb.com> * pin Signed-off-by: Edward Z. Yang <ezyang@fb.com> * Delete .torch_pin Signed-off-by: Edward Z. Yang <ezyang@fb.com>
…) (#86235) Summary: Some of them are known non-negative, I've revised them accordingly. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Pull Request resolved: #86235 Approved by: https://github.com/albanD Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/e8b0bea677b44206f663788e3a9d6a85b3779ed2 Reviewed By: seemethere Differential Revision: D40166995 Pulled By: seemethere fbshipit-source-id: 8956277564394e5c5584b0721307e6afbede1bd3
Stack from ghstack (oldest at bottom):
Some of them are known non-negative, I've revised them accordingly.
Signed-off-by: Edward Z. Yang ezyang@fb.com