Skip to content

Refactor _cuda_recordMemoryHistory to use pybind11 #86139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ezyang wants to merge 2 commits into from
Closed

Refactor _cuda_recordMemoryHistory to use pybind11 #86139

ezyang wants to merge 2 commits into from

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Oct 3, 2022 •
edited
Loading

@ezyang
Refactor _cuda_recordMemoryHistory to use pybind11
cb0d963 
Signed-off-by: Edward Z. Yang <ezyang@fb.com>

[ghstack-poisoned]
This was referenced Oct 3, 2022
Closed
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 3, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86139

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 430754f:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ezyang ezyang mentioned this pull request Oct 3, 2022
Closed
@ezyang ezyang requested a review from zdevito October 3, 2022 18:42
albanD
albanD approved these changes Oct 3, 2022
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any specific things that this should fix?
But sounds good.

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 3, 2022
@ezyang
Copy link
Contributor Author

ezyang commented Oct 3, 2022

It will make it a lot easier for me to add another bool in the next PR

@ezyang ezyang mentioned this pull request Oct 3, 2022
Closed
@ezyang
Update on "Refactor _cuda_recordMemoryHistory to use pybind11"
430754f 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 4, 2022

/easycla

As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details.

This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign.

facebook-github-bot pushed a commit that referenced this pull request Oct 7, 2022
@ezyang @facebook-github-bot
Refactor _cuda_recordMemoryHistory to use pybind11 (#86139) (#86139)
59f0ca6 
Summary:
Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Pull Request resolved: #86139
Approved by: https://github.com/albanD

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/97d6b5bbf89172ad94143f4ce4a9b9a3a4d7b744

Reviewed By: seemethere

Differential Revision: D40167036

Pulled By: seemethere

fbshipit-source-id: 46cde50c25f03b95378e98f4cb4407328cd5417d
@facebook-github-bot facebook-github-bot deleted the gh/ezyang/1449/head branch June 8, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@anjali411 anjali411 Awaiting requested review from anjali411

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@Chillee Chillee Awaiting requested review from Chillee

@Krovatkin Krovatkin Awaiting requested review from Krovatkin

@miladm miladm Awaiting requested review from miladm

@wconstab wconstab Awaiting requested review from wconstab

@zdevito zdevito Awaiting requested review from zdevito

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ezyang @facebook-github-bot @albanD