Skip to content

Symintified all functions, not including factory functions #86078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ezyang wants to merge 10 commits into from
Closed

Symintified all functions, not including factory functions #86078

ezyang wants to merge 10 commits into from

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Oct 2, 2022 •
edited
Loading

@ezyang
Symintified all functions, not including factory functions
7fd5701 
Signed-off-by: Edward Z. Yang <ezyang@fb.com>

[ghstack-poisoned]
@ezyang ezyang mentioned this pull request Oct 2, 2022
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 2, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86078

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 Failures

As of commit c36aa71:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ezyang ezyang mentioned this pull request Oct 2, 2022
Closed
@ezyang
Update on "Symintified all functions, not including factory functions"
2206f18 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
@ezyang ezyang mentioned this pull request Oct 2, 2022
Closed
@ezyang
Update on "Symintified all functions, not including factory functions"
da49079 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
@ezyang
Update on "Symintified all functions, not including factory functions"
03951b0 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
@ezyang ezyang mentioned this pull request Oct 3, 2022
Closed
@ezyang
Update on "Symintified all functions, not including factory functions"
32b6ad5 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
@ezyang ezyang mentioned this pull request Oct 3, 2022
Closed
@ezyang ezyang requested a review from a team as a code owner October 3, 2022 01:00
@ezyang
Update on "Symintified all functions, not including factory functions"
3db3f30 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
This was referenced Oct 3, 2022
Closed
Closed
@pytorch-bot pytorch-bot bot added the release notes: releng release notes category label Oct 3, 2022
@ezyang
Update on "Symintified all functions, not including factory functions"
733ccae 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
@ezyang ezyang mentioned this pull request Oct 3, 2022
Closed
@Chillee
Copy link
Collaborator

Chillee commented Oct 3, 2022

Well... it passes tests?

Chillee
Chillee approved these changes Oct 3, 2022
View reviewed changes
Copy link
Collaborator

@Chillee Chillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprisingly, it looks like it passes tests? Approving so it can run the land-time tests.

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 3, 2022
albanD
albanD approved these changes Oct 3, 2022
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@albanD albanD added the ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR label Oct 3, 2022
@ezyang
Update on "Symintified all functions, not including factory functions"
8b4f40e 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
@ezyang ezyang mentioned this pull request Oct 3, 2022
Closed
@ezyang
Update on "Symintified all functions, not including factory functions"
59bc749 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
@ezyang
Update on "Symintified all functions, not including factory functions"
c36aa71 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Oct 3, 2022
@ezyang
Symintified all functions, not including factory functions
cbedeed 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

ghstack-source-id: d982c3e
Pull Request resolved: #86078
This was referenced Oct 3, 2022
Closed
Closed
@ezyang
Copy link
Contributor Author

ezyang commented Oct 3, 2022

@pytorchbot merge -f "infra failure is irrelevant"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 3, 2022

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the force (-f) flag. This means your change will be merged immediately, bypassing any CI checks (ETA: 1-5 minutes). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2022

Hey @ezyang.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@facebook-github-bot facebook-github-bot deleted the gh/ezyang/1437/head branch June 8, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@Chillee Chillee Chillee approved these changes

@soulitzer soulitzer Awaiting requested review from soulitzer

@anjali411 anjali411 Awaiting requested review from anjali411

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@Krovatkin Krovatkin Awaiting requested review from Krovatkin

@miladm miladm Awaiting requested review from miladm

@wconstab wconstab Awaiting requested review from wconstab

Assignees

No one assigned

Labels

ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged release notes: releng release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ezyang @Chillee @pytorchmergebot @albanD @facebook-github-bot