Skip to content

[ao] fixing public v private for fx.backend_config_utils.py #86037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
HDCharles wants to merge 12 commits into from
Closed

[ao] fixing public v private for fx.backend_config_utils.py #86037

HDCharles wants to merge 12 commits into from

Conversation

@HDCharles
Copy link
Contributor

@HDCharles HDCharles commented Sep 30, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

Summary: just added a missing function to all

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

@HDCharles
[ao] fixing public v private for fx.backend_config_utils.py
05b0ba2 
Summary: just added a missing function to __all__

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@HDCharles HDCharles mentioned this pull request Sep 30, 2022
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 30, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86037

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f674936:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@HDCharles HDCharles mentioned this pull request Sep 30, 2022
Closed
This was referenced Sep 30, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
HDCharles added a commit that referenced this pull request Sep 30, 2022
@HDCharles
[ao] fixing public v private for fx.backend_config_utils.py
d739148 
Summary: just added a missing function to __all__

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: f3ff071
Pull Request resolved: #86037
@albanD albanD removed their request for review October 3, 2022 15:06
@HDCharles
Update on "[ao] fixing public v private for fx.backend_config_utils.py"
1a5e422 
Summary: just added a missing function to __all__

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
HDCharles added a commit that referenced this pull request Oct 3, 2022
@HDCharles
[ao] fixing public v private for fx.backend_config_utils.py
2dd97f6 
Summary: just added a missing function to __all__

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: ef1d489
Pull Request resolved: #86037
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 4, 2022

/easycla

As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details.

This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign.

@HDCharles
Update on "[ao] fixing public v private for fx.backend_config_utils.py"
683b3bb 
Summary: just added a missing function to __all__

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
jerryzh168
jerryzh168 reviewed Oct 5, 2022
View reviewed changes
torch/ao/quantization/fx/backend_config_utils.py
get_pattern_to_quantize_handlers.__module__ = "torch.ao.quantization.fx.backend_config_utils"

__all__ = [
"get_quantize_handler_cls",
Copy link
Contributor

@jerryzh168 jerryzh168 Oct 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a helper function I think, we can probably make it private, should probably be in a separate PR though

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 5, 2022
@HDCharles
Copy link
Contributor Author

HDCharles commented Oct 5, 2022

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 5, 2022

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 5, 2022

Merge failed

Reason: The following mandatory check(s) failed (Rule superuser):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@HDCharles
Update on "[ao] fixing public v private for fx.backend_config_utils.py"
9485baf 
Summary: just added a missing function to __all__

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
HDCharles added a commit that referenced this pull request Oct 5, 2022
@HDCharles
[ao] fixing public v private for fx.backend_config_utils.py
06b4794 
Summary: just added a missing function to __all__

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 618a66b
Pull Request resolved: #86037
@HDCharles
Update on "[ao] fixing public v private for fx.backend_config_utils.py"
a8b1c3b 
Summary: just added a missing function to __all__

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@HDCharles
Update on "[ao] fixing public v private for fx.backend_config_utils.py"
29500e0 
Summary: just added a missing function to __all__

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@HDCharles
Update on "[ao] fixing public v private for fx.backend_config_utils.py"
63256d8 
Summary: just added a missing function to __all__

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
HDCharles added a commit that referenced this pull request Oct 6, 2022
@HDCharles
[ao] fixing public v private for fx.backend_config_utils.py
dc9635f 
Summary: just added a missing function to __all__

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 4f83687
Pull Request resolved: #86037
@HDCharles
Update on "[ao] fixing public v private for fx.backend_config_utils.py"
6ef1400 
Summary: just added a missing function to __all__

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
HDCharles added a commit that referenced this pull request Oct 7, 2022
@HDCharles
[ao] fixing public v private for fx.backend_config_utils.py
115f7f5 
Summary: just added a missing function to __all__

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 9517f5b
Pull Request resolved: #86037
@HDCharles
Update on "[ao] fixing public v private for fx.backend_config_utils.py"
ce4624a 
Summary: just added a missing function to __all__

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
HDCharles added a commit that referenced this pull request Oct 10, 2022
@HDCharles
[ao] fixing public v private for fx.backend_config_utils.py
e77662a 
Summary: just added a missing function to __all__

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: ad475e0
Pull Request resolved: #86037
@HDCharles
Update on "[ao] fixing public v private for fx.backend_config_utils.py"
881f021 
Summary: just added a missing function to __all__

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
HDCharles added a commit that referenced this pull request Oct 12, 2022
@HDCharles
[ao] fixing public v private for fx.backend_config_utils.py
1dba1a7 
Summary: just added a missing function to __all__

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 96b4dd1
Pull Request resolved: #86037
@HDCharles
Update on "[ao] fixing public v private for fx.backend_config_utils.py"
b6851c8 
Summary: just added a missing function to __all__

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
HDCharles added a commit that referenced this pull request Oct 12, 2022
@HDCharles
[ao] fixing public v private for fx.backend_config_utils.py
70ce01f 
Summary: just added a missing function to __all__

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: af8db51
Pull Request resolved: #86037
@HDCharles
Update on "[ao] fixing public v private for fx.backend_config_utils.py"
f674936 
Summary: just added a missing function to __all__

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
HDCharles added a commit that referenced this pull request Oct 13, 2022
@HDCharles
[ao] fixing public v private for fx.backend_config_utils.py
5093fa9 
Summary: just added a missing function to __all__

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: f78696c
Pull Request resolved: #86037
@HDCharles
Copy link
Contributor Author

HDCharles commented Oct 13, 2022

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 13, 2022

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/HDCharles/117/head branch June 8, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerryzh168 jerryzh168 jerryzh168 approved these changes

@vkuzo vkuzo Awaiting requested review from vkuzo

@anjali411 anjali411 Awaiting requested review from anjali411

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request cla signed fx Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@HDCharles @facebook-github-bot @pytorchmergebot @jerryzh168