[ao] fixing public v private for fx.pattern_utils.py #86033
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: added __all__, one issue with QuantizeHandler is that since its defined as 'Any' it can't be set as a public module although it should be, i've set it to private here but when the circular dependency gets fixed, it will probably be removed. Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86033
Note: Links to docs will display an error until the docs builds have been completed. ✅ No Failures, 1 PendingAs of commit 49ebcdd: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Sep 30, 2022
This was referenced Sep 30, 2022
This was referenced Sep 30, 2022
Summary: added __all__, one issue with QuantizeHandler is that since its defined as 'Any' it can't be set as a public module although it should be, i've set it to private here but when the circular dependency gets fixed, it will probably be removed. Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Contributor
|
/easycla As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details. This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign. |
HDCharles
added
topic: not user facing
Summary: added __all__, one issue with QuantizeHandler is that since its defined as 'Any' it can't be set as a public module although it should be, i've set it to private here but when the circular dependency gets fixed, it will probably be removed. Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
jerryzh168
approved these changes
Oct 5, 2022
Summary: added __all__, one issue with QuantizeHandler is that since its defined as 'Any' it can't be set as a public module although it should be, i've set it to private here but when the circular dependency gets fixed, it will probably be removed. Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: added __all__, one issue with QuantizeHandler is that since its defined as 'Any' it can't be set as a public module although it should be, i've set it to private here but when the circular dependency gets fixed, it will probably be removed. Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: added __all__, one issue with QuantizeHandler is that since its defined as 'Any' it can't be set as a public module although it should be, i've set it to private here but when the circular dependency gets fixed, it will probably be removed. Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: added __all__, one issue with QuantizeHandler is that since its defined as 'Any' it can't be set as a public module although it should be, i've set it to private here but when the circular dependency gets fixed, it will probably be removed. Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: added __all__, one issue with QuantizeHandler is that since its defined as 'Any' it can't be set as a public module although it should be, i've set it to private here but when the circular dependency gets fixed, it will probably be removed. Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: added __all__, one issue with QuantizeHandler is that since its defined as 'Any' it can't be set as a public module although it should be, i've set it to private here but when the circular dependency gets fixed, it will probably be removed. Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: added __all__, one issue with QuantizeHandler is that since its defined as 'Any' it can't be set as a public module although it should be, i've set it to private here but when the circular dependency gets fixed, it will probably be removed. Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: added __all__, one issue with QuantizeHandler is that since its defined as 'Any' it can't be set as a public module although it should be, i've set it to private here but when the circular dependency gets fixed, it will probably be removed. Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Contributor
Author
|
@pytorchmergebot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: added all, one issue with QuantizeHandler is that since its
defined as 'Any' it can't be set as a public module although it should
be, i've set it to private here but when the circular dependency gets
fixed, it will probably be removed.
Test Plan: python test/test_public_bindings.py
Reviewers:
Subscribers:
Tasks:
Tags: