[ao] fixing public v private for quantization_mappings.py #86025
Conversation
Summary: no significant changes, just added __all__ Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86025
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5a6197a: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| "DEFAULT_REFERENCE_STATIC_QUANT_MODULE_MAPPINGS", | ||
| "DEFAULT_STATIC_QUANT_MODULE_MAPPINGS", | ||
| "DEFAULT_QAT_MODULE_MAPPINGS", | ||
| "DEFAULT_DYNAMIC_QUANT_MODULE_MAPPINGS", | ||
| "DEFAULT_FLOAT_TO_QUANTIZED_OPERATOR_MAPPINGS", | ||
| "DEFAULT_MODULE_TO_ACT_POST_PROCESS", | ||
| "DEFAULT_STATIC_SPARSE_QUANT_MODULE_MAPPINGS", | ||
| "DEFAULT_DYNAMIC_SPARSE_QUANT_MODULE_MAPPINGS", |
There was a problem hiding this comment.
these probably should be implementation details since we have getter functions, maybe add a TODO to remove them from public apis?
There was a problem hiding this comment.
yeah, will talk about it Thursday
Summary: no significant changes, just added __all__ Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
|
/easycla As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details. This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign. |
HDCharles
added
topic: not user facing
Summary: no significant changes, just added __all__ Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
|
@pytorchmergebot merge |
|
@pytorchbot successfully started a merge job. Check the current status here. |
…86025) Summary: no significant changes, just added __all__ Pull Request resolved: #86025 Approved by: https://github.com/jerryzh168 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/73777d8a2bed1c8878a1858ab8241f5acf0d022b Test plan from GitHub: python test/test_public_bindings.py Reviewed By: seemethere Differential Revision: D40166974 Pulled By: seemethere fbshipit-source-id: 1cb60fdff94fa2c47ba451dd00997acb3d036d7e
Summary: no significant changes, just added __all__ Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 30c1416 Pull Request resolved: pytorch/pytorch#86025
Stack from ghstack (oldest at bottom):
Summary: no significant changes, just added all
Test Plan: python test/test_public_bindings.py
Reviewers:
Subscribers:
Tasks:
Tags: