-
Notifications
You must be signed in to change notification settings - Fork 26.3k
[8/N] [Dispatchable Collectives] Update allgather with CPU / CUDA implementations #84423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…lementations [ghstack-poisoned]
🔗 Helpful links
❌ 2 New FailuresAs of commit 36137b9 (more details on the Dr. CI page): Expand to see more
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
… / CUDA implementations " [ghstack-poisoned]
… / CUDA implementations " [ghstack-poisoned]
… / CUDA implementations " [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/84423
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 02a23f9: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
… / CUDA implementations " [ghstack-poisoned]
… / CUDA implementations " [ghstack-poisoned]
… / CUDA implementations " [ghstack-poisoned]
… / CUDA implementations " [ghstack-poisoned]
kwen2501
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
… / CUDA implementations " [ghstack-poisoned]
… / CUDA implementations " [ghstack-poisoned]
|
@H-Huang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
/easycla As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details. This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign. |
… / CUDA implementations " ### Changes - Updates for the allgather collective ### Context #86225 Differential Revision: [D40044549](https://our.internmc.facebook.com/intern/diff/D40044549) [ghstack-poisoned]
|
@H-Huang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
… / CUDA implementations " ### Changes - Updates for the allgather collective ### Context #86225 Differential Revision: [D40044549](https://our.internmc.facebook.com/intern/diff/D40044549) [ghstack-poisoned]
… / CUDA implementations " ### Changes - Updates for the allgather collective ### Context #86225 Differential Revision: [D40044549](https://our.internmc.facebook.com/intern/diff/D40044549) [ghstack-poisoned]
|
@H-Huang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@pytorchbot merge -f "Ran ciflow/trunk and all tests pass, using force to skip meta internal-only check since the files are the same as internal" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: This PR has internal changes and must be landed via Phabricator Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -f "Ran ciflow/trunk and all tests pass, using force to skip meta internal-only check since the files are the same as internal" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
Hey @H-Huang. |
Stack from ghstack:
Changes
Context
#86225