Skip to content

[7/N] [Dispatchable Collectives] Update reduce with CPU / CUDA implementations #83916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
H-Huang wants to merge 19 commits into from
Closed

[7/N] [Dispatchable Collectives] Update reduce with CPU / CUDA implementations #83916

H-Huang wants to merge 19 commits into from

Conversation

@H-Huang
Copy link
Member

@H-Huang H-Huang commented Aug 23, 2022 •
edited
Loading

Stack from ghstack:

Changes

  • Updates for the reduce collective

Context

#86225

This was referenced Aug 23, 2022
Closed
Closed
Closed
Closed
This was referenced Aug 23, 2022
Closed
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 23, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (23 Pending)

As of commit 55a8c51 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Aug 23, 2022
@H-Huang H-Huang requested a review from kwen2501 August 23, 2022 16:20
@H-Huang H-Huang added module: c10d Issues/PRs related to collective communications and process groups release notes: distributed (c10d) release notes category topic: new features topic category labels Aug 23, 2022
H-Huang added a commit that referenced this pull request Aug 23, 2022
@H-Huang
[7/N] [Dispatchable Collectives] Update reduce with CPU / CUDA implem…
d0d7ac4 
…entations

ghstack-source-id: e4fe265
Pull Request resolved: #83916
H-Huang added a commit that referenced this pull request Aug 31, 2022
@H-Huang
[7/N] [Dispatchable Collectives] Update reduce with CPU / CUDA implem…
f35364b 
…entations

ghstack-source-id: 5dbc7ba
Pull Request resolved: #83916
@H-Huang H-Huang mentioned this pull request Oct 3, 2022
Closed
@H-Huang
Copy link
Member Author

H-Huang commented Oct 3, 2022

@H-Huang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 4, 2022

/easycla

As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details.

This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign.

@H-Huang
Update on "[7/N] [Dispatchable Collectives] Update reduce with CPU / …
6a319f3 
…CUDA implementations"


### Changes
- Updates for the reduce collective

### Context
#86225

Differential Revision: [D40044551](https://our.internmc.facebook.com/intern/diff/D40044551)

[ghstack-poisoned]
@H-Huang H-Huang mentioned this pull request Oct 6, 2022
Closed
@H-Huang
Copy link
Member Author

H-Huang commented Oct 6, 2022

@H-Huang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@H-Huang
Update on "[7/N] [Dispatchable Collectives] Update reduce with CPU / …
5ddd2b8 
…CUDA implementations"


### Changes
- Updates for the reduce collective

### Context
#86225

Differential Revision: [D40044551](https://our.internmc.facebook.com/intern/diff/D40044551)

[ghstack-poisoned]
This was referenced Oct 6, 2022
Closed
Closed
Closed
@H-Huang
Update on "[7/N] [Dispatchable Collectives] Update reduce with CPU / …
33b6259 
…CUDA implementations"


### Changes
- Updates for the reduce collective

### Context
#86225

Differential Revision: [D40044551](https://our.internmc.facebook.com/intern/diff/D40044551)

[ghstack-poisoned]
@H-Huang
Copy link
Member Author

H-Huang commented Oct 7, 2022

@H-Huang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@H-Huang
Copy link
Member Author

H-Huang commented Oct 7, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 7, 2022

Merge failed

Reason: This PR has internal changes and must be landed via Phabricator

Details for Dev Infra team Raised by workflow job

@H-Huang
Copy link
Member Author

H-Huang commented Oct 7, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 7, 2022

Merge failed

Reason: This PR has internal changes and must be landed via Phabricator

Details for Dev Infra team Raised by workflow job

@H-Huang
Copy link
Member Author

H-Huang commented Oct 7, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 7, 2022

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 7, 2022

Merge failed

Reason: 1 additional jobs have failed, first few of them are: Meta Internal-Only Changes Check

Details for Dev Infra team Raised by workflow job

@H-Huang
Copy link
Member Author

H-Huang commented Oct 10, 2022

@pytorchbot merge -f "skip meta internal-only check, the files are the same"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 10, 2022

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@H-Huang H-Huang mentioned this pull request Oct 17, 2022
Closed
H-Huang added a commit that referenced this pull request Oct 31, 2022
@H-Huang
Update on "[11/N] Update all_to_all with CPU/CUDA implementations"
aa2a0fc 
* #83916 [7/N] [Dispatchable Collectives] Update reduce with CPU / CUDA implementations

[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this pull request Nov 1, 2022
@H-Huang @pytorchmergebot
[11/N] Update all_to_all with CPU/CUDA implementations (#86407)
81f74ee 
* #83916 [7/N] [Dispatchable Collectives] Update reduce with CPU / CUDA implementations
Pull Request resolved: #86407
Approved by: https://github.com/kwen2501
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022
@H-Huang @kulinseth
[11/N] Update all_to_all with CPU/CUDA implementations (pytorch#86407)
5b155c6 
* pytorch#83916 [7/N] [Dispatchable Collectives] Update reduce with CPU / CUDA implementations
Pull Request resolved: pytorch#86407
Approved by: https://github.com/kwen2501
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@H-Huang @kulinseth
[11/N] Update all_to_all with CPU/CUDA implementations (pytorch#86407)
19a17c1 
* pytorch#83916 [7/N] [Dispatchable Collectives] Update reduce with CPU / CUDA implementations
Pull Request resolved: pytorch#86407
Approved by: https://github.com/kwen2501
@facebook-github-bot facebook-github-bot deleted the gh/H-Huang/79/head branch June 8, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kwen2501 kwen2501 kwen2501 approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@pritamdamania87 pritamdamania87 Awaiting requested review from pritamdamania87

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@awgu awgu Awaiting requested review from awgu

@mingzhe09088 mingzhe09088 Awaiting requested review from mingzhe09088

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged module: c10d Issues/PRs related to collective communications and process groups oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (c10d) release notes category topic: new features topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@H-Huang @facebook-github-bot @pytorchmergebot @kwen2501