Skip to content

[6/N] [Dispatchable Collectives] Update recv with CPU / CUDA implementations #83876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
H-Huang wants to merge 15 commits into from
Closed

[6/N] [Dispatchable Collectives] Update recv with CPU / CUDA implementations #83876

H-Huang wants to merge 15 commits into from

Conversation

@H-Huang
Copy link
Member

@H-Huang H-Huang commented Aug 22, 2022 •
edited
Loading

Stack from ghstack:

Changes

  • Updates for the recv collective

Context

#86225

Differential Revision: D40044552

This was referenced Aug 22, 2022
Closed
Closed
Closed
This was referenced Aug 22, 2022
Closed
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 22, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 5d23e1d (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Aug 22, 2022
H-Huang added a commit that referenced this pull request Aug 22, 2022
@H-Huang
[6/N] [Dispatchable Collectives] Update recv with CPU / CUDA implemen…
23a5fd0 
…tations

ghstack-source-id: 6c91a29
Pull Request resolved: #83876
H-Huang added a commit that referenced this pull request Aug 23, 2022
@H-Huang
[6/N] [Dispatchable Collectives] Update recv with CPU / CUDA implemen…
f8935da 
…tations

ghstack-source-id: 5fa93a9
Pull Request resolved: #83876
@H-Huang H-Huang mentioned this pull request Aug 23, 2022
Closed
@H-Huang H-Huang requested a review from kwen2501 August 23, 2022 16:20
@H-Huang H-Huang added module: c10d Issues/PRs related to collective communications and process groups release notes: distributed (c10d) release notes category topic: new features topic category labels Aug 23, 2022
@H-Huang H-Huang mentioned this pull request Sep 1, 2022
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 13, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/83876

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Failures

As of commit c768ee5:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

kwen2501
kwen2501 approved these changes Sep 30, 2022
View reviewed changes
Copy link
Collaborator

@kwen2501 kwen2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 30, 2022
@H-Huang H-Huang mentioned this pull request Oct 3, 2022
Closed
@H-Huang
Copy link
Member Author

H-Huang commented Oct 3, 2022

@H-Huang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 4, 2022

/easycla

As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details.

This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign.

@H-Huang
Copy link
Member Author

H-Huang commented Oct 4, 2022

@pytorchbot merge -f "I have checked the OSS CI job failures and they are unrelated, internal jobs are green as well"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 4, 2022

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the force (-f) flag. This means your change will be merged immediately, bypassing any CI checks (ETA: 1-5 minutes). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

Rick0317 pushed a commit to Rick0317/pytorch that referenced this pull request Oct 18, 2022
@H-Huang
[6/N] [Dispatchable Collectives] Update recv with CPU / CUDA implemen…
101c302 
…tations

ghstack-source-id: 2a589c6
Pull Request resolved: pytorch/pytorch#83876
@facebook-github-bot facebook-github-bot deleted the gh/H-Huang/78/head branch June 8, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kwen2501 kwen2501 kwen2501 approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@pritamdamania87 pritamdamania87 Awaiting requested review from pritamdamania87

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@awgu awgu Awaiting requested review from awgu

@mingzhe09088 mingzhe09088 Awaiting requested review from mingzhe09088

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged module: c10d Issues/PRs related to collective communications and process groups oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (c10d) release notes category topic: new features topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@H-Huang @facebook-github-bot @pytorchmergebot @kwen2501