Skip to content

Conversation

@kit1980
Copy link
Contributor

@kit1980 kit1980 commented Aug 12, 2022

No description provided.

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 12, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/83359

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures, 11 Pending

As of commit d31710c:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added cla signed oncall: jit Add this issue/PR to JIT oncall triage queue labels Aug 12, 2022
@kit1980 kit1980 added better-engineering Relatively self-contained tasks for better engineering contributors todo-elimination labels Aug 12, 2022
@kit1980 kit1980 requested a review from a team August 12, 2022 23:53
@kit1980
Copy link
Contributor Author

kit1980 commented Aug 13, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here and land check progress here.
The merge job was triggered with the land checks (-l) flag. If you did not specify this flag yourself, you are likely enrolled in the land checks rollout. This means that your change will be merged once all checks on your PR and the land checks have passed (ETA 4 Hours). If you need to coordinate lands between different changes and cannot risk a land race, please add the ciflow/trunk label to your PR and wait for signal to complete, and then land your changes in proper order. Having trunk, pull, and Lint pre-run on a PR will bypass land checks and the ETA should be immediate. If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

pytorchmergebot pushed a commit that referenced this pull request Aug 13, 2022
@github-actions
Copy link
Contributor

Hey @kit1980.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Aug 15, 2022
Summary:
Pull Request resolved: #83359
Approved by: https://github.com/huydhn

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/bb1e3d8008fc0e40133a3b08bcfb598cd084897b

Reviewed By: atalman

Differential Revision: D38704948

Pulled By: kit1980

fbshipit-source-id: 9520d5ef4d85544553aa2e1d2ed4715c1469f30c
@github-actions github-actions bot deleted the sdym/todo-test_module_interface.py branch February 19, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

better-engineering Relatively self-contained tasks for better engineering contributors cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants