Skip to content

Conversation

@ssnl
Copy link
Collaborator

@ssnl ssnl commented Jun 6, 2018

  1. Fix broadcast copying device[0] tensor when not using NCCL
  2. Avoids potential extra copy in flatten_dense_tensors

@ezyang
Copy link
Contributor

ezyang commented Jun 7, 2018

23:50:46 ======================================================================
23:50:46 FAIL: test_broadcast_coalesced (__main__.TestCuda)
23:50:46 ----------------------------------------------------------------------
23:50:46 Traceback (most recent call last):
23:50:46   File "/var/lib/jenkins/workspace/test/common.py", line 213, in wrapper
23:50:46     method(*args, **kwargs)
23:50:46   File "test_cuda.py", line 905, in test_broadcast_coalesced
23:50:46     self._test_broadcast_coalesced(self, tensors, num_bytes * 5 // 2)
23:50:46   File "test_cuda.py", line 876, in _test_broadcast_coalesced
23:50:46     self.assertEqual(bt.get_device(), 1)
23:50:46   File "/var/lib/jenkins/workspace/test/common.py", line 325, in assertEqual
23:50:46     super(TestCase, self).assertLessEqual(abs(x - y), prec, message)
23:50:46 AssertionError: 1 not less than or equal to 1e-05
23:50:46 

This comment was marked as off-topic.

This comment was marked as off-topic.

apaszke
apaszke previously requested changes Jun 7, 2018

This comment was marked as off-topic.

@ssnl ssnl force-pushed the broadcast_no_nccl branch from 23c25eb to 4afaa6a Compare June 7, 2018 17:18
@ssnl
Copy link
Collaborator Author

ssnl commented Jun 7, 2018

@pytorchbot retest this please

@ssnl
Copy link
Collaborator Author

ssnl commented Jun 14, 2018

can I get a review on this please?

@ssnl
Copy link
Collaborator Author

ssnl commented Jun 15, 2018

@apaszke can you take a look at this when you have time?

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

@ssnl ssnl force-pushed the broadcast_no_nccl branch from daf1740 to 3eca907 Compare June 18, 2018 17:13
@ssnl
Copy link
Collaborator Author

ssnl commented Jun 18, 2018

Let me know how this looks to you. @apaszke

@ssnl ssnl merged commit 2bf8b70 into pytorch:master Jun 19, 2018
@ssnl ssnl deleted the broadcast_no_nccl branch June 19, 2018 20:34
@ezyang
Copy link
Contributor

ezyang commented Jun 22, 2018

I notice there was no test added for this

@ssnl
Copy link
Collaborator Author

ssnl commented Jun 22, 2018

adding one soon @ezyang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants