Skip to content

Fix scalar check for sparse tensors. #8197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zou3519 merged 2 commits into from
Jun 6, 2018
Merged

Fix scalar check for sparse tensors. #8197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05ec1c9
Fix scalar check for sparse tensors.
zou3519 Jun 6, 2018
1e9b346
Fix typos
zou3519 Jun 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aten/src/ATen/Declarations.cwrap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3885,7 +3885,7 @@
aten_custom_call: |
if (self_->isScalar()) {
// Empty tensor
return self_->type().toScalarType(kLong).tensor({0});
return toBackend(toDense(backend())).toScalarType(kLong).tensor({0});
}
]]

Expand Down
6 changes: 6 additions & 0 deletions test/test_sparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -910,6 +910,12 @@ def test_factory_size_check(self):
with self.assertRaisesRegex(RuntimeError, "values and sizes are inconsistent"):
self.SparseTensor(indices, values, sizes)

def test_factory_empty_indices(self):
device = 'cuda' if self.is_cuda else 'cpu'
tensor = torch.sparse_coo_tensor([], [], torch.Size([]), device=device)
expected_indices = torch.tensor([], dtype=torch.long, device=device)
self.assertEqual(tensor._indices(), expected_indices)

@cpu_only
def test_factory_type_inference(self):
t = torch.sparse_coo_tensor(torch.tensor(([0], [2])), torch.tensor([1.], dtype=torch.float32))
Expand Down