Remove overload at::frobenius_norm(const Tensor&) #81762
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is an auxiliary function for `torch.norm`. This particular overload was not even used or tested. I hope it's not used internally either. If it is, we can simply drop this PR [ghstack-poisoned]
lezcano
requested review from
IvanYashchuk,
bdhirsh and
nikitaved
as code owners
This was referenced Jul 20, 2022
Contributor
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 5cf2f24 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
lezcano
requested review from
ngimel
and removed request for
IvanYashchuk,
bdhirsh and
nikitaved
This function is an auxiliary function for `torch.norm`. This particular overload was not even used or tested. I hope it's not used internally either. If it is, we can simply drop this PR [ghstack-poisoned]
This function is an auxiliary function for `torch.norm`. This particular overload was not even used or tested. I hope it's not used internally either. If it is, we can simply drop this PR [ghstack-poisoned]
This function is an auxiliary function for `torch.norm`. This particular overload was not even used or tested. I hope it's not used internally either. If it is, we can simply drop this PR [ghstack-poisoned]
This function is an auxiliary function for `torch.norm`. This particular overload was not even used or tested. I hope it's not used internally either. If it is, we can simply drop this PR [ghstack-poisoned]
This function is an auxiliary function for `torch.norm`. This particular overload was not even used or tested. I hope it's not used internally either. If it is, we can simply drop this PR [ghstack-poisoned]
This function is an auxiliary function for `torch.norm`. This particular overload was not even used or tested. I hope it's not used internally either. If it is, we can simply drop this PR [ghstack-poisoned]
This function is an auxiliary function for `torch.norm`. This particular overload was not even used or tested. I hope it's not used internally either. If it is, we can simply drop this PR [ghstack-poisoned]
This function is an auxiliary function for `torch.norm`. This particular overload was not even used or tested. I hope it's not used internally either. If it is, we can simply drop this PR [ghstack-poisoned]
This function is an auxiliary function for `torch.norm`. This particular overload was not even used or tested. I hope it's not used internally either. If it is, we can simply drop this PR [ghstack-poisoned]
This function is an auxiliary function for `torch.norm`. This particular overload was not even used or tested. I hope it's not used internally either. If it is, we can simply drop this PR [ghstack-poisoned]
This function is an auxiliary function for `torch.norm`. This particular overload was not even used or tested. I hope it's not used internally either. If it is, we can simply drop this PR [ghstack-poisoned]
This function is an auxiliary function for `torch.norm`. This particular overload was not even used or tested. I hope it's not used internally either. If it is, we can simply drop this PR [ghstack-poisoned]
This function is an auxiliary function for `torch.norm`. This particular overload was not even used or tested. I hope it's not used internally either. If it is, we can simply drop this PR [ghstack-poisoned]
This function is an auxiliary function for `torch.norm`. This particular overload was not even used or tested. I hope it's not used internally either. If it is, we can simply drop this PR [ghstack-poisoned]
lezcano
added a commit
to pytorch/xla
that referenced
this pull request
Sep 6, 2022
[As per title](pytorch/pytorch#81762) [ghstack-poisoned]
This function is an auxiliary function for `torch.norm`. This particular overload was not even used or tested. I hope it's not used internally either. If it is, we can simply drop this PR [ghstack-poisoned]
This function is an auxiliary function for `torch.norm`. This particular overload was not even used or tested. I hope it's not used internally either. If it is, we can simply drop this PR [ghstack-poisoned]
This function is an auxiliary function for `torch.norm`. This particular overload was not even used or tested. I hope it's not used internally either. If it is, we can simply drop this PR [ghstack-poisoned]
This function is an auxiliary function for `torch.norm`. This particular overload was not even used or tested. I hope it's not used internally either. If it is, we can simply drop this PR [ghstack-poisoned]
This function is an auxiliary function for `torch.norm`. This particular overload was not even used or tested. I hope it's not used internally either. If it is, we can simply drop this PR [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/81762
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 FailuresAs of commit 551192f: NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on master:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This function is an auxiliary function for `torch.norm`. This particular overload was not even used or tested. I hope it's not used internally either. If it is, we can simply drop this PR [ghstack-poisoned]
Contributor
|
/easycla As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details. This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign. |
|
|
This function is an auxiliary function for `torch.norm`. This particular overload was not even used or tested. I hope it's not used internally either. If it is, we can simply drop this PR [ghstack-poisoned]
This function is an auxiliary function for `torch.norm`. This particular overload was not even used or tested. I hope it's not used internally either. If it is, we can simply drop this PR cc mcarilli ptrblck leslie-fang-intel jgong5 [ghstack-poisoned]
This function is an auxiliary function for `torch.norm`. This particular overload was not even used or tested. I hope it's not used internally either. If it is, we can simply drop this PR cc mcarilli ptrblck leslie-fang-intel jgong5 [ghstack-poisoned]
This function is an auxiliary function for `torch.norm`. This particular overload was not even used or tested. I hope it's not used internally either. If it is, we can simply drop this PR cc mcarilli ptrblck leslie-fang-intel jgong5 [ghstack-poisoned]
This function is an auxiliary function for `torch.norm`. This particular overload was not even used or tested. I hope it's not used internally either. If it is, we can simply drop this PR cc mcarilli ptrblck leslie-fang-intel jgong5 [ghstack-poisoned]
This function is an auxiliary function for `torch.norm`. This particular overload was not even used or tested. I hope it's not used internally either. If it is, we can simply drop this PR cc mcarilli ptrblck leslie-fang-intel jgong5 [ghstack-poisoned]
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
Merge failedReason: 2 additional jobs have failed, first few of them are: trunk ,trunk / linux-focal-rocm5.3-py3.8 / test (default, 1, 2, linux.rocm.gpu) Details for Dev Infra teamRaised by workflow job |
Collaborator
Author
|
@pytorchbot merge -f "unrelated errors" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This function is an auxiliary function for
torch.norm. This particularoverload was not even used or tested. I hope it's not used internally
either. If it is, we can simply drop this PR
cc @mcarilli @ptrblck @leslie-fang-intel @jgong5