Skip to content

Fix and ignore some warnings that cause CI producing huge logs #8081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bddppq merged 1 commit into from
Jun 4, 2018
Merged

Fix and ignore some warnings that cause CI producing huge logs #8081

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,9 @@ if(NOT MSVC)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-unused-parameter")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-unknown-warning-option")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-unknown-pragmas")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-sign-compare")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-unused-variable")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-unused-function")
if ($ENV{WERROR})
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror")
endif($ENV{WERROR})
Expand Down
2 changes: 1 addition & 1 deletion caffe2/core/graph.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ struct Graph {
*/
void DeactivateSubgraph(std::vector<int> subgraph);

const size_t size() const {
size_t size() const {
return nodes_.size();
}

Expand Down
2 changes: 1 addition & 1 deletion caffe2/core/nomnigraph/include/nomnigraph/Representations/ControlFlow.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ class BasicBlock {
return Instructions;
}

const bool hasInstruction(NodeRef instr) const {
bool hasInstruction(NodeRef instr) const {
return Nodes.hasNode(instr);
}

Expand Down
2 changes: 1 addition & 1 deletion caffe2/share/contrib/nnpack/conv_op.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ class NNPACKConvOp final : public ConvPoolOpBase<CPUContext> {
NNPACKConvOp(const OperatorDef& operator_def, Workspace* ws)
: ConvPoolOpBase<CPUContext>(operator_def, ws),
algorithm_(getConvolutionAlgorithm()),
transformStrategy_(getConvolutionTransformStrategy()),
activation_(getActivationType()),
transformStrategy_(getConvolutionTransformStrategy()),
ws_(ws) {
OPERATOR_NEEDS_FEATURE(
this->order_ == StorageOrder::NCHW,
Expand Down