[Update ReduceOps.cpp] logsumexp: consistent notation between dim and dim_ #8045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zuoxingdong
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
ezyang
reviewed
Jun 6, 2018
| Tensor logsumexp(const Tensor &self, int64_t dim_, bool keepdim) { | ||
| int64_t dim = maybe_wrap_dim(dim_, self.dim()); | ||
| Tensor logsumexp(const Tensor &self, int64_t dim, bool keepdim) { | ||
| int64_t dim_ = maybe_wrap_dim(dim, self.dim()); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ssnl
added
the
awaiting response (this tag is deprecated)
Contributor
|
this PR is superceded by #9173 and hence can be closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.