fix for the "RuntimeError: randperm is only implemented for CPU" issue. #7957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix the "RuntimeError: randperm is only implemented for CPU" issue
fix for the "RuntimeError: randperm is only implemented for CPU" issue.
unnir
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
Member
|
Do we need this once we merge the CUDA implementation for randperm? I think that |
colesbury
reviewed
May 30, 2018
Member
colesbury
left a comment
colesbury
left a comment
There was a problem hiding this comment.
Yeah, this will still be good even with CUDA torch.randperm.
|
|
||
| def __iter__(self): | ||
| return iter(torch.randperm(len(self.data_source)).tolist()) | ||
| return iter(torch.randperm(len(self.data_source), device=RandomSampler._cpu).tolist()) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
|
@pytorchbot retest this please |
Contributor
|
CUDA randperm is now merged: #7606 |
|
Just wondering if this PR is still required for the error |
Member
|
I think we can close this PR, as now that randperm supports cuda and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6874