Skip to content

Remove python bindings for torch.slice #7924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soumith merged 3 commits into from
May 31, 2018
Merged

Remove python bindings for torch.slice #7924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
40e00b3
skip python bindings for slice
sethah May 29, 2018
bdb9fd2
remove tests
sethah May 29, 2018
0a5dd96
convert slice test to indexing
sethah May 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion test/test_autograd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2930,7 +2930,6 @@ class dont_convert(tuple):
('select', (S, S, S), (1, 2), 'dim', [0]),
('select', (S,), (0, 2), '1d'),
('narrow', (S, S, S), (1, 2, 2), 'dim', [0]),
('slice', (S, S, S), (-2, 1, -1, 2)),
('squeeze', (S, 1, S, 1), NO_ARGS),
('squeeze', (1, 1, 1, 1), NO_ARGS, 'input_sizes_are_ones'),
('squeeze', (S, 1, S, 1), (1,), '1_dim', [0]),
Expand Down
20 changes: 10 additions & 10 deletions test/test_torch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3317,20 +3317,20 @@ def test_randn(self):
def test_slice(self):
empty = torch.Tensor()
x = torch.arange(0., 16).view(4, 4)
self.assertEqual(x.slice(), x)
self.assertEqual(x.slice(0, 0, 4), x)
self.assertEqual(x[:], x)
self.assertEqual(x[:4], x)
# start and stop are clamped to the size of dim
self.assertEqual(x.slice(0, 0, 5), x)
self.assertEqual(x[:5], x)
# if start >= stop then the result is empty
self.assertEqual(x.slice(0, 2, 1), empty)
self.assertEqual(x.slice(0, 2, 2), empty)
self.assertEqual(x[2:1], empty)
self.assertEqual(x[2:2], empty)
# out of bounds is also empty
self.assertEqual(x.slice(0, 10, 12), empty)
self.assertEqual(x[10:12], empty)
# additional correctness checks
self.assertEqual(x.slice(0, 0, 1).data.tolist(), [[0, 1, 2, 3]])
self.assertEqual(x.slice(0, 0, -3).data.tolist(), [[0, 1, 2, 3]])
self.assertEqual(x.slice(start=-2, end=3, dim=1).data.tolist(), [[2], [6], [10], [14]])
self.assertEqual(x.slice(0, 0, -1, 2).data.tolist(), [[0, 1, 2, 3], [8, 9, 10, 11]])
self.assertEqual(x[:1].data.tolist(), [[0, 1, 2, 3]])
self.assertEqual(x[:-3].data.tolist(), [[0, 1, 2, 3]])
self.assertEqual(x[:, -2:3].data.tolist(), [[2], [6], [10], [14]])
self.assertEqual(x[0:-1:2].data.tolist(), [[0, 1, 2, 3], [8, 9, 10, 11]])

def test_is_signed(self):
self.assertEqual(torch.IntTensor(5).is_signed(), True)
Expand Down
2 changes: 1 addition & 1 deletion tools/autograd/gen_python_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
'index',
'_indexCopy_', 'max_values', 'min_values', 'argmax', 'argmin',
'_cumsum.*', '_cumprod.*', '_sum.*', '_prod.*', '_th_sum.*', '_th_prod.*',
'arange.*', 'range.*', '_gesv.*',
'arange.*', 'range.*', '_gesv.*', 'slice',
]

PY_VARIABLE_METHODS_CPP = CodeTemplate.from_file(template_path + '/python_variable_methods.cpp')
Expand Down