Skip to content

Fix seeding random module in DataLoader #7886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soumith merged 4 commits into from
May 29, 2018
Merged

Fix seeding random module in DataLoader #7886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b57c7f9
fix seeding random module
thuyen May 27, 2018
5d25ea6
make base seed int
thuyen May 27, 2018
27726d7
follow 0.4 idiom
thuyen May 28, 2018
4ef0c19
add a test for random seeding
thuyen May 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions test/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,15 @@ def __len__(self):
return 10


class RandomDatasetMock(object):

def __getitem__(self, index):
return torch.tensor([torch.rand(1).item(), random.uniform(0, 1)])

def __len__(self):
return 1000


class TestCheckpoint(TestCase):

# Test whether checkpoint is being triggered or not. For this, we check
Expand Down Expand Up @@ -233,6 +242,20 @@ def setUp(self):
self.dataset = torch.randn(5, 3, 3, 2)
self.batch_size = 3

def test_random_seed(self):
def run():
dataloader = torch.utils.data.DataLoader(RandomDatasetMock(),
batch_size=2,
num_workers=4,
shuffle=True)
return next(iter(dataloader))

torch.manual_seed(2018)
x1 = run()
torch.manual_seed(2018)
x2 = run()
self.assertEqual(x1, x2)

def test_single_keep(self):
dataloader = torch.utils.data.DataLoader(self.dataset,
batch_size=self.batch_size,
Expand Down
2 changes: 1 addition & 1 deletion torch/utils/data/dataloader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ def __init__(self, loader):

self.sample_iter = iter(self.batch_sampler)

base_seed = torch.LongTensor(1).random_()[0]
base_seed = torch.LongTensor(1).random_().item()

if self.num_workers > 0:
self.worker_init_fn = loader.worker_init_fn
Expand Down